github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 14:51:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Revert "FEATURE: Count only approved flagged posts in user pages (#22799)" (#23962)

Browse Source 
This reverts commit 5f0bc4557fb04928a8d38cba410d316a76f1bf8c.

Through extensive internal discussion we have decided to revert
this change, as it significantly impacted moderation flow for
some Discourse site moderators, especially around "something else"
flags. We need to re-approach how flags are counted holistically,
so to that end this change is being reverted.
This commit is contained in:
Martin Brennan
2023-10-18 11:38:17 +10:00
committed by GitHub
parent 30778e5fa4
commit e91d8feab3
6 changed files with 15 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
spec/models/user_spec.rb
View File

@ -1994,43 +1994,16 @@ RSpec.describe User do
end
describe "#number_of_flagged_posts" do
fab!(:admin) { Fabricate(:admin) }
it "counts flagged posts from the user" do
Fabricate(:reviewable_flagged_post, target_created_by: user)
it "counts only approved standard flagged posts from the user" do
%i[disagree ignore delete_and_ignore].each do |review_action|
PostActionCreator
.off_topic(admin, Fabricate(:post, user: user))
.reviewable
.perform(admin, review_action)
end
%i[agree_and_keep delete_and_agree].each do |approval_action|
PostActionCreator
.off_topic(admin, Fabricate(:post, user: user))
.reviewable
.perform(admin, approval_action)
end
expect(user.number_of_flagged_posts).to eq 2
end
it "ignores custom flags from the user" do
PostActionCreator
.notify_moderators(admin, Fabricate(:post, user: user))
.reviewable
.perform(admin, :agree_and_keep)
expect(user.number_of_flagged_posts).to be_zero
expect(user.number_of_flagged_posts).to eq(1)
end
it "ignores flagged posts from another user" do
other_user = Fabricate(:user)
%i[disagree ignore delete_and_ignore agree_and_keep].each do |review_action|
PostActionCreator
.off_topic(admin, Fabricate(:post, user: other_user))
.reviewable
.perform(admin, review_action)
end
Fabricate(:reviewable_flagged_post, target_created_by: Fabricate(:user))
expect(user.number_of_flagged_posts).to be_zero
expect(user.number_of_flagged_posts).to eq(0)
end
end
end