Removed a bunch of bindings.

app/assets/javascripts/discourse.js

@@ -73,11 +73,14 @@ Discourse = Ember.Application.createWithMixins({
         user.set('unread_notifications', data.unread_notifications);
         user.set('unread_private_messages', data.unread_private_messages);
       }), user.notification_channel_position);
+
       bus.subscribe("/categories", function(data){
-        Discourse.get('site').set('categories', data.categories.map(function(c){
+        var site = Discourse.Site.instance();
-          return Discourse.Category.create(c);
+        data.categories.each(function(c){
-        }));
+          site.updateCategory(c)
+        });
       });
+
     }
   }.observes('currentUser'),
 

app/assets/javascripts/discourse/models/archetype.js

@@ -13,9 +13,9 @@ Discourse.Archetype = Discourse.Model.extend({
     return this.get('options').length > 0;
   }).property('options.@each'),
 
-  isDefault: (function() {
+  isDefault: function() {
-    return this.get('id') === Discourse.get('site.default_archetype');
+    return this.get('id') === Discourse.Site.instance().get('default_archetype');
-  }).property('id')
+  }.property('id')
 
 });
 

app/assets/javascripts/discourse/models/category.js

@@ -70,6 +70,11 @@ Discourse.Category = Discourse.Model.extend({
 });
 
 Discourse.Category.reopenClass({
+
+  list: function() {
+    return Discourse.Site.instance().get('categories');
+  },
+
   findBySlugOrId: function(slugOrId) {
     return Discourse.ajax("/categories/" + slugOrId + ".json").then(function (result) {
       return Discourse.Category.create(result.category);

app/assets/javascripts/discourse/models/composer.js

@@ -22,15 +22,18 @@ EDIT = 'edit';
 REPLY_AS_NEW_TOPIC_KEY = "reply_as_new_topic";
 
 Discourse.Composer = Discourse.Model.extend({
-  archetypesBinding: 'Discourse.site.archetypes',
 
   init: function() {
     this._super();
     var val = Discourse.KeyValueStore.get('composer.showPreview') || 'true';
     this.set('showPreview', val === 'true');
-    this.set('archetypeId', Discourse.get('site.default_archetype'));
+    this.set('archetypeId', Discourse.Site.instance().get('default_archetype'));
   },
 
+  archetypes: function() {
+    return Discourse.Site.instance().get('archetypes');
+  }.property(),
+
   creatingTopic: function() {
     return this.get('action') === CREATE_TOPIC;
   }.property('action'),
@@ -238,7 +241,7 @@ Discourse.Composer = Discourse.Model.extend({
     }
 
     this.set('categoryName', opts.categoryName || this.get('topic.category.name'));
-    this.set('archetypeId', opts.archetypeId || Discourse.get('site.default_archetype'));
+    this.set('archetypeId', opts.archetypeId || Discourse.Site.instance().get('default_archetype'));
     this.set('metaData', opts.metaData ? Em.Object.create(opts.metaData) : null);
     this.set('reply', opts.reply || this.get("reply") || "");
     if (opts.postId) {
@@ -354,7 +357,7 @@ Discourse.Composer = Discourse.Model.extend({
         user_id: currentUser.get('id'),
         metaData: this.get('metaData'),
         archetype: this.get('archetypeId'),
-        post_type: Discourse.get('site.post_types.regular'),
+        post_type: Discourse.Site.instance().get('post_types.regular'),
         target_usernames: this.get('targetUsernames'),
         actions_summary: Em.A(),
         moderator: currentUser.get('moderator'),

app/assets/javascripts/discourse/models/notification.js

@@ -19,8 +19,7 @@ Discourse.Notification = Discourse.Model.extend({
   }.property(),
 
   rendered: function() {
-    var notificationName;
+    var notificationName = Discourse.Site.instance().get('notificationLookup')[this.notification_type];
-    notificationName = Discourse.get('site.notificationLookup')[this.notification_type];
     return Em.String.i18n("notifications." + notificationName, {
       username: this.data.display_username,
       link: "<a href='" + (this.get('url')) + "'>" + this.data.topic_title + "</a>"

app/assets/javascripts/discourse/models/post.js

@@ -124,7 +124,7 @@ Discourse.Post = Discourse.Model.extend({
 
   flagsAvailable: function() {
     var _this = this;
-    var flags = Discourse.get('site.flagTypes').filter(function(item) {
+    var flags = Discourse.Site.instance().get('flagTypes').filter(function(item) {
       return _this.get("actionByName." + (item.get('name_key')) + ".can_act");
     });
     return flags;
@@ -153,7 +153,7 @@ Discourse.Post = Discourse.Model.extend({
         }
       }).then(function(result) {
         // If we received a category update, update it
-        if (result.category) Discourse.get('site').updateCategory(result.category);
+        if (result.category) Discourse.Site.instance().updateCategory(result.category);
         if (complete) complete(Discourse.Post.create(result.post));
       }, function(result) {
         // Post failed to update

app/assets/javascripts/discourse/models/site.js

@@ -8,21 +8,17 @@
 **/
 Discourse.Site = Discourse.Model.extend({
 
-  notificationLookup: (function() {
+  notificationLookup: function() {
-    var result;
+    var result = [];
-    result = [];
     Object.keys(this.get('notification_types'), function(k, v) {
       result[v] = k;
     });
     return result;
-  }).property('notification_types'),
+  }.property('notification_types'),
 
   flagTypes: function() {
-    var postActionTypes;
+    var postActionTypes = this.get('post_action_types');
-    postActionTypes = this.get('post_action_types');
+    if (!postActionTypes) return [];
-    if (!postActionTypes) {
-      return [];
-    }
     return postActionTypes.filterProperty('is_flag', true);
   }.property('post_action_types.@each'),
 

app/assets/javascripts/discourse/models/topic.js

@@ -130,9 +130,9 @@ Discourse.Topic = Discourse.Model.extend({
     return null;
   }.property('views'),
 
-  archetypeObject: (function() {
+  archetypeObject: function() {
-    return Discourse.get('site.archetypes').findProperty('id', this.get('archetype'));
+    return Discourse.Site.instance().get('archetypes').findProperty('id', this.get('archetype'));
-  }).property('archetype'),
+  }.property('archetype'),
 
   isPrivateMessage: (function() {
     return this.get('archetype') === 'private_message';

app/assets/javascripts/discourse/models/user.js

@@ -92,7 +92,7 @@ Discourse.User = Discourse.Model.extend({
     @type {Integer}
   **/
   trustLevel: function() {
-    return Discourse.get('site.trust_levels').findProperty('id', this.get('trust_level'));
+    return Discourse.Site.instance().get('trust_levels').findProperty('id', this.get('trust_level'));
   }.property('trust_level'),
 
   /**

app/assets/javascripts/discourse/routes/list_category_route.js

@@ -9,10 +9,9 @@
 Discourse.ListCategoryRoute = Discourse.FilteredListRoute.extend({
 
   model: function(params) {
-    var categories = Discourse.Site.instance().get('categories');
+    var categories = Discourse.Category.list();
 
     var slug = Em.get(params, 'slug');
-
     var category = categories.findProperty('slug', Em.get(params, 'slug'))
 
     // In case the slug didn't work, try to find it by id instead.

app/assets/javascripts/discourse/views/modal/edit_category_view.js

@@ -97,7 +97,7 @@ Discourse.EditCategoryView = Discourse.ModalBodyView.extend({
       // We need the topic_count to be correct, so get the most up-to-date info about this category from the server.
       Discourse.Category.findBySlugOrId( this.get('category.slug') || this.get('category.id') ).then( function(cat) {
         categoryView.set('category', cat);
-        Discourse.get('site').updateCategory(cat);
+        Discourse.Site.instance().updateCategory(cat);
         categoryView.set('id', categoryView.get('category.slug'));
         categoryView.set('loading', false);
       });

app/assets/javascripts/discourse/views/modal/flag_view.js

@@ -47,7 +47,7 @@ Discourse.FlagView = Discourse.ModalBodyView.extend({
     var action = this.get('selected');
     var postAction = this.get('post.actionByName.' + (action.get('name_key')));
 
-    var actionType = Discourse.get('site').postActionTypeById(this.get('postActionTypeId'));
+    var actionType = Discourse.Site.instance().postActionTypeById(this.get('postActionTypeId'));
     if (postAction) {
       postAction.act({
         message: action.get('message')

app/assets/javascripts/discourse/views/modal/login_view.js

@@ -8,11 +8,15 @@
 **/
 Discourse.LoginView = Discourse.ModalBodyView.extend({
   templateName: 'modal/login',
-  siteBinding: 'Discourse.site',
   title: Em.String.i18n('login.title'),
   authenticate: null,
   loggingIn: false,
 
+
+  site: function() {
+    return Discourse.Site.instance();
+  }.property(),
+
   showView: function(view) {
     return this.get('controller').show(view);
   },

app/assets/javascripts/discourse/views/post_view.js

@@ -29,7 +29,7 @@ Discourse.PostView = Discourse.View.extend({
   }.property('parentView'),
 
   postTypeClass: function() {
-    return this.get('post.post_type') === Discourse.get('site.post_types.moderator_action') ? 'moderator' : 'regular';
+    return this.get('post.post_type') === Discourse.Site.instance().get('post_types.moderator_action') ? 'moderator' : 'regular';
   }.property('post.post_type'),
 
   // If the cooked content changed, add the quote controls