github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: group_list site settings should store IDs instead of group names (#7860)

Browse Source 
* DEV: group_list site settings should store IDs instead of group names

* Ship site setting to know when we should migrate group_list settings

* Migrate existing group_list site settings

* Bump migration timestamp and don't set null when migrating is not possible.
This commit is contained in:
Roman Rizzi
2019-07-19 15:17:58 -03:00
committed by GitHub
parent e47e0af123
commit eb26bee046
5 changed files with 35 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/javascripts/admin/components/group-list-setting-test.js.es6
View File

@ -32,7 +32,7 @@ componentTest("default", {
setting: "foo_bar",
type: "group_list",
validValues: undefined,
value: "Donuts"
value: "1"
})
);
},
@ -42,16 +42,16 @@ componentTest("default", {
assert.equal(
subject.header().value(),
"Donuts",
"1",
"it selects the setting's value"
);
await subject.expand();
await subject.selectRowByValue("Cheese cake");
await subject.selectRowByValue("2");
assert.equal(
subject.header().value(),
"Donuts,Cheese cake",
"1,2",
"it allows to select a setting from the list of choices"
);
}