From ec73224b5e2b19300ae608d02b84e043832a0efe Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Fri, 3 Feb 2017 15:03:33 +0800 Subject: [PATCH] PERF: Remove N+1 query when saving a user. --- app/models/user.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/user.rb b/app/models/user.rb index 371c89757e5..e8078544d63 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -941,7 +941,7 @@ class User < ActiveRecord::Base domains = group.automatic_membership_email_domains.gsub('.', '\.') - if user.reload.email =~ Regexp.new("@(#{domains})$", true) && !group.users.include?(user) + if user.email =~ Regexp.new("@(#{domains})$", true) && !group.users.include?(user) group.add(user) GroupActionLogger.new(Discourse.system_user, group).log_add_user_to_group(user) end