diff --git a/app/assets/javascripts/discourse/components/d-modal.js b/app/assets/javascripts/discourse/components/d-modal.js index eeae7edc3f3..a2372013bc4 100644 --- a/app/assets/javascripts/discourse/components/d-modal.js +++ b/app/assets/javascripts/discourse/components/d-modal.js @@ -10,7 +10,7 @@ export default Component.extend({ "modalStyle", "hasPanels" ], - attributeBindings: ["data-keyboard"], + attributeBindings: ["data-keyboard", "aria-modal"], dismissable: true, title: null, subtitle: null, @@ -28,6 +28,8 @@ export default Component.extend({ // We handle ESC ourselves "data-keyboard": "false", + // Inform screenreaders of the modal + "aria-modal": "true", @on("didInsertElement") setUp() { diff --git a/app/assets/javascripts/discourse/components/related-messages.js b/app/assets/javascripts/discourse/components/related-messages.js index 46732424f8d..1e1457db7d8 100644 --- a/app/assets/javascripts/discourse/components/related-messages.js +++ b/app/assets/javascripts/discourse/components/related-messages.js @@ -2,8 +2,7 @@ import discourseComputed from "discourse-common/utils/decorators"; import Component from "@ember/component"; export default Component.extend({ - elementId: "related-messages", - classNames: ["suggested-topics"], + tagName: "", @discourseComputed("topic") targetUser(topic) { diff --git a/app/assets/javascripts/discourse/components/suggested-topics.js b/app/assets/javascripts/discourse/components/suggested-topics.js index 9d5b83839ad..11dc410ab00 100644 --- a/app/assets/javascripts/discourse/components/suggested-topics.js +++ b/app/assets/javascripts/discourse/components/suggested-topics.js @@ -5,8 +5,7 @@ import { categoryBadgeHTML } from "discourse/helpers/category-link"; import Site from "discourse/models/site"; export default Component.extend({ - elementId: "suggested-topics", - classNames: ["suggested-topics"], + tagName: "", suggestedTitleLabel: computed("topic", function() { const href = this.currentUser && this.currentUser.pmPath(this.topic); diff --git a/app/assets/javascripts/discourse/templates/application.hbs b/app/assets/javascripts/discourse/templates/application.hbs index 437754ce7b6..aeb8c91232a 100644 --- a/app/assets/javascripts/discourse/templates/application.hbs +++ b/app/assets/javascripts/discourse/templates/application.hbs @@ -9,7 +9,7 @@ {{plugin-outlet name="below-site-header" args=(hash currentPath=router._router.currentPath)}} -
+
{{plugin-outlet name="above-main-container"}}
{{#if showTop}} diff --git a/app/assets/javascripts/discourse/templates/components/related-messages.hbs b/app/assets/javascripts/discourse/templates/components/related-messages.hbs index d4443bd2c36..c16f2b6b797 100644 --- a/app/assets/javascripts/discourse/templates/components/related-messages.hbs +++ b/app/assets/javascripts/discourse/templates/components/related-messages.hbs @@ -1,14 +1,25 @@ -

- {{i18n "related_messages.title"}} -

+