github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 15:28:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: refactor flag message (#24604)

Browse Source 
- Uses a chat service: `Chat::FlatMessage`
- Moves logic inside chat api controllers
- Create a javascript chat api helper: `chatApi.flagMessage(...)`
This commit is contained in:
Joffrey JAFFEUX
2023-11-28 18:24:09 +01:00
committed by GitHub
parent de0c761516
commit ee5bdb3436
10 changed files with 336 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/chat/app/controllers/chat/api/channels_messages_flags_controller.rb Normal file
View File

@ -0,0 +1,12 @@
# frozen_string_literal: true
class Chat::Api::ChannelsMessagesFlagsController < Chat::ApiController
def create
RateLimiter.new(current_user, "flag_chat_message", 4, 1.minutes).performed!
with_service(Chat::FlagMessage) do
on_model_not_found(:message) { raise Discourse::NotFound }
on_failed_policy(:can_flag_message_in_channel) { raise Discourse::InvalidAccess }
end
end
end

37
plugins/chat/app/controllers/chat/chat_controller.rb
View File

@ -7,13 +7,7 @@ module Chat
# able to get deleted channels and recover them.
before_action :find_chat_message, only: %i[rebake message_link]
before_action :set_channel_and_chatable_with_access_check,
except: %i[
respond
message_link
set_user_chat_status
dismiss_retention_reminder
flag
]
except: %i[respond message_link set_user_chat_status dismiss_retention_reminder]
def respond
render
@ -88,35 +82,6 @@ module Chat
render json: success_json.merge(markdown: markdown)
end
def flag
RateLimiter.new(current_user, "flag_chat_message", 4, 1.minutes).performed!
permitted_params =
params.permit(
%i[chat_message_id flag_type_id message is_warning take_action queue_for_review],
)
chat_message =
Chat::Message.includes(:chat_channel, :revisions).find(permitted_params[:chat_message_id])
flag_type_id = permitted_params[:flag_type_id].to_i
if !ReviewableScore.types.values.include?(flag_type_id)
raise Discourse::InvalidParameters.new(:flag_type_id)
end
set_channel_and_chatable_with_access_check(chat_channel_id: chat_message.chat_channel_id)
result =
Chat::ReviewQueue.new.flag_message(chat_message, guardian, flag_type_id, permitted_params)
if result[:success]
render json: success_json
else
render_json_error(result[:errors])
end
end
private
def preloaded_chat_message_query