github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 16:21:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Make max number of favorite configurable (#13480)

Browse Source 
It used to be hardcoded to 2 and now it uses max_favorite_badges site
setting. When zero, it disables favorite badges.
This commit is contained in:
Bianca Nenciu
2021-06-22 18:58:03 +03:00
committed by GitHub
parent e0e1e24c14
commit ee87d8c93b
13 changed files with 40 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/user_badges_controller.rb
View File

@ -1,7 +1,6 @@
# frozen_string_literal: true
class UserBadgesController < ApplicationController
MAX_FAVORITES = 2
MAX_BADGES = 96 # This was limited in PR#2360 to make it divisible by 8
before_action :ensure_badges_enabled
@ -51,7 +50,6 @@ class UserBadgesController < ApplicationController
user_badges,
DetailedUserBadgeSerializer,
root: :user_badges,
meta: { max_favorites: MAX_FAVORITES },
)
end
@ -107,7 +105,7 @@ class UserBadgesController < ApplicationController
return render json: failed_json, status: 403
end
if !user_badge.is_favorite && user_badges.where(is_favorite: true).count >= MAX_FAVORITES
if !user_badge.is_favorite && user_badges.where(is_favorite: true).count >= SiteSetting.max_favorite_badges
return render json: failed_json, status: 400
end