github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Switch over category settings to new table - Part 3 (#20657)

Browse Source 
In #20135 we prevented invalid inputs from being accepted in category setting form fields on the front-end. We didn't do anything on the back-end at that time, because we were still discussing which path we wanted to take. Eventually we decided we want to move this to a new CategorySetting model.

This PR moves the require_topic_approval and require_reply_approval from custom fields to the new CategorySetting model.

This PR is nearly identical to #20580, which migrated num_auto_bump_daily, but since these are slightly more sensitive, they are moved after the previous one is verified.
This commit is contained in:
Ted Johansson
2023-09-12 09:51:49 +08:00
committed by GitHub
parent 07c29f3066
commit f08c6d2756
13 changed files with 178 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spec/lib/topic_view_spec.rb
View File

@ -1004,9 +1004,14 @@ RSpec.describe TopicView do
describe "#reviewable_counts" do
it "exclude posts queued because the category needs approval" do
category = Fabricate.build(:category, user: admin)
category.custom_fields[Category::REQUIRE_TOPIC_APPROVAL] = true
category.save!
category =
Fabricate.create(
:category,
user: admin,
category_setting_attributes: {
require_topic_approval: true,
},
)
manager =
NewPostManager.new(
user,
@ -1081,13 +1086,16 @@ RSpec.describe TopicView do
let(:queue_enabled) { false }
context "when category is moderated" do
before { category.custom_fields[Category::REQUIRE_REPLY_APPROVAL] = true }
before do
category.require_reply_approval = true
category.save!
end
it { expect(topic_view.queued_posts_enabled?).to be(true) }
end
context "when category is not moderated" do
it { expect(topic_view.queued_posts_enabled?).to be(nil) }
it { expect(topic_view.queued_posts_enabled?).to be(false) }
end
end
end