github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 19:39:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Automatically update groups for test users with explicit TL (#25415)

Browse Source 
For performance reasons we don't automatically add fabricated users to trust level auto-groups. However, when explicitly passing a trust level to the fabricator, in 99% of cases it means that trust level is relevant for the test, and we need the groups.

This change makes it so that when a trust level is explicitly passed to the fabricator, the auto-groups are refreshed. There's no longer a need to also pass refresh_auto_groups: true, which means clearer tests, fewer mistakes, and less confusion.
This commit is contained in:
Ted Johansson
2024-01-29 17:52:02 +08:00
committed by GitHub
parent dbdc4bbbd6
commit f0a46f8b6f
25 changed files with 92 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/models/post_spec.rb
View File

@ -276,7 +276,7 @@ RSpec.describe Post do
end
describe "maximum media embeds" do
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0], refresh_auto_groups: true) }
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0]) }
let(:post_no_images) { Fabricate.build(:post, post_args.merge(user: newuser)) }
let(:post_one_image) { post_with_body("![sherlock](http://bbc.co.uk/sherlock.jpg)", newuser) }
let(:post_two_images) do
@ -424,7 +424,7 @@ RSpec.describe Post do
end
describe "maximum attachments" do
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0], refresh_auto_groups: true) }
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0]) }
let(:post_no_attachments) { Fabricate.build(:post, post_args.merge(user: newuser)) }
let(:post_one_attachment) do
post_with_body(
@ -477,7 +477,7 @@ RSpec.describe Post do
end
describe "links" do
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0], refresh_auto_groups: true) }
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0]) }
let(:no_links) { post_with_body("hello world my name is evil trout", newuser) }
let(:one_link) { post_with_body("[jlawr](http://www.imdb.com/name/nm2225369)", newuser) }
let(:two_links) do
@ -560,7 +560,7 @@ RSpec.describe Post do
end
describe "maximums" do
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0], refresh_auto_groups: true) }
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0]) }
let(:post_one_link) do
post_with_body("[sherlock](http://www.bbc.co.uk/programmes/b018ttws)", newuser)
end
@ -689,7 +689,7 @@ RSpec.describe Post do
end
context "with max mentions" do
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0], refresh_auto_groups: true) }
fab!(:newuser) { Fabricate(:user, trust_level: TrustLevel[0]) }
let(:post_with_one_mention) { post_with_body("@Jake is the person I'm mentioning", newuser) }
let(:post_with_two_mentions) do
post_with_body("@Jake @Finn are the people I'm mentioning", newuser)
@ -1763,7 +1763,7 @@ RSpec.describe Post do
end
describe "#update_uploads_secure_status" do
fab!(:user) { Fabricate(:user, trust_level: 0, refresh_auto_groups: true) }
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[0]) }
let(:raw) { <<~RAW }
<a href="#{attachment_upload.url}">Link</a>

8
spec/models/reviewable_score_spec.rb
View File

@ -2,7 +2,7 @@
RSpec.describe ReviewableScore, type: :model do
describe "transitions" do
fab!(:user) { Fabricate(:user, trust_level: 3, refresh_auto_groups: true) }
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[3]) }
fab!(:post)
fab!(:moderator)
@ -46,9 +46,9 @@ RSpec.describe ReviewableScore, type: :model do
end
describe "overall score" do
fab!(:user0) { Fabricate(:user, trust_level: 1, refresh_auto_groups: true) }
fab!(:user1) { Fabricate(:user, trust_level: 2, refresh_auto_groups: true) }
fab!(:user2) { Fabricate(:user, trust_level: 3, refresh_auto_groups: true) }
fab!(:user0) { Fabricate(:user, trust_level: TrustLevel[1]) }
fab!(:user1) { Fabricate(:user, trust_level: TrustLevel[2]) }
fab!(:user2) { Fabricate(:user, trust_level: TrustLevel[3]) }
fab!(:moderator) { Fabricate(:moderator, refresh_auto_groups: true) }
fab!(:post)
let(:topic) { post.topic }

2
spec/models/topic_spec.rb
View File

@ -12,7 +12,7 @@ RSpec.describe Topic do
fab!(:evil_trout)
fab!(:admin)
fab!(:group)
fab!(:trust_level_2) { Fabricate(:user, trust_level: 2, refresh_auto_groups: true) }
fab!(:trust_level_2)
it_behaves_like "it has custom fields"