github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 23:11:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Do not escape fancy_title again. (#8095)

Browse Source 
`fancy_title` is already escaped by Rails. Escaping it again would print
the HTML entity as-is, e.g. `"` instead of `"`.

This fixes the issue by introducing a new `escapedContent` attribute on
the `QuickAccessItem` widget.
This commit is contained in:
Kyle Zhao
2019-09-13 07:04:14 -07:00
committed by Robin Ward
parent 6bbda8eae9
commit f0f03acb2c
3 changed files with 55 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
test/javascripts/widgets/quick-access-item-test.js.es6 Normal file
View File

@ -0,0 +1,31 @@
import { moduleForWidget, widgetTest } from "helpers/widget-test";
moduleForWidget("quick-access-item");
const CONTENT_DIV_SELECTOR = "li > a > div";
widgetTest("content attribute is escaped", {
template: '{{mount-widget widget="quick-access-item" args=args}}',
beforeEach() {
this.set("args", { content: "<b>bold</b>" });
},
test(assert) {
const contentDiv = find(CONTENT_DIV_SELECTOR)[0];
assert.equal(contentDiv.innerText, "<b>bold</b>");
}
});
widgetTest("escapedContent attribute is not escaped", {
template: '{{mount-widget widget="quick-access-item" args=args}}',
beforeEach() {
this.set("args", { escapedContent: "&quot;quote&quot;" });
},
test(assert) {
const contentDiv = find(CONTENT_DIV_SELECTOR)[0];
assert.equal(contentDiv.innerText, '"quote"');
}
});