FEATURE: add immutable caching to rails site of things

app/controllers/application_controller.rb

@@ -66,6 +66,12 @@ class ApplicationController < ActionController::Base
     refresh_session(current_user)
   end
 
+  def immutable_for(duration)
+    response.cache_control[:max_age] = duration.to_i
+    response.cache_control[:public] = true
+    response.cache_control[:extras] = ["immutable"]
+  end
+
   def dont_cache_page
     if !response.headers["Cache-Control"] && response.cache_control.blank?
       response.headers["Cache-Control"] = "no-store, must-revalidate, no-cache, private"

app/controllers/highlight_js_controller.rb

@@ -20,7 +20,7 @@ class HighlightJsController < ApplicationController
 
       response.headers["Last-Modified"] = 10.years.ago.httpdate
       response.headers["Content-Length"] = highlight_js.bytesize.to_s
-      expires_in 1.year, public: true
+      immutable_for 1.year
 
       render text: highlight_js, disposition: nil, content_type: 'application/javascript'
     end

app/controllers/static_controller.rb

@@ -117,7 +117,7 @@ class StaticController < ApplicationController
       response.headers["Content-Length"] = @@default_favicon.bytesize.to_s
       render text: @@default_favicon, content_type: "image/png"
     else
-      expires_in 1.year, public: true
+      immutable_for 1.year
       response.headers["Expires"] = 1.year.from_now.httpdate
       response.headers["Content-Length"] = data.bytesize.to_s
       response.headers["Last-Modified"] = Time.new('2000-01-01').httpdate
@@ -151,7 +151,7 @@ class StaticController < ApplicationController
     response.headers["Cache-Control"] = 'max-age=31557600, public'
     response.headers["Content-Encoding"] = 'br'
 
-    expires_in 1.year, public: true, must_revalidate: false
+    immutable_for 1.year
 
     send_file(path, opts)
   end
@@ -163,7 +163,7 @@ class StaticController < ApplicationController
     # SECURITY what if path has /../
     raise Discourse::NotFound unless path.start_with?(Rails.root.to_s + "/public/assets")
 
-    expires_in 1.year, public: true
+    immutable_for 1.year
 
     response.headers["Expires"] = 1.year.from_now.httpdate
     response.headers["Access-Control-Allow-Origin"] = params[:origin] if params[:origin]

app/controllers/stylesheets_controller.rb

@@ -41,7 +41,7 @@ class StylesheetsController < ApplicationController
     end
 
     response.headers['Last-Modified'] = stylesheet_time.httpdate if stylesheet_time
-    expires_in 1.year, public: true unless Rails.env == "development"
+    immutable_for(1.year) unless Rails.env == "development"
     send_file(location, disposition: :inline)
   end
 

app/controllers/user_avatars_controller.rb

@@ -40,7 +40,7 @@ class UserAvatarsController < ApplicationController
 
     response.headers["Last-Modified"] = File.ctime(image).httpdate
     response.headers["Content-Length"] = File.size(image).to_s
-    expires_in 1.year, public: true
+    immutable_for(1.year)
     send_file image, disposition: nil
   end
 
@@ -57,7 +57,7 @@ class UserAvatarsController < ApplicationController
 
     response.headers["Last-Modified"] = File.ctime(image).httpdate
     response.headers["Content-Length"] = File.size(image).to_s
-    expires_in 1.year, public: true
+    immutable_for(1.year)
     send_file image, disposition: nil
   end
 
@@ -112,7 +112,7 @@ class UserAvatarsController < ApplicationController
     if image
       response.headers["Last-Modified"] = File.ctime(image).httpdate
       response.headers["Content-Length"] = File.size(image).to_s
-      expires_in 1.year, public: true
+      immutable_for 1.year
       send_file image, disposition: nil
     else
       render_blank
@@ -139,7 +139,7 @@ class UserAvatarsController < ApplicationController
     # putting a bogus date cause download is not retaining the data
     response.headers["Last-Modified"] = DateTime.parse("1-1-2000").httpdate
     response.headers["Content-Length"] = File.size(path).to_s
-    expires_in 1.year, public: true
+    immutable_for(1.year)
     send_file path, disposition: nil
   end
 

spec/controllers/user_avatars_controller_spec.rb

@@ -46,7 +46,7 @@ describe UserAvatarsController do
 
       get :show, size: 98, username: user.username, version: upload.id, hostname: 'default'
       expect(response.body).to eq("image")
-      expect(response.headers["Cache-Control"]).to eq('max-age=31557600, public')
+      expect(response.headers["Cache-Control"]).to eq('max-age=31557600, public, immutable')
     end
 
     it 'serves image even if size missing and its in local mode' do