github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 01:56:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Pretender errors were being swallowed

Browse Source 
Lots of test were broken and needed fixes.
This commit is contained in:
Robin Ward
2020-08-05 15:07:41 -04:00
parent b0564205d9
commit f1b6b1bd0e
4 changed files with 29 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
test/javascripts/helpers/create-pretender.js
View File

@ -2,20 +2,22 @@ import User from "discourse/models/user";
export function parsePostData(query) {
const result = {};
query.split("&").forEach(function(part) {
const item = part.split("=");
const firstSeg = decodeURIComponent(item[0]);
const m = /^([^\[]+)\[(.+)\]/.exec(firstSeg);
if (query) {
query.split("&").forEach(function(part) {
const item = part.split("=");
const firstSeg = decodeURIComponent(item[0]);
const m = /^([^\[]+)\[(.+)\]/.exec(firstSeg);
const val = decodeURIComponent(item[1]).replace(/\+/g, " ");
if (m) {
let key = m[1];
result[key] = result[key] || {};
result[key][m[2].replace("][", ".")] = val;
} else {
result[firstSeg] = val;
}
});
const val = decodeURIComponent(item[1]).replace(/\+/g, " ");
if (m) {
let key = m[1];
result[key] = result[key] || {};
result[key][m[2].replace("][", ".")] = val;
} else {
result[firstSeg] = val;
}
});
}
return result;
}
@ -245,6 +247,7 @@ export function applyDefaultHandlers(pretender) {
pretender.get("/t/280.json", () => response(fixturesByUrl["/t/280/1.json"]));
pretender.get("/t/34.json", () => response(fixturesByUrl["/t/34/1.json"]));
pretender.get("/t/34/4.json", () => response(fixturesByUrl["/t/34/1.json"]));
pretender.get("/t/280/:post_number.json", () =>
response(fixturesByUrl["/t/280/1.json"])
);
@ -255,7 +258,9 @@ export function applyDefaultHandlers(pretender) {
pretender.get("/t/12.json", () => response(fixturesByUrl["/t/12/1.json"]));
pretender.put("/t/1234/re-pin", success);
pretender.get("/t/2480.json", () => response(fixturesByUrl["/t/2480/1.json"]));
pretender.get("/t/2480.json", () =>
response(fixturesByUrl["/t/2480/1.json"])
);
pretender.get("/t/id_for/:slug", () => {
return response({