DEV: Remove buffered rendering from popup-input-tips

This is another refactoring in the multi-step process to remove all uses
of our custom Render Buffer.

Previous commit: fe9293b8b554ab79636faa61a4756d5ff514a233 in this
series.

This commit affects the display of popup input tips, like in the
composer when the title is too short or too long. It is just a refactor
and does not change any functionality.

app/assets/javascripts/discourse/components/popup-input-tip.js.es6

@@ -5,15 +5,15 @@ import {
   default as discourseComputed,
   observes
 } from "discourse-common/utils/decorators";
-import { bufferedRender } from "discourse-common/lib/buffered-render";
 
-export default Component.extend(
-  bufferedRender({
+export default Component.extend({
   classNameBindings: [":popup-tip", "good", "bad", "lastShownAt::hide"],
   animateAttribute: null,
   bouncePixels: 6,
   bounceDelay: 100,
   rerenderTriggers: ["validation.reason"],
+  closeIcon: `${iconHTML("times-circle")}`.htmlSafe(),
+  tipReason: null,
 
   click() {
     this.set("shownAt", null);
@@ -33,8 +33,7 @@ export default Component.extend(
     if (this.lastShownAt) {
       var $elem = $(this.element);
       if (!this.animateAttribute) {
-          this.animateAttribute =
-            $elem.css("left") === "auto" ? "right" : "left";
+        this.animateAttribute = $elem.css("left") === "auto" ? "right" : "left";
       }
       if (this.animateAttribute === "left") {
         this.bounceLeft($elem);
@@ -44,15 +43,14 @@ export default Component.extend(
     }
   },
 
-    buildBuffer(buffer) {
-      const reason = this.get("validation.reason");
-      if (!reason) {
-        return;
+  didReceiveAttrs() {
+    this._super(...arguments);
+    let reason = this.get("validation.reason");
+    if (reason) {
+      this.set("tipReason", `${reason}`.htmlSafe());
+    } else {
+      this.set("tipReason", null);
     }
-
-      buffer.push(
-        `<span class='close'>${iconHTML("times-circle")}</span>${reason}`
-      );
   },
 
   bounceLeft($elem) {
@@ -70,5 +68,4 @@ export default Component.extend(
         .animate({ right: "+=" + this.bouncePixels }, this.bounceDelay);
     }
   }
-  })
-);
+});

app/assets/javascripts/discourse/templates/components/popup-input-tip.hbs

@@ -0,0 +1 @@
+<span class='close'>{{closeIcon}}</span>{{tipReason}}