github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 19:57:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Store Reviewable's force_review as a boolean. (#11219)

Browse Source 
* FIX: Store Reviewable's force_review as a boolean.

Using the `force_review` flag raises the score to hit the minimum visibility threshold. This strategy turned out to be ineffective on sites with a high number of flags, where these values could rapidly fluctuate.

This change adds a `force_review` column on the reviewables table and modifies the `Reviewable#list_for` method to show these items when passing the `status: :pending` option, even if the score is not high enough. ReviewableQueuedPosts and ReviewableUsers are always created using this option.
This commit is contained in:
Roman Rizzi
2020-11-13 08:19:01 -03:00
committed by GitHub
parent bd0b558a89
commit f2bef7ea8f
5 changed files with 15 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/models/reviewable_spec.rb
View File

@ -180,8 +180,8 @@ RSpec.describe Reviewable, type: :model do
before do
SiteSetting.reviewable_default_visibility = :high
Reviewable.set_priorities(high: 10)
@queued_post = Fabricate(:reviewable_queued_post, score: 0, target: post)
@queued_user = Fabricate(:reviewable_user, score: 0)
@queued_post = Fabricate(:reviewable_queued_post, score: 0, target: post, force_review: true)
@queued_user = Fabricate(:reviewable_user, score: 0, force_review: true)
end
it 'includes queued posts when searching for pending reviewables' do