mirror of
https://github.com/discourse/discourse.git
synced 2025-05-23 07:01:13 +08:00
FIX: Don't allow DiscourseConnect logins in readonly mode (#16508)
This commit is contained in:

committed by
GitHub

parent
d196ec9680
commit
f55edd54fd
@ -121,6 +121,7 @@ class SessionController < ApplicationController
|
|||||||
end
|
end
|
||||||
|
|
||||||
def sso_login
|
def sso_login
|
||||||
|
return render_sso_error(text: I18n.t("read_only_mode_enabled"), status: 503) if @readonly_mode
|
||||||
raise Discourse::NotFound.new unless SiteSetting.enable_discourse_connect
|
raise Discourse::NotFound.new unless SiteSetting.enable_discourse_connect
|
||||||
|
|
||||||
params.require(:sso)
|
params.require(:sso)
|
||||||
|
@ -1112,6 +1112,20 @@ describe SessionController do
|
|||||||
expect(logged_on_user.email).to eq(@user.email)
|
expect(logged_on_user.email).to eq(@user.email)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
context "in readonly mode" do
|
||||||
|
use_redis_snapshotting
|
||||||
|
|
||||||
|
before do
|
||||||
|
Discourse.enable_readonly_mode
|
||||||
|
end
|
||||||
|
|
||||||
|
it "disallows requests" do
|
||||||
|
get "/session/sso_login"
|
||||||
|
|
||||||
|
expect(response.status).to eq(503)
|
||||||
|
end
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
describe '#sso_provider' do
|
describe '#sso_provider' do
|
||||||
|
Reference in New Issue
Block a user