Merge pull request #2297 from ligthyear/custom-fields

Custom fields for Topic, Category, Post and Group

spec/components/concern/has_custom_fields_spec.rb

@@ -0,0 +1,156 @@
+require "spec_helper"
+
+
+describe HasCustomFields do
+
+  context "custom_fields" do
+    before do
+
+      Topic.exec_sql("create temporary table custom_fields_test_items(id SERIAL primary key)")
+      Topic.exec_sql("create temporary table custom_fields_test_item_custom_fields(id SERIAL primary key, custom_fields_test_item_id int, name varchar(256) not null, value text)")
+
+      class CustomFieldsTestItem < ActiveRecord::Base
+        include HasCustomFields
+      end
+
+      class CustomFieldsTestItemCustomField < ActiveRecord::Base
+        belongs_to :custom_fields_test_item
+      end
+    end
+
+    after do
+      Topic.exec_sql("drop table custom_fields_test_items")
+      Topic.exec_sql("drop table custom_fields_test_item_custom_fields")
+
+      # import is making my life hard, we need to nuke this out of orbit
+      des = ActiveSupport::DescendantsTracker.class_variable_get :@@direct_descendants
+      des[ActiveRecord::Base].delete(CustomFieldsTestItem)
+      des[ActiveRecord::Base].delete(CustomFieldsTestItemCustomField)
+    end
+
+    it "simple modification of custom fields" do
+      test_item = CustomFieldsTestItem.new
+
+      test_item.custom_fields["a"].should == nil
+
+      test_item.custom_fields["bob"] = "marley"
+      test_item.custom_fields["jack"] = "black"
+
+      test_item.save
+
+      test_item = CustomFieldsTestItem.find(test_item.id)
+
+      test_item.custom_fields["bob"].should == "marley"
+      test_item.custom_fields["jack"].should == "black"
+
+      test_item.custom_fields.delete("bob")
+      test_item.custom_fields["jack"] = "jill"
+
+      test_item.save
+      test_item = CustomFieldsTestItem.find(test_item.id)
+
+      test_item.custom_fields.should == {"jack" => "jill"}
+    end
+
+    it "casts integers to string without error" do
+      test_item = CustomFieldsTestItem.new
+      test_item.custom_fields["a"].should == nil
+      test_item.custom_fields["a"] = 0
+
+      test_item.custom_fields["a"].should == 0
+      test_item.save
+
+      # should be casted right after saving
+      test_item.custom_fields["a"].should == "0"
+
+      test_item = CustomFieldsTestItem.find(test_item.id)
+      test_item.custom_fields["a"].should == "0"
+    end
+
+    it "reload loads from database" do
+      test_item = CustomFieldsTestItem.new
+      test_item.custom_fields["a"] = 0
+
+      test_item.custom_fields["a"].should == 0
+      test_item.save
+
+      # should be casted right after saving
+      test_item.custom_fields["a"].should == "0"
+
+      CustomFieldsTestItem.exec_sql("UPDATE custom_fields_test_item_custom_fields SET value='1' WHERE custom_fields_test_item_id=? AND name='a'", test_item.id)
+
+      # still the same, did not load
+      test_item.custom_fields["a"].should == "0"
+
+      # refresh loads from database
+      test_item.reload.custom_fields["a"].should == "1"
+      test_item.custom_fields["a"].should == "1"
+
+    end
+    it "double save actually saves" do
+
+      test_item = CustomFieldsTestItem.new
+      test_item.custom_fields = {"a" => "b"}
+      test_item.save
+
+      test_item.custom_fields["c"] = "d"
+      test_item.save
+
+      db_item = CustomFieldsTestItem.find(test_item.id)
+      db_item.custom_fields.should == {"a" => "b", "c" => "d"}
+
+    end
+
+
+    it "handles arrays properly" do
+
+      test_item = CustomFieldsTestItem.new
+      test_item.custom_fields = {"a" => ["b", "c", "d"]}
+      test_item.save
+
+      db_item = CustomFieldsTestItem.find(test_item.id)
+      db_item.custom_fields.should == {"a" => ["b", "c", "d"]}
+
+      db_item.custom_fields["a"] = ["c", "d"]
+      db_item.save
+      db_item.custom_fields.should == {"a" => ["c", "d"]}
+
+    end
+
+    it "casts integers in arrays properly without error" do
+
+      test_item = CustomFieldsTestItem.new
+      test_item.custom_fields = {"a" => ["b", 10, "d"]}
+      test_item.save
+      test_item.custom_fields.should == {"a" => ["b", "10", "d"]}
+
+      db_item = CustomFieldsTestItem.find(test_item.id)
+      db_item.custom_fields.should == {"a" => ["b", "10", "d"]}
+
+    end
+
+    it "simple modifications don't interfere" do
+      test_item = CustomFieldsTestItem.new
+
+      test_item.custom_fields["a"].should == nil
+
+      test_item.custom_fields["bob"] = "marley"
+      test_item.custom_fields["jack"] = "black"
+      test_item.save
+
+      test_item2 = CustomFieldsTestItem.new
+
+      test_item2.custom_fields["x"].should == nil
+
+      test_item2.custom_fields["sixto"] = "rodriguez"
+      test_item2.custom_fields["de"] = "la playa"
+      test_item2.save
+
+      test_item = CustomFieldsTestItem.find(test_item.id)
+      test_item2 = CustomFieldsTestItem.find(test_item2.id)
+
+      test_item.custom_fields.should == {"jack" => "black", "bob" => "marley"}
+      test_item2.custom_fields.should == {"sixto" => "rodriguez", "de" => "la playa"}
+    end
+  end
+end