github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 11:11:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: refactor .d-modal to use BEM and improve styling (#23967)

Browse Source 
This PR refactors the following:
* leaving all the CSS applied to the old `modal-body` classes in their respective files
* made  new clean styling for `.d-modal` and refactored the template to use the new BEM classes
  * `inner-`, `middle-`, `outer-` container classes are gone and replaced with simplified `wrapper` and `container` classes  
  * use standardised max-sizes with modifiers `-large` and `-max`
  * lighter backdrop,
  * min-width to prevent puny modals
  * other styling changes regarding padding, close button,…
* pulled out all modal overrides into a general `modal-overrides` file + cleanup of outdated CSS
* pulled out login and create account modal styling into their own file, cause it's such a big override 
* removed old general login.scss file for mobile & desktop
* only kept some remainders I don't want to touch in `app/assets/stylesheets/common/base/login.scss`
This commit is contained in:
chapoi
2023-11-15 11:14:47 +01:00
committed by GitHub
parent 38e53b5e8e
commit f72899401d
68 changed files with 1362 additions and 1748 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
plugins/chat/assets/stylesheets/mobile/index.scss
View File

@ -10,7 +10,6 @@
@import "chat-side-panel";
@import "chat-thread";
@import "chat-threads-list";
@import "chat-modal-thread-settings";
@import "chat-message-thread-indicator";
@import "chat-message-creator";
@import "chat-channel-row";

4
plugins/chat/spec/system/thread_list/full_page_spec.rb
View File

@ -196,7 +196,7 @@ describe "Thread list in side panel | full page", type: :system do
thread_list_page.item_by_id(thread_1.id).click
thread_page.header.open_settings
find(".chat-modal-thread-settings__title-input").fill_in(with: new_title)
find(".modal-footer .btn-primary").click
find(".d-modal__footer .btn-primary").click
expect(thread_page.header).to have_title_content(new_title)
end
@ -208,7 +208,7 @@ describe "Thread list in side panel | full page", type: :system do
thread_list_page.item_by_id(thread_1.id).click
thread_page.header.open_settings
find(".chat-modal-thread-settings__title-input").fill_in(with: new_title)
find(".modal-footer .btn-primary").click
find(".d-modal__footer .btn-primary").click
expect(thread_page.header).to have_title_content(new_title)
end