github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 15:28:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Update rubocop-discourse to latest version

Browse Source 
The lastest version of rubocop-discourse enables rules regarding
plugins.
This commit is contained in:
Loïc Guitaut
2024-02-01 17:28:10 +01:00
committed by Loïc Guitaut
parent 7a6ba47e7b
commit f7d7092a7a
27 changed files with 169 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/chat/app/controllers/chat/api/category_chatables_controller.rb
View File

@ -1,6 +1,8 @@
# frozen_string_literal: true
class Chat::Api::CategoryChatablesController < ApplicationController
requires_plugin Chat::PLUGIN_NAME
def permissions
category = Category.find(params[:id])

14
plugins/chat/app/controllers/chat/api/channels_controller.rb
View File

@ -1,13 +1,13 @@
# frozen_string_literal: true
CHANNEL_EDITABLE_PARAMS ||= %i[name description slug]
CATEGORY_CHANNEL_EDITABLE_PARAMS ||= %i[
auto_join_users
allow_channel_wide_mentions
threading_enabled
]
class Chat::Api::ChannelsController < Chat::ApiController
CHANNEL_EDITABLE_PARAMS ||= %i[name description slug]
CATEGORY_CHANNEL_EDITABLE_PARAMS ||= %i[
auto_join_users
allow_channel_wide_mentions
threading_enabled
]
def index
permitted = params.permit(:filter, :limit, :offset, :status)

4
plugins/chat/app/controllers/chat/api/channels_current_user_notifications_settings_controller.rb
View File

@ -1,8 +1,8 @@
# frozen_string_literal: true
MEMBERSHIP_EDITABLE_PARAMS = %i[muted desktop_notification_level mobile_notification_level]
class Chat::Api::ChannelsCurrentUserNotificationsSettingsController < Chat::Api::ChannelsController
MEMBERSHIP_EDITABLE_PARAMS = %i[muted desktop_notification_level mobile_notification_level]
def update
settings_params = params.require(:notifications_settings).permit(MEMBERSHIP_EDITABLE_PARAMS)
membership_from_params.update!(settings_params.to_h)

2
plugins/chat/app/controllers/chat/api/hints_controller.rb
View File

@ -1,6 +1,8 @@
# frozen_string_literal: true
class Chat::Api::HintsController < ApplicationController
requires_plugin Chat::PLUGIN_NAME
before_action :ensure_logged_in
def check_group_mentions

8
plugins/chat/app/controllers/chat/api_controller.rb
View File

@ -2,18 +2,10 @@
module Chat
class ApiController < ::Chat::BaseController
before_action :ensure_logged_in
before_action :ensure_can_chat
include Chat::WithServiceHelper
private
def ensure_can_chat
raise Discourse::NotFound unless SiteSetting.chat_enabled
guardian.ensure_can_chat!
end
def default_actions_for_service
proc do
on_success { render(json: success_json) }

3
plugins/chat/app/controllers/chat/base_controller.rb
View File

@ -2,13 +2,14 @@
module Chat
class BaseController < ::ApplicationController
requires_plugin Chat::PLUGIN_NAME
before_action :ensure_logged_in
before_action :ensure_can_chat
private
def ensure_can_chat
raise Discourse::NotFound unless SiteSetting.chat_enabled
guardian.ensure_can_chat!
end