github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-06 23:07:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Rename fill_input -> set_input in AceEditor page object (#31825)

Browse Source 
Follow up to dd015af0b8e9528eaabd690299cde12a0fdbe7de
This commit is contained in:
Alan Guo Xiang Tan
2025-03-14 22:16:53 +08:00
committed by GitHub
parent 20d19d9ca9
commit f9bedc76f2
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/system/admin_editing_objects_typed_theme_setting_spec.rb
View File

@ -122,7 +122,7 @@ RSpec.describe "Admin editing objects type theme setting", type: :system do
theme_settings_editor = admin_customize_themes_page.click_theme_settings_editor_button theme_settings_editor = admin_customize_themes_page.click_theme_settings_editor_button
theme_settings_editor.fill_in(<<~SETTING) theme_settings_editor.set_input(<<~SETTING)
[ [
{ {
"setting": "objects_setting", "setting": "objects_setting",

4
spec/system/page_objects/components/ace_editor.rb
View File

@ -8,7 +8,7 @@ module PageObjects
self self
end end
def fill_input(content) def set_input(content)
# Can't rely on capybara here because ace editor is not a normal input. # Can't rely on capybara here because ace editor is not a normal input.
page.evaluate_script( page.evaluate_script(
"ace.edit(document.getElementsByClassName('ace')[0]).setValue(#{content.to_json})", "ace.edit(document.getElementsByClassName('ace')[0]).setValue(#{content.to_json})",
@ -17,7 +17,7 @@ module PageObjects
end end
def clear_input def clear_input
fill_input("") set_input("")
end end
def editor_input def editor_input

4
spec/system/page_objects/components/admin_theme_settings_editor.rb
View File

@ -8,8 +8,8 @@ module PageObjects
self self
end end
def fill_in(settings) def set_input(settings)
editor.fill_input(settings) editor.set_input(settings)
self self
end end