FEATURE: Add revoke and reconnect functionality for google logins

This commit is contained in:
David Taylor
2018-07-25 16:03:14 +01:00
parent 578c8e861b
commit fa399ce1c5
3 changed files with 75 additions and 3 deletions

View File

@ -58,6 +58,35 @@ describe Auth::GoogleOAuth2Authenticator do
expect(result.user.id).to eq(user.id)
end
it 'can connect to a different existing user account' do
authenticator = Auth::GoogleOAuth2Authenticator.new
user1 = Fabricate(:user)
user2 = Fabricate(:user)
GoogleUserInfo.create!(user_id: user1.id, google_user_id: 100)
hash = {
uid: "100",
info: {
name: "John Doe",
email: user1.email
},
extra: {
raw_info: {
email: user1.email,
email_verified: true,
name: "John Doe"
}
}
}
result = authenticator.after_authenticate(hash, existing_account: user2)
expect(result.user.id).to eq(user2.id)
expect(GoogleUserInfo.exists?(user_id: user1.id)).to eq(false)
expect(GoogleUserInfo.exists?(user_id: user2.id)).to eq(true)
end
it 'can create a proper result for non existing users' do
hash = {
uid: "123456789",
@ -81,4 +110,21 @@ describe Auth::GoogleOAuth2Authenticator do
expect(result.extra_data[:name]).to eq("Jane Doe")
end
end
context 'revoke' do
let(:user) { Fabricate(:user) }
let(:authenticator) { Auth::GoogleOAuth2Authenticator.new }
it 'raises exception if no entry for user' do
expect { authenticator.revoke(user) }.to raise_error(Discourse::NotFound)
end
it 'revokes correctly' do
GoogleUserInfo.create!(user_id: user.id, google_user_id: 12345, email: 'someuser@somedomain.tld')
expect(authenticator.can_revoke?).to eq(true)
expect(authenticator.revoke(user)).to eq(true)
expect(authenticator.description_for_user(user)).to eq("")
end
end
end