github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

remove "track external right clicks" feature

Browse Source
This commit is contained in:
Arpit Jalan
2018-07-29 14:26:24 +05:30
parent 3dbaaf0d74
commit fc3b904e1f
8 changed files with 9 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/javascripts/lib/click-track-test.js.es6
View File

@ -132,41 +132,6 @@ QUnit.test("updates badge counts correctly", function(assert) {
badgeClickCount(assert, "with-badge", 2);
});
var trackRightClick = function() {
var clickEvent = generateClickEventOn("a");
clickEvent.which = 3;
return track(clickEvent);
};
QUnit.test("right clicks change the href", function(assert) {
assert.ok(trackRightClick());
assert.equal(
fixture("a")
.first()
.prop("href"),
"http://www.google.com/"
);
});
QUnit.test("right clicks are tracked", function(assert) {
Discourse.SiteSettings.track_external_right_clicks = true;
trackRightClick();
assert.equal(
fixture("a")
.first()
.attr("href"),
"/clicks/track?url=http%3A%2F%2Fwww.google.com&post_id=42&topic_id=1337"
);
});
QUnit.test("preventDefault is not called for right clicks", function(assert) {
var clickEvent = generateClickEventOn("a");
clickEvent.which = 3;
sandbox.stub(clickEvent, "preventDefault");
assert.ok(track(clickEvent));
assert.ok(!clickEvent.preventDefault.calledOnce);
});
var testOpenInANewTab = function(description, clickEventModifier) {
test(description, function(assert) {
var clickEvent = generateClickEventOn("a");