github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 02:48:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: do not overrider trigger when equals 0 (#29269)

Browse Source 
This commit is fixing the path which sets a default value to trigger. We were doing `if (!this.model.trigger)` but `this.model.trigger` can have `0` as value, which would trigger this codepath and this codepath was setting the first value of `badgeTriggers` as a default value for trigger.
This commit is contained in:
Joffrey JAFFEUX
2024-10-18 08:34:34 +09:00
committed by GitHub
parent faa9489245
commit fdd4804a8d
3 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/system/admin_badges_spec.rb
View File

@ -92,6 +92,18 @@ describe "Admin Badges Page", type: :system do
expect(badges_page.form.field("auto_revoke")).to be_unchecked
expect(badges_page.form.field("target_posts")).to be_unchecked
end
context "when trigger is 0" do
fab!(:badge) do
Fabricate(:badge, enabled: true, icon: "trick-medial", query: "a query", trigger: 0)
end
it "doesn't override the trigger value" do
badges_page.visit_page(badge.id)
expect(badges_page.form.field("trigger").value).to eq("0")
end
end
end
context "when deleting a badge" do