github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-19 22:23:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Do not let composer affect chat window height (#32423)

Browse Source
This commit is contained in:
Jordan Vidrine
2025-04-24 09:32:28 -05:00
committed by GitHub
parent bc6dae07ee
commit fe12500767
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/app/components/composer-body.js
View File

@ -133,7 +133,9 @@ export default class ComposerBody extends Component {
this.lastMousePos = mouseYPos(event); this.lastMousePos = mouseYPos(event);
DRAG_EVENTS.forEach((dragEvent) => { DRAG_EVENTS.forEach((dragEvent) => {
document.addEventListener(dragEvent, this.throttledPerformDrag); document.addEventListener(dragEvent, this.throttledPerformDrag, {
capture: true,
});
}); });
END_DRAG_EVENTS.forEach((endDragEvent) => { END_DRAG_EVENTS.forEach((endDragEvent) => {
@ -148,7 +150,9 @@ export default class ComposerBody extends Component {
this.appEvents.trigger("composer:resize-ended"); this.appEvents.trigger("composer:resize-ended");
DRAG_EVENTS.forEach((dragEvent) => { DRAG_EVENTS.forEach((dragEvent) => {
document.removeEventListener(dragEvent, this.throttledPerformDrag); document.removeEventListener(dragEvent, this.throttledPerformDrag, {
capture: true,
});
}); });
END_DRAG_EVENTS.forEach((endDragEvent) => { END_DRAG_EVENTS.forEach((endDragEvent) => {

1
app/assets/stylesheets/common/base/compose.scss
View File

@ -1,6 +1,5 @@
html.composer-open { html.composer-open {
#main-outlet { #main-outlet {
padding-bottom: var(--composer-height);
transition: padding-bottom 250ms ease; transition: padding-bottom 250ms ease;
} }
} }

8
plugins/chat/assets/stylesheets/common/chat-height-mixin.scss
View File

@ -5,7 +5,7 @@
var(--composer-vh, 1vh) * 100 - var(--main-outlet-offset, 0px) - 1px - var(--composer-vh, 1vh) * 100 - var(--main-outlet-offset, 0px) - 1px -
$inset $inset
); );
height: calc($base-height - var(--composer-height, 0px)); height: calc($base-height);
// mobile with keyboard opened // mobile with keyboard opened
html.keyboard-visible & { html.keyboard-visible & {
@ -14,13 +14,11 @@
// ipad // ipad
html.footer-nav-ipad & { html.footer-nav-ipad & {
height: calc($base-height - var(--composer-height, 0px)); height: calc($base-height);
} }
// PWA/HUB without keyboard // PWA/HUB without keyboard
html.footer-nav-visible:not(.keyboard-visible) & { html.footer-nav-visible:not(.keyboard-visible) & {
height: calc( height: calc($base-height - var(--footer-nav-height, 0px));
$base-height - var(--composer-height, 0px) - var(--footer-nav-height, 0px)
);
} }
} }