github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:21:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Use committed date for GitHub oneboxes (#16318)

Browse Source 
Our copy says 'committed {date}`, but we were previously using the commit's authored date
This commit is contained in:
David Taylor
2022-03-30 02:16:28 +01:00
committed by GitHub
parent fe867464d1
commit ff93833fdf
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/onebox/engine/github_commit_onebox.rb
View File

@ -35,7 +35,7 @@ module Onebox
result['title'] = lines.first result['title'] = lines.first
result['body'], result['excerpt'] = compute_body(lines[1..lines.length].join("\n")) result['body'], result['excerpt'] = compute_body(lines[1..lines.length].join("\n"))
committed_at = Time.parse(result['commit']['author']['date']) committed_at = Time.parse(result['commit']['committer']['date'])
result['committed_at'] = committed_at.strftime("%I:%M%p - %d %b %y %Z") result['committed_at'] = committed_at.strftime("%I:%M%p - %d %b %y %Z")
result['committed_at_date'] = committed_at.strftime("%F") result['committed_at_date'] = committed_at.strftime("%F")
result['committed_at_time'] = committed_at.strftime("%T") result['committed_at_time'] = committed_at.strftime("%T")

4
spec/lib/onebox/engine/github_commit_onebox_spec.rb
View File

@ -38,7 +38,7 @@ describe Onebox::Engine::GithubCommitOnebox do
end end
it "includes commit time and date" do it "includes commit time and date" do
expect(html).to include("02:03AM - 02 Aug 13") expect(html).to include("02:16AM - 02 Aug 13 UTC")
end end
it "includes number of files changed" do it "includes number of files changed" do
@ -94,7 +94,7 @@ describe Onebox::Engine::GithubCommitOnebox do
end end
it "includes commit time and date" do it "includes commit time and date" do
expect(html).to include("02:03AM - 02 Aug 13") expect(html).to include("02:16AM - 02 Aug 13 UTC")
end end
it "includes number of files changed" do it "includes number of files changed" do