mirror of
https://github.com/discourse/discourse.git
synced 2025-05-30 07:11:34 +08:00
DEV: Resolve TODO comments for martin-brennan
I am changing many of these to notes or resolving them as is, most of these I have not actively worked on in years so someone else can work on them when we get to these areas again.
This commit is contained in:
@ -53,9 +53,6 @@ module BackupRestore
|
||||
obj = s3_helper.object(filename)
|
||||
raise BackupFileExists.new if obj.exists?
|
||||
|
||||
# TODO (martin) We can remove this at a later date when we move this
|
||||
# ensure CORS for backups and direct uploads to a post-site-setting
|
||||
# change event, so the rake task doesn't have to be run manually.
|
||||
@s3_helper.ensure_cors!([S3CorsRulesets::BACKUP_DIRECT_UPLOAD])
|
||||
|
||||
presigned_url(obj, :put, UPLOAD_URL_EXPIRES_AFTER_SECONDS)
|
||||
|
Reference in New Issue
Block a user