github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Resolve TODO comments for martin-brennan

Browse Source 
I am changing many of these to notes or resolving them as is,
most of these I have not actively worked on in years so someone
else can work on them when we get to these areas again.
This commit is contained in:
Martin Brennan
2024-07-01 15:32:30 +10:00
committed by GitHub
parent 56f34e2d2b
commit ffc99253fa
12 changed files with 18 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/system/composer_uploads_spec.rb
View File

@ -43,11 +43,7 @@ describe "Uploading files in the composer", type: :system do
SiteSetting.authorized_extensions += "|mp4"
end
# TODO (martin): Video streaming is not yet available in Chrome for Testing,
# we need to come back to this in a few months and try again.
#
# c.f. https://groups.google.com/g/chromedriver-users/c/1SMbByMfO2U
xit "generates a topic preview thumbnail from the video" do
it "generates a topic preview thumbnail from the video" do
visit "/new-topic"
expect(composer).to be_opened
topic.fill_in_composer_title("Video upload test")
@ -61,8 +57,7 @@ describe "Uploading files in the composer", type: :system do
composer.submit
expect(find("#topic-title")).to have_content("Video upload test")
# I think topic list previews need to be enabled for this?
#expect(topic.image_upload_id).to eq(Upload.last.id)
expect(Topic.last.image_upload_id).to eq(Upload.last.id)
end
it "generates a thumbnail from the video" do