Commit Graph

45810 Commits

Author SHA1 Message Date
b6ed518631 REVERT: remove chat submodule (#17479) 2022-07-13 12:15:58 -04:00
ae08c72a2a DEV: Pass through --frozen-lockfile flag for yarn install (#17478)
`--production` is already passed through via the `NODE_ENV` environment variable. We can parse `$npm_config_argv` to check whether `--frozen-lockfile` was passed.
2022-07-13 16:54:45 +01:00
806e0f2885 FIX: adjust topic avatar height to fix stickiness (#17476) 2022-07-13 10:00:59 -04:00
43c0bbb6a4 FEATURE: show status in the tooltip on the status bubble on the user menu (#17451) 2022-07-13 16:02:59 +04:00
e4f042f9de DEV: Drop the server var in setup-tests (#17458) 2022-07-13 14:00:19 +02:00
605aafec30 DEV: Speed up composer autocomplete tests (#17461)
It was pausing for 1s after each keyup event.
2022-07-13 13:47:45 +02:00
1dc2b3d1bb Version bump to v2.9.0.beta7 (#17471) v2.9.0.beta7 2022-07-13 12:40:08 +01:00
075d6b83f4 DEV: add emoji handlebars helper (#17449) 2022-07-13 14:54:47 +04:00
f48a1ec648 DEV: De-jQuerify safari-hacks (#17456) 2022-07-13 12:33:39 +02:00
32c4603dd5 DEV: Remove 6-yrs old deprecated loadScript opt (#17463) 2022-07-13 12:32:35 +02:00
ee07f6da7d SECURITY: Bump Rails to 7.0.3.1 (#17469)
https://discuss.rubyonrails.org/t/81017
2022-07-13 11:17:46 +01:00
b530781d71 DEV: Remove no-op autocomplete disabler (#17460)
It was done before the autocomplete initializer, so had no effect.
2022-07-13 11:03:15 +02:00
4751ddedfb DEV: Don't flush twice (#17462)
#save-water

`flushMap` is already called in `QUnit.testDone()`
2022-07-13 11:01:41 +02:00
22b6d1b668 DEV: Remove old pretender paths (#17464) 2022-07-13 11:01:20 +02:00
83b91e9992 DEV: discourse-root should be targetable (#17459)
We can't remove it for now as themes rely on it, so we should at least be able to target it in the DOM
2022-07-13 08:31:52 +02:00
b4b87454f2 DEV: Move mini profiler badge to the right (#17468)
In the era where we have left aligned sidebar, the mini profiler badge
gets in the way
2022-07-13 13:40:12 +08:00
Joe
3a3628e9b0 UX: Fixes navigation 1px jitter (#17467)
Context: https://meta.discourse.org/t/pixel-jump-whenever-page-refreshes-mobile-desktop/231053

We currently add 1 extra pixel when we try to restore the last scroll position on a few routes. 

This is causing a bit of jumpiness, as described in the linked topic above. 

<img height="300" src="ae9e69f7fd.gif">

Notice how the content shifts by 1px while stuff loads.

I believe this 1px that we add is an artifact from the days when we used to set the header to `fixed` but I'm not sure. Either way, the header now uses `position: sticky;` so we shouldn't need that 1px adjustment.

This PR introduced no visual changes except that it fixes the jitter mentioned above.
2022-07-13 13:39:30 +08:00
Joe
8a3c02c985 FIX: Mobile usability issues in crawler view (#17465)
Google is complaining about some mobile crawler layout issues. If a post has tables, they extend outside the viewport.

<img height="300" src="https://user-images.githubusercontent.com/33972521/178642976-3d1761ad-d8cb-4c69-92b5-7be799873d5c.png">

This PR fixes that. We constrain the post to the viewport width (already determined from a parent element) and make it possible to scroll instead. 

There is no visual change here, it should act the same as it does today, but it makes Google happy.

This PR also adds a bit of margin to tags in the `/tags` page in the crawler view because Google was complaining about `Clickable elements too close together`

<img height="300" src="https://user-images.githubusercontent.com/33972521/178644327-cc3ff795-24f1-4fef-95c9-e4358a5b37bc.png">
2022-07-13 11:59:16 +08:00
fa5f3e228c DEV: Refactor user mute/ignore/disallow PM checks into central class (#17366)
The idea behind this refactor is to centralise all of the user ignoring / muting / disallow PM checks in a single place, so they can be used consistently in core as well as for plugins like chat, while improving the main bulk of the checks to run in a single fast non-AR query.

Also fixed up the invite error when someone is muting/ignoring the user that is trying to invite them to the topic.
2022-07-13 13:58:01 +10:00
58bf88d7ba DEV: Add normal as an alias for regular in NotificationLevels.topic_levels (#17466)
Follow-up to 5176c689e9
2022-07-13 06:37:38 +03:00
f1c32a3cdf Build(deps): Bump nokogiri from 1.13.6 to 1.13.7 (#17455)
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.6 to 1.13.7.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.13.6...v1.13.7)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-13 00:33:57 +02:00
638bbf8f7e DEV: prevents prop override and simplifies test (#17457) 2022-07-13 00:20:48 +02:00
a939609d32 FIX: fixes few regressions in select-kit (#17453)
- following c3fd91670e `paste` has been typoed into `pase`
- adds two tests for pasting in `multi-select` and `email-group-user-chooser`
- selectKitOptions would not be following the right overriding order
- `category-selector` was using `selectKitOptions` directly which shouldn't be the case as it's not using computed values
- apparently since a recent ember upgrade, paste event is not providing `originalEvent` anymore and `clipboardData` should be retrieved directly on the event
2022-07-12 21:38:17 +02:00
09f1ef6b05 DEV: Add plugin API to add to robots.txt (#17378)
This plugin API can be used to add to robots.txt. The event handler
receives the complete robots information before it is converted into
robots.txt.
2022-07-12 20:52:55 +03:00
2e7e48d982 UX: Add classes to create-account modal for easier customization (#17435)
Adds BEM-style classes to the input-group elements, and a dynamic class to the create-account-form element that reflects which auth provider is being used (if any).
2022-07-12 10:29:02 -07:00
be29197f62 DEV: Stop overriding an injected property in topic controller test (#17450)
Similar to e15c6302, overriding an auto-injected value like this triggers errors in more recent versions of Ember. Instead, we can use the registry to inject the value we need.

Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-07-12 17:29:11 +01:00
0c269dfd18 Update translations (#17447) 2022-07-12 17:26:04 +02:00
0e61f332ee DEV: Make sure testing-container fits in the viewport (#17446)
This prevents tests failures when the browser viewport is too small.
2022-07-12 15:32:43 +02:00
0f3109cc53 Revert "DEV: Update @popperjs/core (#17437)" (#17448)
This reverts commit 76bb8f8926b4b421cef86aa13bce0c0db6b638b4.

There is a dropdown positioning regression that needs to be investigated.
2022-07-12 15:27:52 +02:00
76bb8f8926 DEV: Update @popperjs/core (#17437) 2022-07-12 13:16:00 +02:00
f38114e161 DEV: Remove development cache-buster query parameter (#17444)
All our development-mode assets serve a `Cache-Control: no-cache` header, so a query parameter shouldn't be needed. Ember CLI does not include cache-busting parameters, so this change will move the development rails app to the same behaviour.

This will fix adding persistent breakpoints in the dev tools. Previously, the browser would think that the assets have been replaced and throw away the breakpoints.
2022-07-12 11:53:59 +01:00
8a0bddd98d DEV: Remove an unused js helpers file (#17439) 2022-07-12 12:23:21 +02:00
8bc0ec3fac DEV: Simplify test setup (#17441) 2022-07-12 12:16:17 +02:00
8a68f49adb FIX: Detect firefox < 89 as an unsupported browser (#17443)
Prior to v89, Firefox has bugs with document.execCommand("insertText"): https://bugzil.la/1220696

This commit introduces some variables to browser-detect, and therefore wraps the entire logic in an IIFE to avoid state leaking. (`let`/`const` are not supported on older browsers)
2022-07-12 10:50:06 +01:00
6c3e262a7c FIX: Set resolver options on the legacy resolver (#17440) 2022-07-12 11:42:19 +02:00
e15c63027f DEV: Use auto-injected keyValueStore for screenTrack (#17434)
This manual assignment was added before the keyValueStore was refactored into a service. Now that it's a service, it gets all our standard auto-injections, including the keyValueStore.

Overwriting an automatic injection like this raises an error in future Ember versions.
2022-07-11 22:12:25 +01:00
162a1f8ba7 DEV: Remove asset precompilation hack (#17428)
I don't think it's needed anymore?
2022-07-11 22:52:20 +02:00
365f558bda DEV: Update ember-resolver (#17432) 2022-07-11 22:52:01 +02:00
9e9e843136 DEV: Allow use of qunit notrycatch mode (#17433)
This is useful when debugging exceptions - when the box is checked, exceptions will be thrown and handled by the browser rather than being absorbed by qunit. This allows developers to intercept the exception and inspect the stack.
2022-07-11 21:40:38 +01:00
d39334b640 DEV: Remove qunit autorunner (#17430)
It was watching outdated filepaths and using the old `/qunit` page, so it seems safe to assume nobody relied on this runner?
2022-07-11 22:29:33 +02:00
006de01943 DEV: Update ember-cli-handlebars (#17429) 2022-07-11 22:25:40 +02:00
040e1650f6 DEV: Remove old redis option (#17427)
`Redis.exists_returns_integer` is now true by default
2022-07-11 22:15:30 +02:00
d90cdba70f Revert "UX: missing specificity (#17324)" (#17426)
This reverts commit 473085859851226bedbd798230a8af35f6e383c1.
2022-07-11 20:20:40 +02:00
6b57d792bb UX: Fix exp sidebar toggle alignment, add hovers (#17414) 2022-07-11 12:58:48 -04:00
1f1ba07565 FIX: update flaky bulk invite spec (#17425) 2022-07-11 11:58:23 -05:00
dd62b88f78 DEV: Switch from htmlbars-inline-precompile to ember-cli-htmlbars (#17424)
See https://github.com/ember-cli/ember-cli-htmlbars#tagged-template-usage--migrating-from-htmlbars-inline-precompile
2022-07-11 15:25:40 +01:00
2d2dc45607 Build(deps): Bump redis from 4.5.1 to 4.7.1 (#17310)
Bumps [redis](https://github.com/redis/redis-rb) from 4.5.1 to 4.7.1.
- [Release notes](https://github.com/redis/redis-rb/releases)
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/redis/redis-rb/compare/v4.5.1...v4.7.1)

---
updated-dependencies:
- dependency-name: redis
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-11 14:58:41 +02:00
f00cf7a119 DEV: uses resize observer to compute header-offset (#17399) 2022-07-11 14:50:52 +02:00
87353faac6 DEV: Implement distributed mutex in lua (#16228)
The rationale behind this was mostly to stop using `redis.synchronize` (now removed in redis gem 4.6)
2022-07-11 14:16:37 +02:00
6487179dec DEV: Don't forward test-i18n.js requests (#17422)
This fixes i18n related tests in dev env
2022-07-11 13:14:44 +02:00