Commit Graph

20339 Commits

Author SHA1 Message Date
ebf77f74b7 Revert "DEV: prevents csrf token to leak state between tests (#7746)"
This reverts commit b29d63a52d4e1ae5e0ab1127c47663dc79e953a9.
2019-06-11 12:19:49 +02:00
b29d63a52d DEV: prevents csrf token to leak state between tests (#7746) 2019-06-11 11:54:23 +02:00
e6714d3531 Revert "DEV: attempts to prevent session object to be retain in csrf init (#7743)"
This reverts commit 62c56b6e59c234bdca3fab47a0029f97ca54fbd5.
2019-06-11 10:58:32 +02:00
4deb0f6d59 DEV: prevents post-cooked decorators to leak between tests (#7744) 2019-06-11 10:02:10 +02:00
62c56b6e59 DEV: attempts to prevent session object to be retain in csrf init (#7743) 2019-06-11 09:59:14 +02:00
c407e32368 DEV: should check on object and not length (#7742) 2019-06-11 09:45:45 +02:00
e5cace9185 FIX: File size text should not be part of link. 2019-06-11 15:21:06 +08:00
fb0a655e8a FEATURE: Update pull hotlinked images to use Upload#short_url. 2019-06-11 15:17:29 +08:00
9d0fba64c0 FIX: Use attachment format in user export system post take 2. 2019-06-11 12:15:11 +08:00
a046f6ced5 FEATURE: Trigger Discourse events from authenticators. (#7724) 2019-06-11 11:28:42 +10:00
d073a7d5a8 DEV: Added commit approved notification type for discourse-code-review
We need to reserve ids in core so plugins do not clash.
2019-06-11 11:17:23 +10:00
06d974d55c FEATURE: Add base62 sha1 to cooked data attribute
* FEATURE: Add base62 sha1 to data attribute in `Post#cooked`.

* FIX: Use `Upload#short_url` when quoting an image.
2019-06-11 11:15:45 +10:00
bd538f7437 FIX: Composer preview not caching inline onebox. 2019-06-11 09:14:53 +08:00
9168ffc201 PERF: Use already loaded post when quoting or opening draft. 2019-06-11 08:21:38 +08:00
7b17eb06da FEATURE: ban any SSO attempts with invalid external id
We now treat any external_id of blank string (" " or "     " or "", etc) or a
invalid word (none, nil, blank, null) - case insensitive - as invalid.

In this case the client will see "please contact admin" the logs will explain
the reason clearly.
2019-06-11 10:04:26 +10:00
ecebff5060 Only show deprecation warning if the webhook is active 2019-06-10 16:23:12 -04:00
ace6ce0462 FIX: Add 'deleted' to the list of status filters (#7738) 2019-06-10 15:43:49 -03:00
bdfa55ee5d UX: Copyedits on reviewable filters 2019-06-10 13:45:38 -04:00
86f3e74799 DEV: Allow {{d-button}} to include a href 2019-06-10 13:24:40 -04:00
8b31b812f8 UX: Use a glyph to indicate a new topic instead of "New Topic:"
In the review queue it was easy to miss "New Topic:" so let's try a font
awesome glyph instead.
2019-06-10 12:43:20 -04:00
8c4e16eafd FIX: In reply to would sometimes have a broken link 2019-06-10 11:33:10 -04:00
af08ab5b7b Revert "DEV: prevents csrf-token initializer to leak session object (#7730)"
This reverts commit da5255e560adc545f94c5383964102129e3ba36b.
2019-06-07 18:31:16 +02:00
ebecd0b7d1 Revert "fix tests, crsf token meta is not present on tests (#7733)"
This reverts commit 240b61e844ebcd308386a0e6ed737066d7f4a4fb.
2019-06-07 18:31:13 +02:00
bae7b75e23 FIX: Updating a user profile as admin shouldn't change the user's locale 2019-06-07 17:53:46 +02:00
2dce650b72 FIX: prevents screen-track from leaking object (#7734) 2019-06-07 17:18:27 +02:00
240b61e844 fix tests, crsf token meta is not present on tests (#7733) 2019-06-07 17:11:16 +02:00
dfb66334c1 DEV: prevents global-notice events to leak (#7732) 2019-06-07 16:49:59 +02:00
55325679ac DEV: prevents share-popup to leak events (#7731) 2019-06-07 16:48:45 +02:00
da5255e560 DEV: prevents csrf-token initializer to leak session object (#7730) 2019-06-07 16:46:55 +02:00
df01249db4 FIX: removes leaking handler in select-kit (#7729) 2019-06-07 16:12:22 +02:00
fca90106b9 FIX: select-kit events were sometimes not cleaned up (#7728) 2019-06-07 15:20:01 +02:00
54afa314fb FIX: Do not download emojis in pull_hotlinked_images 2019-06-07 13:00:52 +01:00
d1228f47bb FIX: Handle missing plural keys on client 2019-06-07 10:24:17 +02:00
cbd4d06da0 PERF: only check for totp record on current user at when needed
Previously the check was done a bit too early causing one extra query
per page unconditionally for logged on users
2019-06-07 16:25:04 +10:00
a652d620f6 FIX: safari desktop doesnt support input[time] (#7719)
This commit attempts to improve the experience by:
- showing time input as disabled on any platform if date hasn't been set
- showing a placeholder --:-- to emphasize the expected format
2019-06-07 15:50:43 +10:00
a0474a0774 FIX: always take the first post in the RSS fee
`.posts.first` may be the first post and may not, depending on luck

Also add protection for corrupt topics
2019-06-07 14:57:56 +10:00
ff3a1eae3a FIX: ensure consistency should handle cases where a topic trashed
Followup to c05b6170
2019-06-07 14:57:56 +10:00
ee142c2173 DEV: More improvements to InlineUploads.
* Convert inline links to short path

```
<link> <link>
<link>
```

to

```
<short_path> <short_path>
<short_path>
```
2019-06-07 11:49:30 +08:00
c05b617067 FIX: ensure_consistency was able to create corrupt category topics
- Correct create_category_definition to skip validations and use a
transaction, no longer able to create corrupt topics

- ensure_consistency now clears topic_id if pointing at deleted or missing
topic_id

- Stop creating category definition topics for uncategorized
2019-06-07 11:20:13 +10:00
9db1fef4e3 FIX: add support for custom/plugin notification title attribute 2019-06-07 09:09:16 +08:00
1f73a3ba6d FIX: round the calculated heat values
Views heats like 12135 will become 12000, like ratios like
1.666666666667 will become 1.67.
2019-06-06 15:44:55 -04:00
35da531f1d FIX: Do not resize images in Onebox while lazy loading.
Follow-up to 35d0fd0.
2019-06-06 18:36:18 +03:00
9acd851b9a FIX: correct link to list of watched words 2019-06-06 20:21:54 +05:30
48b6391777 FIX: s/thumb-tack/thumbtack (#7718) 2019-06-06 14:43:16 +02:00
c462c2f271 FIX: prevents appEvents to leak (#7714) 2019-06-06 12:33:52 +02:00
5377d1672f DEV: Fix linting issue. 2019-06-06 13:20:16 +03:00
f63b8bb79d FIX: Periodically ensure consistency of categories. (#7663) 2019-06-06 11:30:52 +02:00
782da448a2 FIX: Missing title attribute when quoting an image. 2019-06-06 16:45:12 +08:00
2265c5102f DEV: Remove unnecessary condition.
Follow up to 21876d46d6b61740f69c43175a54b5492f321853.
2019-06-06 15:55:49 +08:00
95db609586 DEV: Support more formats of inline images. 2019-06-06 15:50:56 +08:00