Commit Graph

23001 Commits

Author SHA1 Message Date
394b5db848 FIX: Tests involving dates were logging warnings 2020-07-17 15:20:45 -04:00
bf22f7080d FEATURE: optional quote sharing buttons (#10254) 2020-07-17 14:44:31 -04:00
6e94f28cf0 FIX: Error in test mode with missing topic 2020-07-17 14:37:08 -04:00
0ecca3a2d2 FIX: tooltip is no longer used
It has been deprecated and now it's time to remove it.
2020-07-17 14:08:45 -04:00
db9162610a FIX: missing title when inserting hyperlinks 2020-07-17 10:41:58 -04:00
85d1677b26 DEV: Drop unsupported-browser plugin (#10261)
Discourse 2.6 will not have support for older browsers (e.g. IE11)
2020-07-17 15:04:06 +01:00
fab8b8649e PERF: Combine avatar_lookup and primary_group_lookup into user_lookup (#10253)
These two classes were running very similar queries, which could be expensive on large topics
2020-07-17 10:48:08 +01:00
716ccf7fe4 FIX: Bookmark search fixes (#10239)
* Remove unneeded bookmark name index.
* Change bookmark search query to use post_search_data. This allows searching on topic title and post content
* Tweak the style/layout of the bookmark list so the search looks better and the whole page fits better on mobile.
2020-07-17 15:55:07 +10:00
ff7678e210 FIX: Reindex posts when Topic#title or Category#name changes. 2020-07-17 11:12:31 +08:00
39fef99c37 FIX: add topic title back to choose-topic 2020-07-16 20:19:33 -04:00
15c4f6e4cf FIX: update meh-o icon to far-meh (#10256) 2020-07-16 16:26:17 -07:00
cc8540701e FIX: Be sure to use same units when comparing thumbnail size 2020-07-16 14:30:29 -06:00
b7fe5f04ba FIX: Deprecation usernames is now recipients 2020-07-16 16:11:52 -04:00
6ba1c64130 FIX: deprecation - usernames is now recipients 2020-07-16 15:42:51 -04:00
f13ec11c64 FEATURE: Add scopes to API keys (#9844)
* Added scopes UI

* Create scopes when creating a new API key

* Show scopes on the API key show route

* Apply scopes on API requests

* Extend scopes from plugins

* Add missing scopes. A mapping can be associated with multiple controller actions

* Only send scopes if the use global key option is disabled. Use the discourse plugin registry to add new scopes

* Add not null validations and index for api_key_id

* Annotate model

* DEV: Move default mappings to ApiKeyScope

* Remove unused attribute and improve UI for existing keys

* Support multiple parameters separated by a comma
2020-07-16 15:51:24 -03:00
766cb24989 FIX: Overwriting more computed properties 2020-07-16 13:22:13 -04:00
46e5372c06 FIX: Setting computed properties in tests 2020-07-16 11:57:50 -04:00
70771e02bb FIX: Removal of i18nPrefix deprecations 2020-07-16 10:41:11 -04:00
3252cb847c FIX: : trigger user_updated event only if email changed after user creation.
Follow-up to 1460d7957c5d9b9300034e5e36675cf44cc3bc0f
2020-07-16 18:21:30 +05:30
1460d7957c FEATURE: trigger user_updated event if email changed.
It will trigger `user_updated` Discourse event if a user_email record is created or updated or destroyed.
2020-07-16 14:20:41 +05:30
84de643c04 PERF: Reduce size of search payload by removing unused topic attributes. 2020-07-16 11:49:06 +08:00
88a43ef800 FIX: Search page bulk-select button position 2020-07-15 22:57:40 -04:00
d9475b70c7 FIX: count new and unread respects muted categories (#10131)
* FIX: count new and unread respects muted categories

countCategoryByState function should take categories muted by the user into consideration
2020-07-16 12:24:51 +10:00
1e9ce51151 FIX: Prevent thumbnail gen if image too large (#10247)
It's possible through an import or other means to have images larger
than the current max allowed image size in the db.

If this happens the thumbnail generation job will keep running
indefinitely trying to download a new copy of the original but
discarding it because it is larger than the max_file_size eventually
causing this error

`Job exception: undefined method `path' for nil:NilClass`

because the newly downloaded image is now nil.

This fix stops the enqueuing of the `GenerateTopicThumbnails` job for
all images that happen to be larger than the max image size.
2020-07-16 11:15:53 +10:00
ee88666bad FEATURE: Improve header meta alignment and truncation with css grid (#10238) 2020-07-15 19:30:35 -04:00
a04573c28e FIX: apply video preview workaround to iOS
Followup to 9e160f5
2020-07-15 19:29:43 -04:00
9c3f89c17e Let category rows occupy full width when editing topic title w/ no tags 2020-07-15 19:16:02 -04:00
9052dfe356 FEATURE: load hidden posts in segments (#10240)
* FEATURE: load hidden posts in segments

Currently, when "View hidden replies" button is clicked, all replies are loaded like there is no tomorrow. When there is plenty of hidden replies, it may cause a timeout.

Therefore, we should load them in pages and display the view link as long as we have more hidden replies.
2020-07-16 09:05:11 +10:00
34bbd51350 FIX: regression in secure URL generation, followup to 36bad0c 2020-07-15 18:52:59 -04:00
36bad0c31f FIX: Preload metadata for audio/video when secure media enabled
Fixes an issue with missing video previews. Should have no side effects now that presigned URLs expire after 5 minutes.
2020-07-15 18:36:51 -04:00
9e160f58ab FIX: Trick Safari into loading video previews (#10244) 2020-07-15 18:14:14 -04:00
4f4d8d683f FIX: add noindex header to user summary page. 2020-07-16 02:32:55 +05:30
24b3996f45 FIX: Don't overwrite maxlength computed property
We can use a `text-field` instead.
2020-07-15 16:05:37 -04:00
6fac4a36b4 FIX: loaded is a CP and can't be overwritten 2020-07-15 15:53:59 -04:00
04881b10db FIX: Error with currentCategory 2020-07-15 13:34:09 -04:00
72c5a389eb FIX: filterPlaceholder is a computed property
These cannot be overridden.
2020-07-15 13:32:27 -04:00
16766a5d62 FIX: topic.details is not a plain JS Object 2020-07-15 13:10:05 -04:00
a37a19b55c REFACTOR: Remove less effective method of injecting siteSettings 2020-07-15 11:48:55 -04:00
ca13160435 REFACTOR: Remove Discourse.SiteSettings from user/admin-user 2020-07-15 11:48:55 -04:00
a1507b2316 REFACTOR: Invite modal panels init, actions, and styling (#10242)
* Import @action rather than using actions: {}
* Set default values in functions outside of init, so the functions can be modified by modifyClass (plugin api).
* Move padding from .choices div to the input in group selector.
2020-07-15 09:18:31 -05:00
7d300006a1 Revert "PERF: Move highlightjs to a background worker, and add result cache (#10191)"
This caused a CORS error when used with S3 asset storage

This reverts commit d09f283e911c0847ca23372aceefc344526690d2.
2020-07-15 13:52:35 +01:00
c802c7367a FIX: Allow highlightjs-worker to be compiled successfully 2020-07-15 13:17:52 +01:00
d09f283e91 PERF: Move highlightjs to a background worker, and add result cache (#10191)
Syntax highlighting is a CPU-intensive process which we run a lot while rendering posts and while using the composer preview. Moving it to a background worker releases the main thread to the browser, which makes the UX much smoother.
2020-07-15 12:48:07 +01:00
0058a15266 FIX: prevent redirect when image scale btn is inside a link.
Currently in composer preview, if the image scale buttons are inside a `<a>` link then it redirects to the `href` location after the image scaling task.
2020-07-15 09:34:54 +05:30
97f581e1df FIX: add protection just in case topic is not set
Under some conditions we may be loading the composer with no topic set.
This code could fail leading to a broken composer.
2020-07-15 11:38:46 +10:00
fd083394cb MODAL: Align the close button with other header elements (#10222) 2020-07-14 21:29:36 -04:00
af7ce5d6eb Revert "DEV: Add debug hint in discourse-markdown-it"
This reverts commit 5a4855b99289664e716efcac388769a11fd2a159.
2020-07-15 11:23:28 +10:00
5a4855b992 DEV: Add debug hint in discourse-markdown-it
This console.debug message ONLY shows if isDevelopment() is
true for the environment
2020-07-15 11:18:41 +10:00
332cb5cdb1 DEV: 2 plugin outlets for group views (#10233) 2020-07-14 15:32:07 -05:00
72534223f3 FEATURE: Allow video tag attributes for video gifs 2020-07-14 13:46:45 -03:00