Commit Graph

37102 Commits

Author SHA1 Message Date
d216483c53 FIX: Importing with pgbouncer failed
Checking if all records have been imported uses a temp table in PostgreSQL. This fails when pgbouncer is used unless the temp table is created inside a transaction.
2020-03-26 16:41:09 +01:00
c94b63bc75 DEV: Improve import of attachments from Telligent 2020-03-26 16:37:55 +01:00
d21d80198c DEV: Update rubocop-discourse (#9270)
Includes:
* DEV: Use `eq_time` matcher
2020-03-26 16:32:41 +01:00
ef3d6d6580 FIX: groups filtering input was causing a full page reload (#9282) 2020-03-26 15:46:31 +01:00
7952cbb9a2 FIX: Perform crop using user-specified image sizes (#9224)
* FIX: Perform crop using user-specified image sizes

It used to resize the images to max width and height first and then
perform the crop operation. This is wrong because it ignored the user
specified image sizes from the Markdown.

* DEV: Use real images in test
2020-03-26 16:40:00 +02:00
ba1a08510e FIX: Use correct spacing in emails with code (#9274)
Follow-up-to 778454e26b5c38c94dad6ccbc9f11439a51f6b6d
2020-03-26 14:24:07 +02:00
6bceb1d15a FIX: Display small post actions when embedding a topic (#9278) 2020-03-26 09:07:41 -03:00
e62071830d DEV: prefer Date.now() over new Date().getTime()
`New Date().getTime()` is both uglier and slower than `Date.now()`

`Date.now()` is available on all the browsers we support.
2020-03-26 17:36:53 +11:00
25f1f23288 FEATURE: Stricter rules for user presence
Previously we would consider a user "present" and "last seen" if the
browser window was visible.

This has many edge cases, you could be considered present and around for
days just by having a window open and no screensaver on.

Instead we now also check that you either clicked, transitioned around app
or scrolled the page in the last minute in combination with window
visibility

This will lead to more reliable notifications via email and reduce load of
message bus for cases where a user walks away from the terminal
2020-03-26 17:36:52 +11:00
6f978bc95c FIX: First pass to improve efficiency of secure uploads rake task (#9284)
Get rid of harmful each loop over uploads to update. Instead we put all the unique access control posts for the uploads into a map for fast access (vs using the slow .find through array) and look up the post when it is needed when looping through the uploads in batches.

On a Discourse instance with ~93k uploads, a simplified version of the old method takes > 1 minute, and a simplified version of the new method takes ~18s and uses a lot less memory.
2020-03-26 15:59:57 +10:00
efd5fb665b DEV: Fix flaky time sensitive uploads.rake specs (#9283)
Also fix issues in spec where certain uploads were not considered secure
2020-03-26 13:31:39 +10:00
ecbccab159 FEATURE: invite_code is case-insensitive
Previously we required exact casing for invite code, this can cause a lot
of confusion. Relax the requirement.
2020-03-26 13:44:02 +11:00
b2aa203e67 Add additional classes to topic-map stats 2020-03-25 21:40:51 -04:00
ecb098bcbb DEV: skip this test for now, failing randomly on CI (#9280)
Works on local
2020-03-25 22:40:52 +01:00
097851c135 FIX: Change secure media to encompass attachments as well (#9271)
If the “secure media” site setting is enabled then ALL files uploaded to Discourse (images, video, audio, pdf, txt, zip etc. etc.) will follow the secure media rules. The “prevent anons from downloading files” setting will no longer have any bearing on upload security. Basically, the feature will more appropriately be called “secure uploads” instead of “secure media”.

This is being done because there are communities out there that would like all attachments and media to be secure based on category rules but still allow anonymous users to download attachments in public places, which is not possible in the current arrangement.
2020-03-26 07:16:02 +10:00
4fa580fbd1 Revert "Rename all test files from JS -> ES6"
This reverts commit 2abe85b8344de1102c1589a9ac9421a8b296f2b5.
2020-03-25 16:13:43 -04:00
a42668ead0 Revert "Another ignore entry"
This reverts commit f68c3d51fcf89d22ebc2dc343fe23b435587686a.
2020-03-25 16:13:33 -04:00
eaa324ecbd Revert "Move the widget-hbs compiler to js from es6"
This reverts commit 5d66a2c16e6bd21246e6becbef34da8ed07926bc.
2020-03-25 16:13:26 -04:00
8316500a39 Revert "FIX: Resolver wasn't being set properly"
This reverts commit 661aebdc877a80f7debb93c4d727f2242084908f.
2020-03-25 16:13:18 -04:00
a12c7fcb2f Revert "FIX: Allow JS transpilation"
This reverts commit 6d1263812f9c23c05683868b82f611964c28e14d.
2020-03-25 16:13:01 -04:00
6d1263812f FIX: Allow JS transpilation 2020-03-25 16:05:16 -04:00
661aebdc87 FIX: Resolver wasn't being set properly 2020-03-25 15:40:45 -04:00
5d66a2c16e Move the widget-hbs compiler to js from es6 2020-03-25 15:03:21 -04:00
f68c3d51fc Another ignore entry 2020-03-25 15:03:21 -04:00
2abe85b834 Rename all test files from JS -> ES6 2020-03-25 15:03:21 -04:00
6a1fe9ff87 FIX: Use 1 column instead of 4 for permalink destination (#9260) 2020-03-25 11:30:39 -07:00
b09f79366e UX: disallow tag creation in "default tags" site setting choosers. 2020-03-25 23:37:46 +05:30
6acbd1bedf DEV: allows time-input to be clearable (#9277) 2020-03-25 19:05:11 +01:00
dbc323e12a Fix the typo. 2020-03-25 23:32:32 +05:30
105cc5505c FIX: ensures we have a date object in date-time-input (#9276) 2020-03-25 17:57:43 +01:00
c14f6d4ced FEATURE: Allow plugins to exclude wizard steps (#9275) 2020-03-25 11:36:42 -05:00
0025806b7e Ignore latest 2020-03-25 12:30:20 -04:00
f2f8ede22c Last ES6 files in our app/assets/javascripts 2020-03-25 12:30:20 -04:00
55b8620b43 FIX: TopicEmbed#absolutize_urls was trying to modify a frozen string 2020-03-25 12:57:54 -03:00
3ae26c6c59 FEATURE: List search menu shortcuts in instructions modal (#9273) 2020-03-25 17:11:33 +02:00
7d7c5641b4 DEV: allows to use routeAction from components/widgets (#9267)
ATM this is only usable as a helper in templates.
2020-03-25 15:51:30 +01:00
2ed0f8d120 DEV: Remove migration which was erroneously added in d62d258f 2020-03-25 14:49:59 +00:00
d62d258fe5 Revert "FIX: word boundary regex (\b) not working in Unicode languages. (#9163)"
Lookbehind regex is not supported in Firefox or IE11

This reverts commit 572bb5988f4a46bc5f66f7e9d4a09b7241c532fb.
2020-03-25 14:34:45 +00:00
9521a88984 UI: Fix 'lock' icon spacing in category dropdown 2020-03-25 08:59:00 -05:00
572bb5988f FIX: word boundary regex (\b) not working in Unicode languages. (#9163) 2020-03-25 18:39:19 +05:30
49395ec577 FIX: Fix image optimization pipeline (#9257)
* FIX: Do not use original filename to extract the original filename

Prefer extracting filename from the destination path, which is build
using extracted image information.

* UX: Show better error images
2020-03-25 12:59:16 +02:00
cff9d4726c FIX: ensures search-menu is not briefly showing previous results (#9272) 2020-03-25 10:00:48 +01:00
70012f2027 FEATURE: Navigate through search results using J/K (#9264) 2020-03-25 15:45:35 +11:00
35e153d84f DEV: update unicorn
This is a minor update to unicorn, in this update unicorn handles
chunked encoding a bit more correctly according to RFC

Should have no impact, but message bus will be validated in production
to confirm chunked encoding still works as expected
2020-03-25 15:38:25 +11:00
7282435e17 FEATURE: Unassign the review queue topic when a flag is handled 2020-03-24 14:57:44 -07:00
2501c0cd0f FIX: user-selector was not excluding currentUser (#9266)
concat doesn't mutate the variable so it has to be assigned.
2020-03-24 22:17:26 +01:00
772583b9c3 Ignore more 2020-03-24 16:33:43 -04:00
a11938d58d Rename more es6 files to js 2020-03-24 16:32:56 -04:00
4876884fd1 More JS files 2020-03-24 16:18:56 -04:00
0fd0a04019 This should be js 2020-03-24 16:13:30 -04:00