Commit Graph

33784 Commits

Author SHA1 Message Date
86d5208b31 Pass data to url method to avoid duplication 2019-06-26 09:01:25 -04:00
ac6f7b3625 Remove notificationType argument from text 2019-06-26 09:01:25 -04:00
a3254b8446 Pull invitee accepted notification behaviour into its own class 2019-06-26 09:01:25 -04:00
7c52ba1431 Pull liked consolidated notification behaviour into its own class 2019-06-26 09:01:25 -04:00
42143a874e Pull custom notification behaviour into its own class 2019-06-26 09:01:25 -04:00
305562bf66 Pull title logic into its own method 2019-06-26 09:01:25 -04:00
d83147d137 Rename "title" variable to more apt "description" 2019-06-26 09:01:25 -04:00
02deaa4bc6 Pull icon choosing into its own method 2019-06-26 09:01:25 -04:00
36d7abed0b Pull group message summary behaviour into its own class 2019-06-26 09:01:25 -04:00
396e13aaa7 Pull liked notification behaviour in its own class 2019-06-26 09:01:25 -04:00
bd062fcbef Export DefaultNotificationItem 2019-06-26 09:01:25 -04:00
04a75b1cb3 Change the way notification items are created
Look for the specialised version first, before falling back to the
default. This allows the behaviour to be customised based on the type of
notification.
2019-06-26 09:01:25 -04:00
cdf0cd3ecd createWidgetFrom creates a new widget with an arbitrary base class 2019-06-26 09:01:25 -04:00
01a7fd4225 Make attach optionally take a list of widget names to try 2019-06-26 09:01:25 -04:00
41129f933d Rename notification-item to default-notification-item 2019-06-26 09:01:25 -04:00
7e70db3fb7 s/notName/notificationName/g 2019-06-26 09:01:25 -04:00
7c9d62c280 FIX: prevents failure when TL was mutated on internal object (#7808) 2019-06-26 14:51:45 +02:00
3c64dc3e7d FIX: do not allow creation of topic if there is no category available for posting (#7786) 2019-06-26 16:32:53 +05:30
01de7e1444 FIX: calling action with a string is deprecated (#7807) 2019-06-26 12:42:46 +02:00
e64544ae44 icon s/trash/trash-alt (#7806) 2019-06-26 12:31:49 +02:00
ea2a9bc4fc FIX: closes search-menu on escape (#7804) 2019-06-26 11:53:39 +02:00
2af4002817 Bump onebox version.
- Add a placeholder icon for Twitch onebox preview
- Add CSS for showing fontawesome play icon for placeholder class
2019-06-26 13:40:14 +05:30
39b856dce7 DEV: correct edge case introduced in 333b5a19
We need to allow users to edit uncategorized topics out of uncategorized
when for some reason admin just turns it off.
2019-06-26 17:53:29 +10:00
333b5a19b2 FIX: do not include uncategorized_category_id in topic_create_allowed if posting in uncategorized is disabled
Previously users were still allowed to create topic via API even if
uncategorized was disabled.

Not 100% happy with all this special casing, but I guess we have to do
something.

This also splits up a mega spec now that we have fab! into a more easy to
understand structure (I hope)
2019-06-26 17:41:07 +10:00
7e884cce6b Update translations 2019-06-25 10:57:18 -04:00
557805249d FIX: Ensure topic exists before making a banner. (#7781) 2019-06-25 13:49:29 +03:00
3fd7cf9038 Revert "PERF: Use Oj for serializing JSON. (#7780)"
This commit broke discourse-prometheus.

This reverts commit b4df8c546654a4e6f0ec6793bb9ed3230506be69.
2019-06-25 11:13:27 +03:00
d21594f4f7 Revert changes added by mistake in 2b19e2acc89fb2da856204c312f2e18fb5933d54. 2019-06-25 15:25:12 +08:00
2b19e2acc8 Fix typo in a0aeabbb940ec9df40625c396616d5d64b30e20f. 2019-06-25 15:18:57 +08:00
2eece2c41b UX: add shortcut for deferring topics (#7798) 2019-06-25 07:20:55 +03:00
a0aeabbb94 DEV: Safer replacement for old scheme uploads for posts:missing_uploads. 2019-06-25 11:34:26 +08:00
afb5ec811d FIX: Don't use DistributedCache to store redis readonly state
This can cause unbound CPU usage in some cases, and excessive logging in other cases. This commit moves redis readonly information into the local process, but maintains the DistributedCache for postgres readonly state.
2019-06-25 11:20:34 +08:00
f3e4e6941c DEV: Correct batch setting of categories
followup to #bc03c509

There were 2 problems

1. VALUES was not properly getting multiple results ... we need (1),(2),(3)
not (1,2,3)

2. changes was mistakenly lazy evaluated eg `changed ||=` which meant some
queries were not running
2019-06-25 13:05:43 +10:00
bc03c509ab FIX: CategoryUser#batch_set (#7787)
* Remove unused method

* Prefabricate user in category_user_spec.rb

* FIX: Remove notification_level from category_users unique indexes

* FIX: CategoryUser#batch_set wasn't updating pre-existing records

* Improve tests for CategoryUser#batch_set

* FIX: changed was being reported incorrectly

* DEV: Rewrote query to do a bulk insert

* DEV: remove unnecessary parentheses
2019-06-25 12:13:27 +10:00
6de254f642 FIX: iterate when clearing watched words cache 2019-06-24 17:17:56 -07:00
b1ca64487a FIX: multisite upload urls must have either db name or the word 'short-url'. 2019-06-25 01:19:58 +05:30
9e54e0141e FIX: mobile overflow for tall fixed modals 2019-06-24 12:24:13 -04:00
b4df8c5466 PERF: Use Oj for serializing JSON. (#7780) 2019-06-24 18:32:00 +03:00
f4e354afff FIX: ensures url to full reviewable conversation works on subfolder 2019-06-24 11:31:07 -04:00
c1ca942a77 REFACTOR: removes self pattern from safari-hacks lib (#7795) 2019-06-24 11:12:06 +02:00
e064db35d9 REFACTOR: removes self pattern from eyeline lib (#7796) 2019-06-24 10:58:59 +02:00
cea3a027f3 FIX: category-chooser search should be scoped to category (#7794) 2019-06-24 10:45:30 +02:00
f3c13d80c9 DEV: Don't copy file when trying to recover missing uploads. 2019-06-24 16:32:59 +08:00
7cabc47945 UX: improves change-timestamp modal datepicker (#7771) 2019-06-24 10:24:54 +02:00
2cc5561504 DEV: Correct description in posts:missing_uploads rake task. 2019-06-24 14:57:43 +08:00
4c89f7f881 DEV: bump version on mini_scheduler
This corrects a catastrophic state that can ensue if redis becomes readonly

It also adds support for multiple queues and minor cleanup
2019-06-24 16:56:16 +10:00
ee8669d778 FIX: Ensure :after_auth event is triggered. (#7791) 2019-06-21 21:57:49 +03:00
02f6db4e59 FIX: Back button shenanigans when redirecting from index routes
This is a problem that has long plagued Discourse. The root issue here
is that we have to implement our own link click handler, because
Discourse allows users to create HTML blobs of content with links, and
when those links are clicked they must be handled by the Ember router.

This always involved a certain amount of use of private Ember APIs which
of course evolved over time.

The API has more or less stabilized in the last two years, however we
have hacks in our URLs to handle a dynamic root path, depending on how
forums have set up their filters and in what order.

This patch adds a special case for the root path so we needn't update
the URL ourselves otherwise, which preserves the back button on index
routes. The update call would otherwise insert an extra history event if
a route redirected on transition, breaking the back button.
2019-06-21 14:42:01 -04:00
e51de4cc25 FEATURE: Add endpoint to individually update a theme setting (#7789)
- also adds a new staff action type called "change theme setting" for easier logging of staff changes to theme settings
2019-06-21 13:49:14 -04:00
2738d11f60 UX: show like icon on archived posts (#7775) 2019-06-21 20:47:32 +05:30