1cd6ff15dc
PERF: optimize homepage and topic performance ( #11607 )
...
These are a few small tweaks that slightly improve performance.
- we omitted 1 query from the post guardian which could cause an N+1
- cook_url has been sped up a bit
- url helper avoids re-creating sets for no reason
2020-12-30 13:08:02 +00:00
e0c952290b
FIX: increase inventory lag for s3 to 2 days ( #11606 )
...
Inventory on S3 always lagged, over the past few weeks we are noticing that
1 day of lag is not enough.
We are increasing this to 2, to ensure that we do not get false positive
reports.
2020-12-30 16:05:42 +11:00
6b53f26fc0
DEV: Lint MessageFormat strings to prevent usage of "one {1 foo}" ( #11605 )
2020-12-29 21:42:47 +01:00
8af6e72675
FIX: ensures recurring works when setting a start date in future ( #11587 )
2020-12-29 20:11:18 +01:00
09f9d4b281
Update translations ( #11601 )
2020-12-29 19:44:53 +01:00
8da0b4979b
FIX: S3 CDN warning was showing wrong warning message ( #11603 )
2020-12-29 14:09:55 -03:00
53f4d54f23
PERF: add indexes to speed up profile pages ( #11598 )
...
These 2 indexes optimise performance on profile pages.
The summary page displays:
1. A list of "Top Link" - links sorted by number of clicks posted by user
2. A list of "Top Replies" - replies made by a user that go the most hearts
These two areas could devolve into full index or table scans, new indexes are there to avoid this cost on large dbs
One minor downside is that storage requirements go a tiny bit up to maintain the new indexes
2020-12-29 15:54:05 +11:00
357d698557
DEV: add support for macOS in bundler ( #11600 )
...
see: 39ba1ae2b5
2020-12-29 15:39:50 +11:00
39ba1ae2b5
DEV: added platform support to bundler ( #11599 )
...
see: https://bundler.io/blog/2020/12/09/bundler-v2-2.html
New version of bundler includes explicit callouts for each platform supported
This means we need to bundle on all our supported platforms, the number should be fairly low as x86 linux covers most
2020-12-29 09:42:30 +05:30
2092493ced
DEV: Bump crack from 0.4.4 to 0.4.5 ( #11579 )
...
Bumps [crack](https://github.com/jnunemaker/crack ) from 0.4.4 to 0.4.5.
- [Release notes](https://github.com/jnunemaker/crack/releases )
- [Changelog](https://github.com/jnunemaker/crack/blob/master/History )
- [Commits](https://github.com/jnunemaker/crack/commits )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-29 13:57:30 +11:00
c3fedae73a
DEV: update rack-mini-profiler ( #11597 )
...
Included support for flamegraphs using speedscope!
2020-12-29 13:54:41 +11:00
5a0c8f2b34
Build(deps): Bump unicorn from 5.7.0 to 5.8.0 ( #11576 )
...
Bumps [unicorn](https://yhbt.net/unicorn/ ) from 5.7.0 to 5.8.0.
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 23:11:59 +01:00
491119e709
Build(deps): Bump rubocop from 1.6.1 to 1.7.0 ( #11594 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.6.1...v1.7.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 23:08:01 +01:00
e3823504cb
Build(deps): Bump regexp_parser from 2.0.1 to 2.0.3 ( #11596 )
...
Bumps [regexp_parser](https://github.com/ammar/regexp_parser ) from 2.0.1 to 2.0.3.
- [Release notes](https://github.com/ammar/regexp_parser/releases )
- [Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ammar/regexp_parser/compare/v2.0.1...v2.0.3 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 22:28:11 +01:00
4890c3ad1c
Build(deps): Bump chunky_png from 1.3.15 to 1.4.0 ( #11593 )
...
Bumps [chunky_png](https://github.com/wvanbergen/chunky_png ) from 1.3.15 to 1.4.0.
- [Release notes](https://github.com/wvanbergen/chunky_png/releases )
- [Changelog](https://github.com/wvanbergen/chunky_png/blob/master/CHANGELOG.rdoc )
- [Commits](https://github.com/wvanbergen/chunky_png/compare/v1.3.15...v1.4.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 22:27:31 +01:00
6a72fe4eda
Build(deps-dev): Bump binding_of_caller from 0.8.0 to 1.0.0 ( #11595 )
...
Bumps [binding_of_caller](https://github.com/banister/binding_of_caller ) from 0.8.0 to 1.0.0.
- [Release notes](https://github.com/banister/binding_of_caller/releases )
- [Commits](https://github.com/banister/binding_of_caller/compare/v0.8.0...v1.0.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 22:27:06 +01:00
79fe97c2bc
DEV: Fix precompile SCSS specs ( #11590 )
2020-12-28 15:28:37 -05:00
7f1bafcf63
DEV: Deprecate SCSS variable overrides in plugins ( #11589 )
2020-12-28 15:28:11 -05:00
83841fef8a
Build(deps): Bump debug_inspector from 0.0.3 to 1.0.0 ( #11588 )
...
Bumps [debug_inspector](https://github.com/banister/debug_inspector ) from 0.0.3 to 1.0.0.
- [Release notes](https://github.com/banister/debug_inspector/releases )
- [Commits](https://github.com/banister/debug_inspector/compare/v0.0.3...v1.0.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 18:12:32 +01:00
66bd5bccbc
Build(deps): Bump oj from 3.10.17 to 3.10.18 ( #11582 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.10.17 to 3.10.18.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.10.17...v3.10.18 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 17:46:18 +01:00
57501ba496
Build(deps): Bump rqrcode from 1.1.2 to 1.2.0 ( #11586 )
...
Bumps [rqrcode](https://github.com/whomwah/rqrcode ) from 1.1.2 to 1.2.0.
- [Release notes](https://github.com/whomwah/rqrcode/releases )
- [Commits](https://github.com/whomwah/rqrcode/commits/v1.2.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 17:46:04 +01:00
6168cc0644
Build(deps): Bump rspec-expectations from 3.10.0 to 3.10.1 ( #11580 )
...
Bumps [rspec-expectations](https://github.com/rspec/rspec-expectations ) from 3.10.0 to 3.10.1.
- [Release notes](https://github.com/rspec/rspec-expectations/releases )
- [Changelog](https://github.com/rspec/rspec-expectations/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-expectations/compare/v3.10.0...v3.10.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 17:45:51 +01:00
7ad397cf4d
Build(deps-dev): Bump rspec-rails from 4.0.1 to 4.0.2 ( #11583 )
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v4.0.1...v4.0.2 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 17:45:41 +01:00
e7a1bb959f
Build(deps): Bump rspec-core from 3.10.0 to 3.10.1 ( #11585 )
...
Bumps [rspec-core](https://github.com/rspec/rspec-core ) from 3.10.0 to 3.10.1.
- [Release notes](https://github.com/rspec/rspec-core/releases )
- [Changelog](https://github.com/rspec/rspec-core/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-core/compare/v3.10.0...v3.10.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 17:19:33 +01:00
330ef3700f
FEATURE: Add dash warning for using S3 without CDN ( #11561 )
...
Over the years we had some admins complaining that most of their costs
running Discourse is on S3 uploads.
That only happens when they are using S3 without a CDN, which is widely
considered a bad pratice for public websites, as egress bandwidth can
get expensive quite fast.
Related:
https://meta.discourse.org/t/download-avatars-locally-from-s3-shutting-down-s3-in-my-site/174001/3?u=falco
https://meta.discourse.org/t/use-webtorrent-to-load-media-objects/155873/2?u=falco
2020-12-28 12:43:48 -03:00
c92415d402
enhance TL2 congratulations PM ( #11577 )
...
add some detail to the TL2 congratulatory PM
2020-12-24 15:40:45 -08:00
0f005d0e86
Bump onebox gem to 2.2.1 ( #11575 )
...
- allow oneboxes with title and image
2020-12-24 10:24:59 +05:30
0dfd051a65
Build(deps-dev): Bump mocha from 1.11.2 to 1.12.0 ( #11573 )
...
Bumps [mocha](https://github.com/freerange/mocha ) from 1.11.2 to 1.12.0.
- [Release notes](https://github.com/freerange/mocha/releases )
- [Changelog](https://github.com/freerange/mocha/blob/main/RELEASE.md )
- [Commits](https://github.com/freerange/mocha/compare/v1.11.2...v1.12.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-23 16:58:40 -05:00
160649a781
Build(deps): Bump faraday from 1.1.0 to 1.2.0 ( #11572 )
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v1.1.0...v1.2.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-23 16:57:20 -05:00
9cea216ae5
Build(deps): Bump rack-mini-profiler from 2.2.0 to 2.2.1 ( #11571 )
...
Bumps [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler ) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/MiniProfiler/rack-mini-profiler/releases )
- [Changelog](https://github.com/MiniProfiler/rack-mini-profiler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/MiniProfiler/rack-mini-profiler/compare/v2.2.0...v2.2.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-23 16:53:52 -05:00
abe8aeb597
FIX: The title attribute of the diversity scales was incorrect ( #11570 )
...
It needed to be underscored, since it had dashes in it.
2020-12-23 14:12:13 -05:00
f040b5da58
Build(deps): Bump json from 2.4.1 to 2.5.1 ( #11564 )
...
Bumps [json](https://github.com/flori/json ) from 2.4.1 to 2.5.1.
- [Release notes](https://github.com/flori/json/releases )
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md )
- [Commits](https://github.com/flori/json/compare/v2.4.1...v2.5.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-23 12:32:15 +01:00
6929a6bdfb
Bump onebox gem to 2.2.0 ( #11568 )
...
- do not show title only oneboxes
2020-12-23 12:26:01 +05:30
755627caa5
FEATURE: Introduce skip_auto_delete_reply_likes site setting ( #11562 )
...
osts from topics with 'auto delete replies timer' with more than
skip_auto_delete_reply_likes likes will no longer be deleted. If 0,
all posts will be deleted.
2020-12-23 16:30:10 +11:00
edf4e8b788
FIX: user destroyer spec ( #11567 )
...
Don't user @user and @admin after https://github.com/discourse/discourse/commit/db235c5ff92
2020-12-23 15:45:53 +11:00
32ff52dd42
FIX: when the user is deleted anonymise category post ( #11551 )
...
Fix for a bug when deleting a user who was an admin and created a category.
The first post with instruction about category should not be deleted but rather anonymise.
The bug was mentioned here: https://meta.discourse.org/t/cant-undelete-category-description-posts-created-by-deleted-user/173696/10
2020-12-23 14:19:30 +11:00
d9109ed436
FIX: Show all topic statuses on full page search.
2020-12-23 10:30:35 +08:00
db235c5ff9
DEV: Improve specs to use objects that have already been fabricated.
2020-12-23 10:25:23 +08:00
f84ff26aa9
FIX: use Redis replica host and port ( #11566 )
...
Introduce Redis `replica` config and deprecate `slave`
2020-12-23 13:14:19 +11:00
5bc0efa588
DEV: Bump docile to correct Ruby 2.7 delegation issues
...
Bumps [docile](https://github.com/ms-ati/docile ) from 1.3.3 to 1.3.4.
- [Release notes](https://github.com/ms-ati/docile/releases )
- [Changelog](https://github.com/ms-ati/docile/blob/master/HISTORY.md )
- [Commits](https://github.com/ms-ati/docile/compare/v1.3.3...v1.3.4 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Corrects Ruby 2.7 delegation issues.
2020-12-23 08:52:46 +11:00
adf8539f64
FIX: allow for final sigma in suggested usernames ( #11540 )
...
Final sigma is not lower cased correctly in Ruby causing issues with routing.
This works around the issue by downcasing all usernames containing a sigma using JS.
2020-12-23 08:51:36 +11:00
758e160862
FEATURE: explicitly ban outlier traffic sources in robots.txt ( #11553 )
...
Googlebot handles no-index headers very elegantly. It advises to leave as many routes as possible open and uses headers for high fidelity rules regarding indexes.
Discourse adds special `x-robot-tags` noindex headers to users, badges, groups, search and tag routes.
Following up on b52143feff8c32f2 we now have it so Googlebot gets special handling.
Rest of the crawlers get a far more aggressive disallow list to protect against excessive crawling.
2020-12-23 08:51:14 +11:00
53f1811757
simplify copy slightly for new post / topic panel ( #11565 )
...
simplify copy slightly for new post / topic advice panel
2020-12-22 13:26:44 -08:00
3c5d91afae
DEV: Add "before-manage-group-tags" plugin outlet ( #11560 )
2020-12-22 15:35:55 -05:00
8a7fe3b276
FIX: Don't enqueue imported users when there're multiple custom fields. ( #11559 )
...
My initial implementation didn't consider this case. We should skip imported users if the "imported_id" field is present, even if there're other custom fields.
2020-12-22 14:28:07 -03:00
a4fb28ccd8
FIX: Disallow zero-width and other non-printing characters in tags ( #11546 )
2020-12-22 09:27:37 -06:00
c9381beb9c
FIX: handle badge grant for deleted badge ( #11558 )
2020-12-22 20:24:51 +05:30
e113ddc73c
Update translations ( #11557 )
2020-12-22 14:49:40 +01:00
07bf7a91f4
Revert "FIX: use Redis replica host and port ( #11543 )" ( #11552 )
...
This reverts commit b0e1210b0cbd96ff0aa1669c7f8393b8340991e8.
2020-12-22 16:16:50 +11:00
b0e1210b0c
FIX: use Redis replica host and port ( #11543 )
...
* FIX: use Redis replica host and port
Introduce Redis `replica` config and deprecate `slave`
* FIX: move deprecations to separate file
2020-12-22 15:52:00 +11:00
