Commit Graph

5364 Commits

Author SHA1 Message Date
2f7960bd2a DEV: updates prettier and displays linters/prettifiers version in CI 2018-06-20 18:34:49 +02:00
8126b603e4 fix prettier 2018-06-20 18:26:43 +02:00
c5c1b45d19 higher loglevel for prettier 2018-06-20 16:51:48 +02:00
0365806b93 FIX: Properly display error when post action fails to create. 2018-06-20 21:20:23 +08:00
ff5fc3cb08 Use a fixed limit for mega topic posts count. 2018-06-20 16:58:52 +08:00
9c925a66ff PERF: Don't display days ago on timeline for megatopics.
Analysis using `pg_stat_statements` showed this query
to be eating up a significant portion of CPU.
2018-06-20 16:25:54 +08:00
Sam
cbdab71179 PERF: stop counting participants on very large topics
This query gets very expensive and can be bypassed on large topics
2018-06-20 18:11:39 +10:00
Sam
2f0e73f2d6 DEV: fast pluck to use type_map in mini_sql 2018-06-20 17:53:49 +10:00
Sam
44091f20c6 DEV: allow for method deprecation using Discourse.deprecate
New method deprecator will ensure one log message an hour happens
for all deprecated method calls per call site

Also removes unused monkey patches to ActiveRecord::Base
2018-06-20 17:53:49 +10:00
Sam
cb824a6b33 DEV: remove all calls to SqlBuilder use DB.build instead
This is part of the migration to mini_sql, SqlBuilder.new is being
deprecated and replaced with DB.build
2018-06-20 17:53:49 +10:00
806f0ca19d FIX: URL with params for svg images should not be light boxed. 2018-06-20 10:47:14 +08:00
aedc61a3b4 FEATURE: allow large icon to be uploaded in wizard 2018-06-19 21:08:02 +05:30
24c27b5321 FEATURE: adds a add_report method accessible in plugin.rb 2018-06-19 15:00:11 +02:00
7eff64773c Revert "FIX: Don't clear active connections in defer queue."
This reverts commit c9feadf9ecf9ee2850074c616a3c83f46bc2a014.
2018-06-19 17:58:21 +08:00
df24c51c6f Revert "FIX: Don't try to dequeue an empty queue."
This reverts commit 1af7d4a894ad809de6424d043600e32e7c01bda9.
2018-06-19 15:49:45 +08:00
41c1e1b302 FIX: Discourse.keep_readonly_mode does not work for multisite. 2018-06-19 15:44:08 +08:00
1af7d4a894 FIX: Don't try to dequeue an empty queue. 2018-06-19 15:25:44 +08:00
Sam
b8e5989201 correct rake db:create, which needs a defer DB object 2018-06-19 16:43:50 +10:00
Sam
5f64fd0a21 DEV: remove exec_sql and replace with mini_sql
Introduce new patterns for direct sql that are safe and fast.

MiniSql is not prone to memory bloat that can happen with direct PG usage.
It also has an extremely fast materializer and very a convenient API

- DB.exec(sql, *params) => runs sql returns row count
- DB.query(sql, *params) => runs sql returns usable objects (not a hash)
- DB.query_hash(sql, *params) => runs sql returns an array of hashes
- DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array
- DB.build(sql) => returns a sql builder

See more at: https://github.com/discourse/mini_sql
2018-06-19 16:13:36 +10:00
Sam
cc3fc87dd7 DEV: handle termination cleanly in autospec 2018-06-19 16:13:36 +10:00
c9feadf9ec FIX: Don't clear active connections in defer queue. 2018-06-19 12:45:16 +08:00
34e4c8f573 FIX: Discourse.keep_readonly_mode spins a new thread each time it is called. 2018-06-19 10:24:08 +08:00
6e97242bb9 Monkey patch in 7830a950ef 2018-06-19 09:45:48 +08:00
68e4e6a575 FIX: staged users are still tl0 but do not trigger spam if 1 week old. 2018-06-18 17:20:04 -07:00
630b4570ef Add specs for RateLimiter::LimitExceeded#description. 2018-06-19 07:48:03 +08:00
3725fd8345 Merge pull request #6002 from featheredtoast/trust-previously-staged-users
FIX: don't punish a user for being previously staged for spam flags.
2018-06-18 15:14:31 -04:00
320cd9a19e UX: rate limiter message will say to wait "a few seconds" instead of 0 to 3 seconds 2018-06-18 14:14:47 -04:00
913d97e780 fix prettier 2018-06-18 20:10:48 +02:00
6f2c5ea1f2 increases loglevel to debug CI only failure 2018-06-18 19:25:54 +02:00
9963078dd1 Add to offical plugins list 2018-06-18 10:20:49 -06:00
e5c156b226 Add characters-required to official plugins list 2018-06-18 10:30:46 -04:00
c18b86d9b2 UX: Don't add light box for SVG images. 2018-06-18 17:11:06 +08:00
9e55767f6a FIX: don't punish a user for being previously staged for spam flags. 2018-06-15 12:25:25 -07:00
03a7d532cf DEV: introduces prettier for es6 files 2018-06-15 17:03:24 +02:00
c7ee70941e FEATURE: show category page options on wizard 'homepage' step 2018-06-15 19:11:41 +05:30
2427c0a17c FIX: theme CSS should recompile when theme uploads change 2018-06-15 13:12:09 +10:00
c34100d1e7 Remove unused variable. 2018-06-15 07:45:51 +08:00
6123f61f5f seconds is not needed here 2018-06-14 20:53:24 +10:00
Sam
87fabdc2f3 FIX: correct pool reaper
This removes a freedom patch and replaces with a custom reaper thread
it also captures an issue where reaper would fail when connections where
empty
2018-06-14 18:22:02 +10:00
Sam
71aa20bd30 FIX: pool drainer to use Rails 5.2 implementation
old implementation did not reap abandoned connections
2018-06-14 15:54:48 +10:00
Sam
66982c7800 FIX: stop using Rails connection reaper in multisite
The Rails 5.2 connection reaper appears to be leaking threads
this is a quick fix to stop it, though we need to make sure we
never leak connection pools as well.
2018-06-14 12:49:30 +10:00
fd54c92a52 FEATURE: New site setting, whitelisted_link_domains
If provided, users who normally couldn't post links (say, due to a
low trust level), can post links to those specific hosts.
2018-06-13 16:11:22 -04:00
ae728702a6 Revert "Revert "Preload custom user fields when viewing flag queue""
This reverts commit 1bb12ee1b6f0c5428a046bb01a2c12f969cc6480.
2018-06-13 11:44:13 -04:00
139d0813b4 Re-enable fast_pluck freedom patch. 2018-06-13 09:25:23 +08:00
1bb12ee1b6 Revert "Preload custom user fields when viewing flag queue"
This reverts commit 5bd1c5cc95f8f78ab74342dabbaa2f6366f57a62.
2018-06-12 16:46:31 -04:00
5bd1c5cc95 Preload custom user fields when viewing flag queue 2018-06-12 16:17:22 -04:00
e0096b0d1c Safety in case translations are missing root keys 2018-06-12 10:09:57 -04:00
7c173265d5 FIX: Don't clear connections on the same process. 2018-06-12 13:06:25 +08:00
646ed87aba Clear all connections once master recovers. 2018-06-12 12:13:59 +08:00
fd75e54793 Disconnect the pool during failover and fallback. 2018-06-12 11:09:19 +08:00