3 Commits

Author	SHA1	Message	Date
Blake Erickson	35e17ce115	FIX: Email Send post has already been taken error (#16992) ... * FIX: Email Send post has already been taken error Adding a failing test first before coming up with a good solution. Related: 357011eb3b4e9c5fb860a34ecbb2f5cb89e89a7a The above commit changed ``` PostReplyKey.find_or_create_by_safe! ``` to ``` PostReplyKey.create_or_find_by! ``` But I don't think it is working as a 1-1 replacement because of the `Validation failed: Post has already been taken` error we are receiving with this change. Also we need to make sure we don't re-introduce any concurrency issues. Reported: https://meta.discourse.org/t/224706/13 * Remove rails unique constraint and rely on db index I believe this is what is causing `create_or_find_by!` to fail. Because we have a unique constraint in the db I think we can remove this rails unique constraint? * clean up spec wording	2022-06-06 13:13:26 -06:00
David Taylor	c9dab6fd08	DEV: Automatically require 'rails_helper' in all specs (#16077) ... It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors. By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.	2022-03-01 17:50:50 +00:00
Jarek Radosz	45cc16098d	DEV: Move spec/components to spec/lib (#15987) ... Lib specs were inexplicably split into two directories (`lib` and `components`) This moves them all into `lib`.	2022-02-18 19:41:54 +01:00