Commit Graph

19079 Commits

Author SHA1 Message Date
87b5003453 UX: Increase width of hamburger menu to 320px 2019-02-21 21:52:21 -05:00
f44ef82b53 UX: Better wrapping of group header elements 2019-02-21 21:42:39 -05:00
Sam
667d3a3fd6 PERF: include content-length header for CDN
Attempt to force NGINX to include content length when doing X-SendFile
This does not seem to be required when bypassing NGINX.

Without this header some CDNs may have issues caching
2019-02-22 11:21:07 +11:00
Sam
31d41f532e PERF: do not include suggested topics when loading new posts
When a new post is triggered via message bus post stream will attempt to load
it, previously the `/topic/TOPIC_ID/posts.json` would unconditionally include
suggested topics, this caused excessive load on the server.

New pattern defaults to exclude suggested and related topics from this API
unless people explicitly ask for suggested.
2019-02-22 10:37:18 +11:00
74ed72e825 DEV: Remove d-checkbox component
Replaces the last occurrence of `d-checkbox` with a regular input element.

Includes a minor refactor of admin site text search.
2019-02-21 09:54:54 -05:00
1dee71d760 UX: Disabled lightbox expand button when loading image meta. 2019-02-21 22:30:57 +08:00
f8e498f6ad DEV: Fix random build error 2019-02-21 14:53:29 +01:00
090acb5b11 FIX: s/isMessage/isPM (#7048)
Regression due to refactoring
2019-02-21 13:53:50 +01:00
8d779db270 FIX: allows invite modal from topic-map post-actions (#7047) 2019-02-21 13:48:03 +01:00
46e62c0d22 UX: Default user facing routes to /g instead of /groups. (#7042) 2019-02-21 13:44:25 +08:00
Sam
07b856700d REFACTOR: remove disallowEmails option from user-selector
Negative option was leading to a fair amount of confusion, going forward
if we want to allow selection of emails from user selector it must be
supplied with `allowEmails=true`

This corrects a regression in 1f4ace4f which broke invite by emails and
start PM to email
2019-02-21 16:37:26 +11:00
Sam
79841cf7dd FEATURE: add missing autocomplete suppressions
Following 1f4ace4f add a couple more autocomplete suppressions (in polls
and invite ui)
2019-02-21 16:37:26 +11:00
d3cd314a98 Make eslint happy. 2019-02-21 10:26:56 +08:00
58b0e945bd UX: Lightbox support for image uploader. (#7034) 2019-02-21 10:13:37 +08:00
e3a23116d2 FIX: don't update gravatar if the user has no email 2019-02-20 22:34:43 +01:00
cc1f9e7be6 Fix share button in post menu 2019-02-20 16:27:59 -05:00
353eeef72a fix prettier offense (#7041) 2019-02-20 22:22:38 +01:00
cafe637407 UX: List popular themes and components in admin panel (#6997)
Reorganizes theme create/upload flows into one install flow
Adds quick list of popular themes/components with one-click installation
2019-02-20 14:58:31 -05:00
4955ab1689 DEV: add replaceTagRenderer to pluginApi 2019-02-20 14:52:56 -05:00
18296b4211 FIX: more reliable native sharing (#7039) 2019-02-20 20:43:48 +01:00
9618300d69 s/share/nativeShare (#7038) 2019-02-20 20:03:30 +01:00
994a09e5e8 FIX: stricter window.navigator.share check (#7037) 2019-02-20 19:40:51 +01:00
2e0342dba7 UX: more spacing between social links (#7036) 2019-02-20 19:37:08 +01:00
28c24631b8 FIX: ensures panel's shareUrl is not erased by topic's shareUrl (#7035) 2019-02-20 19:33:54 +01:00
66901f67f6 UX: Moderator post wasn't completely translatable 2019-02-20 16:37:47 +01:00
04a63cfaaa [WIP] FEATURE: merge share and invite actions together (#7021)
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
2019-02-20 15:42:44 +01:00
6a8007e5fb FEATURE: Improve handling of backup storage errors 2019-02-20 15:16:49 +01:00
Sam
33269c4172 FEATURE: do no search for groups unless a term is specified
Do not allow `/u/search/users.json` to list any group matches unless a
specific `term` is specified in the API call.

Adding groups should always be done when an actual search term exists,
blank search is only supported for users within a topic
2019-02-20 17:28:22 +11:00
31ffa5f64e UX: Allow users to see filename in image-uploader component. (#7022)
https://meta.discourse.org/t/downsides-of-the-new-logo-ui-in-site-settings/102247/23?u=tgxworld
2019-02-20 13:55:55 +08:00
Sam
1f4ace4f56 FEATURE: autocomplete usernames early in topic based on participation
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic

This is somewhat experimental, we may tweak this, or make it optional.

Also, a regression in a423a938 where hitting TAB would eat a post you were writing:

Eg this would eat a post:

``` text
@hello, testing 123 <tab>
```
2019-02-20 13:34:43 +11:00
Sam
918a0ea3a4 FIX: use autocomplete="discourse" to disable Chrome address autofill
https://stackoverflow.com/a/47822599/17174

Chrome 63 and up start ignoring `autofill="off"`

Per: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164

> The tricky part here is that somewhere along the journey of the web autocomplete=off become a default for many form fields, without any real thought being given as to whether or not that was good for users. This doesn't mean there aren't very valid cases where you don't want the browser autofilling data (e.g. on CRM systems), but by and large, we see those as the minority cases. And as a result, we started ignoring autocomplete=off for Chrome Autofill data

So to work around this decision we now explicitly say: autocomplete="discourse"
when we don't want Chrome to randomly fill in addressed (aka. always)
2019-02-20 10:15:59 +11:00
246997dbd9 FIX: an <a> with a target of _blank wants a new window 2019-02-19 14:44:30 -08:00
49e7073438 FIX: Hide advanced theme fields behind a flag, pending UI improvement 2019-02-19 22:25:00 +00:00
d08939ab05 FIX: Should be possible to save an empty theme_field in the editor
Removing the theme_field JS object when the value was empty caused the server to maintain the previous value, making it impossible to delete the content of a field.
2019-02-19 21:49:31 +00:00
5d75bd4831 FIX: Don't try to rename group when username is taken
FIX: Always rename groups with the default locale instead of using the user's locale
2019-02-19 22:31:03 +01:00
dbcf05d62c DEV: Code style improvements following review
Followup to 05ee1d1aba3d1238867b59d91b72327688358439
2019-02-19 20:02:29 +00:00
7878e5007a FIX: Refactor to prevent themes affecting core stylesheets (#7029)
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
2019-02-19 15:55:59 +00:00
9ade04b709 FIX: removes legacy browsers-refresh button (#7028) 2019-02-19 16:38:21 +01:00
84c56e16f9 REFACTOR: Use keyword argument for fallback_to_english flag 2019-02-19 15:28:47 +01:00
05ee1d1aba FEATURE: Added settings/translations support to theme editor UI (#7026)
- These advanced fields are hidden behind an 'advanced' button, so will not affect normal use
- The editor has been refactored into a component, and styling cleaned up so menu items do not overlap on small screens
- Styling has been added to indicate which fields are in use for a theme
- Icons have been added to identify which fields have errors
2019-02-19 12:56:01 +00:00
0616837a5d UX: moves wizard's "Finish" button to the left of back and next (#7027)
This was done to avoid clicking finish when clicking fast on next.
2019-02-19 13:32:01 +01:00
8a4cd15e46 REFACTOR: topic model (#7020) 2019-02-19 10:13:46 +01:00
15fd875855 REFACTOR: color-scheme-color model (#7019) 2019-02-19 09:31:26 +01:00
cba0dd33ee REFACTOR: admin-customize-color (#7018) 2019-02-19 09:31:11 +01:00
2c6bf184bc REFACTOR: admin-badge-preview (#7017) 2019-02-19 09:30:52 +01:00
3bf61fca66 REFACTOR: admin-user-field-item (#7016) 2019-02-19 09:30:38 +01:00
ee692414ce REFACTORING: admin-edit-badge-groupings (#7015) 2019-02-19 09:30:24 +01:00
27e7f2bee0 DEV: call 'enqueue_hooks' method only if active webhooks exist 2019-02-19 12:43:08 +05:30
f2c3415548 FIX: Should not generate payload until active webhooks are exist 2019-02-19 12:23:42 +05:30
4f5aebc338 UX: reduce subcategory badge spacing 2019-02-18 19:04:36 -05:00