Commit Graph

37587 Commits

Author SHA1 Message Date
451e9c4bb9 DEV: minor SQL formatting change
Moved join prior to left join to make query less confusing.

Has no material impact on performance.
2020-05-12 16:55:42 +10:00
4ea7a7cf67 Build(deps): Bump rubocop from 0.82.0 to 0.83.0
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.82.0 to 0.83.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.82.0...v0.83.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-12 14:28:29 +08:00
8fb99f218d FEATURE: Allow plugins to register a callback to ignore DraftSequence. 2020-05-12 14:25:20 +08:00
d301af39bd PERF: Avoid hitting DB when fetching draft sequence of bot user. 2020-05-12 13:56:58 +08:00
39a2d90e0f DEV: Pass currentUser to post-menu button builders (#9752)
Adding this from a review; I was using Discourse.currentUser which is frowned upon now.

Passing currentUser both for regular post menu buttons and extra buttons attached via the plugin API.

Lots of formatting/whitespace changes, best off reviewing with ?w=1
2020-05-12 14:09:38 +10:00
3c423faafd DEV: Avoid repeating draft key logic in multiple places. 2020-05-12 11:14:03 +08:00
a009ec597d remove ember container div 2020-05-11 21:12:33 -04:00
6f228b0312 FIX: Remove unnecessary forward slashes in regex 2020-05-11 17:55:44 -07:00
dfe55d2344 DEV: remove prefix
.public was a cut-and-paste fail, removing
2020-05-12 10:09:02 +10:00
f4a53bd8f0 DEV: create missing indexes
These indexes should have been created in aa2a9da4
2020-05-12 09:57:31 +10:00
aa2a9da4b2 PERF: reduce exclusive locking when changing tables
posts and topics tables can be huge, this migration change
ensures the migration performs less work in one giant transaction
reducing risk of deadlocks

Migration is re-runnable thanks to NOT EXISTS checks
2020-05-12 09:51:59 +10:00
4c8bece104 FEATURE: default canonical URL (#9738)
For pages that do not specify canonical URL we will default to `https://SITENAME/PATH`. 

This ensures that if a URL is crawled on the CDN the search ranking will transfer to the main site.

Additionally we whitelist the `?page` param
2020-05-12 09:13:20 +10:00
7cdf41d311 DEV: Remove reference to Discourse.Category 2020-05-11 18:28:45 -04:00
e744b9efec FIX: add tabindex=-1 on tabLoc post links
This prevents tabbing from confusing screenreaders, as having default tabindex
with aria-hidden confuses screenreaders
2020-05-11 14:43:12 -07:00
90b900704b FIX: Improve mobile footer nav accessibility 2020-05-11 16:55:34 -04:00
b4d27d327d Revert "DEV: Remove Discourse.Route"
This reverts commit eed7983404fdf7f2f2b48144035739aa158099d7.
2020-05-11 16:50:53 -04:00
22af44ac49 DEV: Remove Discourse.Mobile 2020-05-11 16:13:29 -04:00
eed7983404 DEV: Remove Discourse.Route 2020-05-11 16:11:33 -04:00
74db317974 DEV: Remove deprecation for Discourse.Category 2020-05-11 16:10:21 -04:00
286b4e535e DEV: allows buttons to define aria-label (#9747) 2020-05-11 22:09:44 +02:00
b4bd238dd6 DEV: Add safe deprecation to Discourse.User 2020-05-11 16:08:12 -04:00
46730a2f0d DEV: Allow us to keep the deprecation with Ember CLI 2020-05-11 16:06:06 -04:00
4c17ff98fa DEV: Remove deprecation for Discourse.Session 2020-05-11 15:51:10 -04:00
8311374a5a DEV: Replace version.js.erb with pre generated file 2020-05-11 15:43:09 -04:00
d2b16a7618 DEV: Generate emoji/data on demand (#9744)
These emoji rarely change and can be re-generated when we make changes
to them.
2020-05-11 15:29:46 -04:00
ab919332dc DEV: api documentation updates (#9612)
* DEV: api documentation updates

- Created a script to convert json responses to rswag
- Documented several api endpoints
- Switched rswag to use header based auth

* Update script, fix some schema missmatches
2020-05-11 13:06:49 -06:00
af6e61defd FIX: sets a title for notifications button (#9745) 2020-05-11 20:46:08 +02:00
5a073c6a0a Revert "FIX: title should attempt to fallback to label before name (#9739)"
This reverts commit c6bf552ca3a61059d569d199d1e330547a78f761.
2020-05-11 20:09:11 +02:00
141f16eb6b FIX: Multiple schema.org improvements
* Do not show "Uncategorized" category in topics list.
* Use "BreadcrumbList" only if topic is in a category.
* Add tags list as keywords to the first post.
* Add "dateModified" even if it is the same with "datePublished".
* Show "crawler-linkback-list" only if there are links to be shown.
2020-05-11 20:38:49 +03:00
0deb05740f Revert "DEV: allows to define an ariaLabel on d-button (#9716)"
This reverts commit 7a95dd48415c2152f1c791b2dfcd04f6910c1ca7.
2020-05-11 19:19:13 +02:00
7a95dd4841 DEV: allows to define an ariaLabel on d-button (#9716)
* DEV: allows to define an ariaLabel on d-button

This topic also adds this function to topic-footer-buttons, simplifies the whole logic of titile/label/arialabel in d-button and adds tests for these properties.

* typo
2020-05-11 18:42:51 +02:00
c6bf552ca3 FIX: title should attempt to fallback to label before name (#9739) 2020-05-11 18:42:18 +02:00
4d137b4f89 FIX: Handle a deleted topic in thumbnail generation
Follow up to 03818e642a1ae871bffdc0c39c10f05f0b8b0398

A topic can be deleted between job enqueue and job execution
2020-05-11 13:32:37 -03:00
6e3fe1abba DEV: Use async/await instead of andThen() 2020-05-11 18:22:48 +02:00
fe2d5da623 DEV: Remove obsolete commented out tests
Commented out in 2016 in ff74bd7e28a13014dd09228445bf0a9938066518
2020-05-11 18:19:21 +02:00
f722fa3615 DEV: Remove .travis.yml config
We're no longer use Travis in core.
2020-05-11 17:32:39 +02:00
33b8314ac5 Build(deps): Bump public_suffix from 4.0.4 to 4.0.5 (#9733)
Bumps [public_suffix](https://github.com/weppos/publicsuffix-ruby) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/weppos/publicsuffix-ruby/releases)
- [Changelog](https://github.com/weppos/publicsuffix-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/weppos/publicsuffix-ruby/compare/v4.0.4...v4.0.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-11 11:20:35 -04:00
22ed36e483 Build(deps): Bump rspec-expectations from 3.9.1 to 3.9.2 (#9732)
Bumps [rspec-expectations](https://github.com/rspec/rspec-expectations) from 3.9.1 to 3.9.2.
- [Release notes](https://github.com/rspec/rspec-expectations/releases)
- [Changelog](https://github.com/rspec/rspec-expectations/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-expectations/compare/v3.9.1...v3.9.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-11 11:20:15 -04:00
c6f68e4006 Fix syntax error in fluxbb.rb (#9727) 2020-05-11 11:07:57 -04:00
7d3c4a5f13 FIX: Show category name in badge preview on edit (#9726) 2020-05-11 17:05:40 +02:00
a2bb33b6d7 REFACTOR: Remove an unused Topic model observer (#9723)
As far I can tell nothing sets categoryName on the Topic model. Didn't find anything in all-the-plugins/all-the-themes either.
2020-05-11 17:05:05 +02:00
b7d6eb3986 DEV: Various GitHub Actions CI tweaks (#9724)
* DEV: Update bundler in GitHub Actions CI

* DEV: Fix bundler deprecation warning

Fixes the following two deprecation warnings:

```
[DEPRECATED] The `--deployment` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set deployment 'true'`, and stop using this flag
```

```
[DEPRECATED] The `--without` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set without 'development'`, and stop using this flag
```

* DEV: The default `retry` value is already `3`

See https://bundler.io/v2.0/man/bundle-config.1.html:

> retry (BUNDLE_RETRY): The number of times to retry failed network requests. Defaults to 3.

* DEV: `&& \` isn't required in multiline `step.run`

Steps use the fail-fast strategy.

* DEV: Use multiline `step.run` where possible
2020-05-11 17:04:33 +02:00
5fc51ed49c DEV: Remove unused DiscoursePlugin class (#9715) 2020-05-11 15:46:54 +01:00
addf9d62f8 FIX: prevents rendering topic-category if empty (#9720) 2020-05-11 17:45:28 +03:00
a9cf680f76 A typo fix (#9717) 2020-05-11 10:43:21 -04:00
89c6f697b8 DEV: Plugin outlet after save or cancel composer buttons (#9725) 2020-05-11 09:23:36 -05:00
77f5bb1419 FIX: stop clearing title by mistake
b180e6e737900b caused a short lived regression.

This code is very deliberate about ensuring originalTitle is
set correctly
2020-05-11 19:07:32 +10:00
f293b28198 FEATURE: Pass instance of revisor to post_edited DiscourseEvent. 2020-05-11 16:45:40 +08:00
8233610d92 DEV: Add add_controller_callback server side plugin api. 2020-05-11 16:45:08 +08:00
a3a464b838 DEV: Improve description of addPosterIcon plugin api. 2020-05-11 16:44:47 +08:00