8417c9829e
A11Y: hamburger menu aria-{expanded,haspopup} and user title ( #11852 )
...
User title in the current-user header-dropdown was sometimes `title="null"` if user doesn’t have a name. This is fixed as part of this commit to improve accessibility of this part of the UI.
2021-01-26 16:33:15 +01:00
3bbe87f229
FIX: polls extending in post reply histories ( #11837 )
...
* Add an acceptance test
* FIX: polls extending in post reply histories
2021-01-26 10:29:49 -05:00
cd3d24ed8c
FIX: move post_search_data migration into onceoff job ( #11851 )
...
And reduce the size of the batches to 100k.
That should hopefully make the migrations run smoother...
2021-01-26 16:29:00 +01:00
4228c7e7d1
UX: Small tweak to category delete warning ( #11799 )
2021-01-26 09:43:47 -05:00
33507cdb14
DEV: Styleguide fixes ( #11836 )
...
Includes:
* FIX: Don't override computed properties
* FIX: Prevent a set-after-destroy error
* FIX: Get rid of select-kit deprecations
* FIX: Replace removed admin-group-selector
* FIX: Provide onChange action to fix warnings
* FIX: Remove an element with an invalid id
* DEV: Remove topic-notifications-button from dropdowns
It has its own styleguide section under "Molecules".
* UX: Styleguide tweaks
* DEV: Make the dropdowns useable
2021-01-26 15:40:58 +01:00
798b479e0d
DEV: More API Doc improvements ( #11849 )
...
- Create helper wrapper method `load_spec_schema(name)`
- A minor change to tag_group_create response schema
- Document the uploads endpoint
2021-01-26 07:38:46 -07:00
1989a326c9
A11Y: correctly sets role=dialog and aria-labelledby for d-modals ( #11850 )
2021-01-26 15:26:30 +01:00
3c028cb67f
Update translations ( #11848 )
2021-01-26 14:52:35 +01:00
4d70cc379b
DEV: Add test ( #11847 )
...
Follow-up to 77c48644eb8183d2c2a7cc7e4b95245b0d8d3d6c.
2021-01-26 14:44:00 +02:00
67db5e97f8
FEATURE: Add extra response headers to nginx log format ( #11840 )
...
These headers are useful for debugging and performance analysis
2021-01-26 11:32:43 +00:00
c56ba6c9bd
PERF: batch expensive post-migration ( #11845 )
...
Run the 'MigrateSearchDataAfterDefaultLocaleRename' post migration in batches of 500k records.
This will hopefully prevent any potential deadlocks on large tables.
2021-01-25 22:58:58 +01:00
568bad75c1
FIX: Support version in new feature payload ( #11841 )
...
Followup to 4f01ca87e30c4b7d63a71267e4a572eea786c152
2021-01-25 16:30:43 -05:00
363dca5ddc
FIX: "Customize text" link was broken on badges admin page ( #11842 )
2021-01-25 21:45:13 +01:00
f421d9bdd6
FIX: only de-prioritise exact matches in mentions ( #11843 )
...
Not when doing a site-wide search like we do in the Directory.
This solves the following specfailure:
1) DirectoryItemsController with data finds user by name
Failure/Error: expect(json['directory_items'].length).to eq(1)
expected: 1
got: 0
(compared using ==)
# ./spec/requests/directory_items_controller_spec.rb:88:in `block (3 levels) in <main>'
# ./spec/rails_helper.rb:271:in `block (2 levels) in <top (required)>'
# ./bundle/ruby/2.7.0/gems/webmock-3.11.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
2021-01-25 21:27:15 +01:00
27656f5c84
FIX: un-prioritise inactive users in user search ( #11838 )
...
When doing a user search (eg. when mentioning a user) we will not prioritie
users who hasn't been seen in over a year.
REFACTOR the user-search specs to be more precise regarding the ordering
2021-01-25 20:33:11 +01:00
d364d4827c
Build(deps): Bump mini_suffix from 0.3.0 to 0.3.2 ( #11839 )
...
Bumps [mini_suffix](https://github.com/discourse/mini_suffix ) from 0.3.0 to 0.3.2.
- [Release notes](https://github.com/discourse/mini_suffix/releases )
- [Changelog](https://github.com/discourse/mini_suffix/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/mini_suffix/commits/v0.3.2 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-25 13:25:40 -05:00
c7781f1139
UX: respect email_editable site setting in user activation page. ( #11835 )
...
Previously, when both `enable_local_logins` and `email_editable` are disabled still user can change the email in user activation page.
2021-01-25 22:19:26 +05:30
afe6db5f33
FIX: Destroy associated user api keys when making a user anonymous. ( #11760 )
2021-01-25 11:07:22 -03:00
2092152b03
FIX: Cleanup authentication_data cookie after login ( #11834 )
...
This cookie is only used during login. Having it persist after that can
cause some unusual behavior, especially for sites with short session
lengths.
We were already deleting the cookie following a new signup, but not for
existing users.
This commit moves the cookie deletion logic out of the erb template, and
adds logic and tests to ensure it is always deleted consistently.
Co-authored-by: Jarek Radosz <jradosz@gmail.com >
2021-01-25 13:47:44 +00:00
e65c5b0aad
PERF: Migrate search data after locale rename ( #11831 )
...
The default locale `en_US` has been renamed into `en`. This tries to migrate existing search data to avoid resource intensive reindexing.
2021-01-25 14:30:17 +01:00
77c48644eb
FIX: Dismissing unread topics with a tag ( #11832 )
...
This commits add missing router service to the mixin. It did not work
because 'router' was undefined.
2021-01-25 15:16:21 +02:00
21d6603245
DEV: followup to 8edd2b38cb to use existing spec ( #11830 )
...
This commit also better explains in spec why max_values might be off by one.
2021-01-25 12:04:27 +01:00
bed011feef
A11Y: uses role=button and supports ariaPressed for tapTile ( #11827 )
2021-01-25 11:31:52 +01:00
8edd2b38cb
FIX: ensures timeline_lookup includes last tuple ( #11829 )
...
A simplified version of the logic used in the function before my fix is as follow:
```ruby
result = []
things = [0,1,2,3]
max_values = 2
every = (things.size.to_f / max_values).ceil
things.each_with_index do |t, index|
next unless (t % every) === 0
result << t
end
p result # [0, 2]
# 3 doesn’t get included
```
The problem is that if you get unlucky two times you won't get last tuple(s) and might get a very erroneous date.
Double unlucky:
- last tuple index % computed every !== 0 and you don't get the last tuple
- the last tuple is related to a post with a very different date than the previous tuples (on year difference in our case)
2021-01-25 11:30:59 +01:00
aa1138ff71
FIX: reindex_search job should work on model with no search data ( #11819 )
...
Lots of changes but it's mostly a refactoring.
The interesting part that was fix are the 'load_problem_<model>_ids' methods.
They will now return records with no search data associated so they can be properly indexed for the search.
This "bad" state usually happens after a migration.
2021-01-25 11:23:36 +01:00
fcbb6c4143
FIX: remove rendering UX from bookmark model ( #11765 )
...
Fix for `bookmark.js` model. Most logic was moved to `topic` controller
2021-01-25 09:35:13 +11:00
0a51999a46
Build(deps): Bump rubocop-ast from 1.4.0 to 1.4.1 ( #11823 )
...
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast ) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.4.0...v1.4.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-24 22:47:38 +01:00
0a1b1f1aa3
Build(deps): Bump oj from 3.11.0 to 3.11.1 ( #11824 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.11.0 to 3.11.1.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.11.0...v3.11.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-24 22:46:23 +01:00
831e29873d
Build(deps): Bump ast from 2.4.1 to 2.4.2 ( #11825 )
...
Bumps [ast](https://github.com/whitequark/ast ) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/whitequark/ast/releases )
- [Changelog](https://github.com/whitequark/ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/ast/compare/v2.4.1...v2.4.2 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-24 22:45:44 +01:00
2ab5637792
Build(deps-dev): Bump shoulda-matchers from 4.5.0 to 4.5.1 ( #11826 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.5.0...v4.5.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-24 22:44:45 +01:00
37f7f30640
edit button fix, follow up to 6f13d2b ( #11821 )
2021-01-22 20:31:01 -05:00
17e683d373
UX: Simplify narrative bot bio ( #11820 )
2021-01-22 17:21:26 -08:00
6d30e01d1c
A11Y: Structure user menu as tabs. ( #11789 )
...
* A11Y: Structure user menu as tabs.
Although the user menu content has the appearance of tabs and relies on the functionality of tabs to make sense in terms of content and focus order, it is not marked up correctly as tabs and tab panels. See [WAI-ARIA Authoring Practices 1.1](https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel ) and the [example](https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-2/tabs.html ) for details.
* Make plugin api backwards compatible
2021-01-22 19:05:14 -03:00
73cb083b7b
FIX: Cannot find currentThemeColorSchemeId when no themeId is present ( #11817 )
2021-01-22 16:27:19 -05:00
cd11689446
FIX: Check the confirmation result before deleting SSO record ( #11816 )
2021-01-22 19:16:43 +00:00
56294b4fba
FIX: Remove scheduled DND timings when schedule is disabed ( #11814 )
2021-01-22 13:02:11 -06:00
6f13d2b039
A11Y: makes post-edits-indicator a button instead of a link ( #11811 )
2021-01-22 17:09:39 +01:00
dc268822a4
FIX: It seems sometimes shims are evaluated by older JS engines ( #11813 )
...
This gives us backwards compatibility with those.
2021-01-22 10:41:01 -05:00
4f01ca87e3
FEATURE: Add new features section in admin dashboard ( #11731 )
2021-01-22 10:09:02 -05:00
71656d2c37
UX: Makes the theme editor display placeholder correctly for RTL languages ( #11800 )
...
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-he#53834
2021-01-22 16:03:43 +01:00
436c8e9bcd
DEV: eslint rules should be defined in eslint-config-discourse ( #11812 )
2021-01-22 15:48:23 +01:00
f2fcc3d21a
Build(deps): Bump sidekiq from 6.1.2 to 6.1.3 ( #11794 )
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.1.2 to 6.1.3.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.1.2...v6.1.3 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-22 09:42:34 -05:00
5a5f6905d7
Build(deps): Bump logster from 2.9.4 to 2.9.5 ( #11796 )
...
Bumps [logster](https://github.com/discourse/logster ) from 2.9.4 to 2.9.5.
- [Release notes](https://github.com/discourse/logster/releases )
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.9.4...v2.9.5 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-22 09:41:23 -05:00
15b5bd4e14
UX: show onebox error preview image as favicon ( #11810 )
2021-01-22 20:05:28 +05:30
039b4111e3
FIX: print raw html of logo image to skip unwanted html encoding ( #11805 )
...
Currently, the image logo is broken since the image tag is rendering incorrectly.
2021-01-22 19:48:01 +05:30
314e7be2b1
A11Y: improves search-in-options filter accessibility ( #11809 )
2021-01-22 14:39:16 +01:00
7521cb51c4
A11y: makes advanced search and html heading ( #11808 )
2021-01-22 14:35:17 +01:00
e81d93cf26
UX: specify width and height for onebox preview error image ( #11807 )
2021-01-22 19:02:23 +05:30
d2cf43a7d5
FIX: Update categories without full page refresh ( #11793 )
...
Creating or moving a category required a full page refresh until it
showed up correctly.
2021-01-22 10:21:09 +02:00
9e6ff9cc67
A11Y: associate search controls with their labels ( #11806 )
2021-01-21 22:24:15 -05:00
