88ef5e55fe
FEATURE: add ability to have multiple totp factors ( #7626 )
...
Adds a second factor landing page that centralizes a user's second factor configuration.
This contains both TOTP and Backup, and also allows multiple TOTP tokens to be registered and organized by a name. Access to this page is authenticated via password, and cached for 30 minutes via a secure session.
2019-06-26 16:58:06 -07:00
134a4c66b7
PERF: limit time spent diffing large blobs of text
...
REFACTOR: s/.length/.size/g
2019-06-27 01:45:52 +02:00
3c64dc3e7d
FIX: do not allow creation of topic if there is no category available for posting ( #7786 )
2019-06-26 16:32:53 +05:30
557805249d
FIX: Ensure topic exists before making a banner. ( #7781 )
2019-06-25 13:49:29 +03:00
afb5ec811d
FIX: Don't use DistributedCache to store redis readonly state
...
This can cause unbound CPU usage in some cases, and excessive logging in other cases. This commit moves redis readonly information into the local process, but maintains the DistributedCache for postgres readonly state.
2019-06-25 11:20:34 +08:00
f51f37eddf
FEATURE: apply a small penalty to closed topics when searching ( #7782 )
2019-06-21 12:03:45 +10:00
0d84c5b894
FIX: If a user deletes a hidden post, it should not lose history
2019-06-20 12:38:16 -04:00
e8b9f38374
FIX: Don't allow users to edit topic information when the OP is locked
...
see:
https://meta.discourse.org/t/user-able-to-edit-title-of-locked-post/104826
2019-06-18 14:22:38 -04:00
35d6fff69e
PERF: use url instead of file key in temporary inventory table.
2019-06-13 22:03:58 +05:30
42ab016856
FIX: Use markdown for images and attachments in Email::Receiver.
2019-06-11 14:49:46 +08:00
06d974d55c
FEATURE: Add base62 sha1 to cooked data attribute
...
* FEATURE: Add base62 sha1 to data attribute in `Post#cooked`.
* FIX: Use `Upload#short_url` when quoting an image.
2019-06-11 11:15:45 +10:00
799bd62803
DEV: Improve PrettyText spec to test for markdown image title attr.
2019-06-10 11:00:23 +08:00
45aebd00a5
SPEC: improve the spec using stubbed S3 client.
...
4d1204b5e8f934e2cb333d0be15b555c2a457a89
2019-06-08 18:10:35 +05:30
a08b2589d4
FIX: removing hidden tag bumps topic when all tags are removed
...
JS sends empty string to remove all tags.
2019-06-07 14:25:46 -04:00
e3a9a2d2dd
FIX: Avoid infinite loop if disk space is low
...
We now continue to enqueue the pull_hotlinked_images job for optimized images, even if disk space is low
2019-06-07 14:24:22 +01:00
65b0cafc03
FIX: Always schedule pull_hotlinked_images in cooked_post_processor
...
The job is now used to pull optimized images, and images from other sites on the same CDN. This needs to run even if download_remote_images is false
2019-06-07 13:08:23 +01:00
8bd815dab2
FIX: Permit new tags when allow_global_tags true. ( #7722 )
2019-06-07 15:45:16 +10:00
b1c5ea4289
FIX: use URI.regexp to find URLs in plain text
2019-06-07 01:26:06 +02:00
b7830680b6
DEV: use cdn url to download the external uploads to local.
2019-06-06 19:17:19 +05:30
f00275ded3
FEATURE: Support private attachments when using S3 storage ( #7677 )
...
* Support private uploads in S3
* Use localStore for local avatars
* Add job to update private upload ACL on S3
* Test multisite paths
* update ACL for private uploads in migrate_to_s3 task
2019-06-06 13:27:24 +10:00
a77d8bee68
FIX: Use correct locale when translating without cache
...
follow-up to 6d8eb9c1
2019-06-05 14:19:56 +02:00
4d1204b5e8
SPEC: Add bucket folder path only if not exists
...
be0555cc17ce59918a1374c78af64d722f2c1836
2019-06-05 17:21:51 +05:30
62141b6316
FEATURE: enable_performance_http_headers for performance diagnostics
...
This adds support for DISCOURSE_ENABLE_PERFORMANCE_HTTP_HEADERS
when set to `true` this will turn on performance related headers
```text
X-Redis-Calls: 10 # number of redis calls
X-Redis-Time: 1.02 # redis time in seconds
X-Sql-Commands: 102 # number of SQL commands
X-Sql-Time: 1.02 # duration in SQL in seconds
X-Queue-Time: 1.01 # time the request sat in queue (depends on NGINX)
```
To get queue time NGINX must provide: HTTP_X_REQUEST_START
We do not recommend you enable this without thinking, it exposes information
about what your page is doing, usually you would only enable this if you
intend to strip off the headers further down the stream in a proxy
2019-06-05 16:08:11 +10:00
6d8eb9c144
PERF: bypass slow locale lookups in various cases
...
Previously as soon as any override was defined we would regress to the slow
path for locale lookups. Additionally if `raise: true` was specified which
rails likes to add in views we would bypass the cache
The new design manages to use the fast path for many more cases
2019-06-05 14:30:25 +10:00
1cf0b549ab
FIX: don't send post edit notification when hidden tags are changed
...
Create a hidden revision so staff can see the changed, but don't send
notifications to non-staff.
2019-06-04 15:48:15 -04:00
dd1a034e7b
Revert "FIX: don't send post edit notification when hidden tags are changed"
2019-06-04 15:48:15 -04:00
98a3e61a2d
FIX: Remapping URLs didn't affect upload site settings
2019-06-04 18:37:10 +02:00
9756e35956
REVERT: FIX: handle clicks counters in quotes
...
Not quite a full revert of 7696b92c8cd4de631133b27fa52c1f18fc66774b that isn't
actually required.
2019-06-04 11:59:44 +02:00
0508546fd2
FIX: Accept github theme urls with a trailing slash
2019-06-04 10:28:36 +01:00
6ad58913c8
DEV: Prefer save! over save.
2019-06-04 16:59:29 +08:00
87d3b86484
FIX: better error message when user without permissions replies via email
2019-06-04 16:39:41 +08:00
6300d978e2
FIX: correctly escape regex url
...
duplicate link detection could fail in certain cases
2019-06-04 16:21:03 +10:00
5e61893cb2
FIX: Display generic descriptor for associated account with no info
2019-06-03 12:14:02 +01:00
c1e7a1b292
UX: Merge settings related to muted tags. ( #7656 )
2019-06-03 12:23:23 +10:00
42809f4d69
FIX: use crawler layout when saving url in Wayback Machine ( #7667 )
2019-06-03 12:13:32 +10:00
0eb8d74284
DEV: Reduce object fabrication in CookedPostProcessor spec.
2019-05-30 08:50:10 +08:00
2fa8df7cd2
New: can_see_groups? method for better perf
2019-05-30 08:45:20 +08:00
8728850452
FEATURE: Mute topics tagged with both muted and unmuted tags.
2019-05-30 07:58:17 +08:00
8858dbb5b8
DEV: Refactor SystemMessage#create specs.
2019-05-30 07:56:36 +08:00
23fdaf07f2
FIX: create system message in user selected locale
...
DEV: refactor `create_from_system_user` to use `create` method
2019-05-29 21:43:43 +05:30
8d1b0224ac
Fix the build a3938f98f8b575675fc9b541725aa224fcddf682.
2019-05-29 18:53:31 +08:00
f0620e7118
FEATURE: Support [description|attachment](upload://<short-sha>) in MD take 2.
...
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
6cceb72173
DEV: Reduce verbosity in TopicQuery spec.
2019-05-29 08:32:10 +08:00
7c9fb95c15
Temporarily revert "FEATURE: Support [description|attachment](upload://<short-sha>) in MD. ( #7603 )"
...
This reverts commit b1d3c678ca39cf7f09ac3eb257c7153d4863a2a9.
We need to make sure post_upload records are correctly stored.
2019-05-28 16:37:01 -04:00
b1d3c678ca
FEATURE: Support [description|attachment](upload://<short-sha>) in MD. ( #7603 )
2019-05-28 11:18:21 -04:00
42818b810e
Better handling of custom SVG sprites in themes when using S3
2019-05-28 10:58:19 -04:00
3d2c3bd478
FIX: username suggester incorrectly skipping over whitelisted username
...
SSO uses a special param to username suggester that whitelists a username
due to previous work we amended our lookup logic and started ignoring this
whitelist.
The fix ensures we always respect it, and also improves on the original
implementation that forgot to normalize the username.
2019-05-28 16:48:46 +10:00
a02a7d66a9
DEV: properly clean up temp files in FileHelper spec
...
Followup to 74297003 , also noticed other specs were not properly cleaning
up so fixed that as well.
2019-05-28 11:33:08 +10:00
7429700389
FIX: ensure we can download maxmind without redis or db config
...
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
2019-05-28 10:28:57 +10:00
373b8a2139
FIX: Consistently handle category param
...
See https://meta.discourse.org/t/api-post-to-posts-json-inconsistent-between-users/118571
for more info.
This commit removes a 5 year old temporary fix that is no longer needed.
bc1824a6ed (diff-d8c648926664f849aec050757bfcb6f9R72)
2019-05-27 16:39:56 +08:00
