Commit Graph

37388 Commits

Author SHA1 Message Date
4f5ed8e781 DEV: pry-nav was holding back on pry upgrades
pry-nav is not yet supported on latest pry, this holds off on
upgrading pry, which in turn holds off on upgrading deps

Stripping pry-nav for now till it works with latest pry
2020-04-30 09:40:50 +10:00
8e4fea897e FIX: temporarily disable event listener for dismissing the first notification 2020-04-29 14:34:49 -07:00
590830b931 HACK: Add dummy plugin folder
On some installations, there may be a leftover symlink which uses the
old plugin name:

  public/plugins/discourse-internet-explorer ->
  -> plugins/discourse-internet-explorer/public
2020-04-29 23:18:57 +03:00
f697133b7d DEV: Add Handlebars support to Ember CLI in discourse-common 2020-04-29 16:15:13 -04:00
e1dbc700b1 FIX: ensures widget dropdown doesn't overflow document (#9590) 2020-04-29 21:12:32 +02:00
c85018cdfd Improve support for old browsers (#9515)
* FEATURE: Improve crawler view

* FIX: Make lazyYT crawler-friendly

* DEV: Rename discourse-internet-explorer to discourse-unsupported-browser

* DEV: Detect more unsupported browsers

Follow-up to 4eebbd221239eaa3fc7e6f1bd6a9dcf0239b8444.

* FIX: Hide browser update notice in print view
2020-04-29 21:40:21 +03:00
402194f313 FIX: Enter selected link with 'o' on full page search
Follow-up to 70012f20278430362649a26a28d3cb4b39449b64.
2020-04-29 21:25:59 +03:00
816a08cf5f UI: do not change widget dropdown separator background on hover (#9589) 2020-04-29 19:42:50 +02:00
a1b9150512 DEV: adds a caret option to widget dropdown (#9588) 2020-04-29 19:37:21 +02:00
08fbf199ad FIX: S3 rake task can ignore yarn.lock 2020-04-29 13:14:04 -04:00
bc1f7bd659 UX: Improve discobot random menion copy
As suggested in https://meta.discourse.org/t/-/148336/10
2020-04-29 13:09:16 -04:00
9ec908950d DEV: Better error handling for s3 task 2020-04-29 12:54:39 -04:00
cbb27241c4 DEV: Make discourse-common an Ember addon. (#9578)
This is to help with the migration to Ember CLI. In the current running
version of Discourse everything should be the same as before, just with
a few extra files that are not used. However, using Ember CLI this can
be installed as an Ember addon.

Co-Authored-By: Jarek Radosz <jradosz@gmail.com>
2020-04-29 12:18:21 -04:00
3ec21b4124 SECURITY: Update onebox to add rel="noopener" 2020-04-29 10:57:05 -04:00
9dccf4f3b8 FIX: Copyedit for "You were logged out" modal (#9584)
See https://meta.discourse.org/t/-/149596
2020-04-29 07:37:06 -07:00
db337b10ee FIX: correctly hides timeline scroller for short posts (#9581)
* FIX: correctly hides timeline scroller for short posts

* fix linting
2020-04-29 16:24:53 +02:00
7ccfc73edb Build(deps): Bump rqrcode_core from 0.1.1 to 0.1.2 (#9244)
Bumps [rqrcode_core](https://github.com/whomwah/rqrcode_core) from 0.1.1 to 0.1.2.
- [Release notes](https://github.com/whomwah/rqrcode_core/releases)
- [Commits](https://github.com/whomwah/rqrcode_core/commits)
2020-04-29 12:58:52 +01:00
6a9a7b56df DEV: Bump Hashie and Faraday (#9583)
These were previously pinned due to a dependency in the zendesk plugin. That has now been resolved.
2020-04-29 12:55:30 +01:00
4eed86919e FIX: ensures card cloak is removed (#9582)
Repro steps for current failure:
- use mobile view
- click on a different user avatar to show user card
- click message
- close composer
- cloak is still showing and prevents any click
2020-04-29 13:30:34 +02:00
7a946b9f5c DEV: Fix typo
Follow-up to 0a85a7aef9f5194b7e00b75bfe8b84c2376f0c65.
2020-04-29 12:38:57 +03:00
0a85a7aef9 FEATURE: Add user_profile to user_archive CSV export (#9571) 2020-04-29 12:09:50 +03:00
ae54a33719 FIX: discourse-presence breaks composer for users. 2020-04-29 15:29:29 +08:00
4fe4b3cce3 DEV: Revert quiet assets in dev.
Breaks with a gem.
2020-04-29 14:46:56 +08:00
16ab6430fe DEV: Follow up to a078feee07d1e55a4a6fc7e1058b8671922eaa8c 2020-04-29 14:24:48 +08:00
a078feee07 DEV: Turn off ActiveRecord development color and query log by default.
It breaks logster.
2020-04-29 14:19:14 +08:00
fa21c03a1d DEV: Minor follow up to 1d04fb24f8cbe078990332117fcffda4bd6ea3e5 2020-04-29 14:09:19 +08:00
1d04fb24f8 DEV: Enable all the ActiveRecord goodness in development env. 2020-04-29 14:08:00 +08:00
960fd94758 DEV: Run rubocop in parallel in pre-commit hook. 2020-04-29 13:48:59 +08:00
197d0332e6 DEV: Missing import. 2020-04-29 13:48:31 +08:00
8b3b5d1474 DEV: Disable discourse-presence in Ember test env. 2020-04-29 13:39:19 +08:00
2045f51312 FIX: correctly account for direct replies with presence
followup to 301a0fa5, we were not checking the action so we
were publishing some messages from composers we did not intend to
2020-04-29 15:23:17 +10:00
301a0fa54e FEATURE: Redesign discourse-presence to track state on the client side. (#9487)
Before this commit, the presence state of users were stored on the
server side and any updates to the state meant we had to publish the
entire state to the clients. Also, the way the state of users were
stored on the server side meant we didn't have a way to differentiate
between replying users and whispering users.

In this redesign, we decided to move the tracking of users state to the client
side and have the server publish client events instead. As a result of
this change, we're able to remove the number of opened connections
needed to track presence and also reduce the payload that is sent for
each event.

At the same time, we've also improved on the restrictions when publishing message_bus messages. Users that
do not have permission to see certain events will not receive messages
for those events.
2020-04-29 14:48:55 +10:00
5503eba924 DEV: Add env in dev to support verbose query log. 2020-04-29 11:10:57 +08:00
24b9759c60 UX: fix dashboard version panel width by removing extra wrapper 2020-04-28 21:14:29 -04:00
6cf31f16f7 FIX: Change bookmarks-with-reminders URL back to bookmarks for user activity (#9566)
* Bookmarks with reminders is a core feature now, no need to have a separate URL
* Keep around the old /u/:username/activity/bookmarks-with-reminders route for backwards compat in Ember but just redirect to user activity bookmarks.
2020-04-29 10:53:37 +10:00
17ca47af1a FIX: Remove timezone in brackets from user card (#9567)
For clarity and to save space remove the timezone in brackets e.g. (EDT) from the user card. Also add a title to the user time span to say it is Local Time.
2020-04-29 08:45:38 +10:00
0d519c78fb FIX: Do not save bookmark if close (X) on modal is clicked (#9541)
* After this change the bookmark will still be saved if clicking out of the modal or pressing escape
* To achieve this I implemented an initiatedBy parameter for modal closing from d-modal. If clicking on the cross it is initiated by close, if clicking out of the modal it is by click out.
* These options can then be compared in controllers consuming onClose

Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2020-04-29 08:45:06 +10:00
4ecc258835 DEV: adds support for header-title in topicTitleDecorators (#9562) 2020-04-28 21:27:07 +02:00
9d781d4959 FIX: error customizing text for badges from plugins 2020-04-28 14:34:41 -04:00
22f11efad0 DEV: Replace setTimeout with Ember.run.later
Followup to 6fad0463
2020-04-28 14:28:16 -04:00
07e6452759 FIX: makes tracking shortcuts working when tracking button is not visible (#9575) 2020-04-28 20:12:16 +02:00
a8308e73e7 FIX: improves tag-list setting (#9574)
- Prevents setting to display an empty tag
- Updates dropdown when selecting/removing tag
2020-04-28 20:05:30 +02:00
1e603d7003 DEV: This file does not seem to be used anymore 2020-04-28 14:03:39 -04:00
a6f986b50f FEATURE: allows to to style published page with themes/plugins (#9570) 2020-04-28 18:24:24 +02:00
b19dcac272 FIX: Include default notification level in category serializer (#9572)
Fixes an issue where the notification level state goes missing when user edits a category in the UI.
2020-04-28 12:05:53 -04:00
c1c211365a FIX: Improve clearing store cache (#9568)
1. Shorter
2. Simpler
3. Doesn't depend on external binaries
4. Doesn't fail on large amounts of files
5. Hopefully eliminates flaky spec errors
2020-04-28 17:24:04 +02:00
ec2943c5bc DEV: Update jquery.fileupload and dependencies (#9466) 2020-04-28 10:39:29 -04:00
4b57eb7049 FIX: published pages couldn't be routed from inside discourse (#9569)
This will allow to post a link to published page in a post. Before this, users clicking this link would have seen a 404.

ATM /pub is server sider only.
2020-04-28 16:37:56 +02:00
c1cc2f2a05 DEV: Remove ember-addons (#9559)
We weren't using this very much and introduces a dependency between
discourse-common and discourse which makes moving to yarn workspaces
more difficult.

In the future we might user ember-addons properly but for now it's
easier to move the code into discourse-common.

Note the old folder is still there because at least one plugin was still
requiring the old files. It will be removed in the future.
2020-04-28 10:14:49 -04:00
84be92c067 FIX: Avoid exception when rendering a poll in a trashed post
Maintain the poll belongs_to post relation when a post is trashed
2020-04-28 14:43:09 +01:00