Commit Graph

34412 Commits

Author SHA1 Message Date
1a7d2667c4 DEV: Add the AsyncContent component (#31101)
Co-authored-by: David Taylor <david@taylorhq.com>
2025-02-17 18:38:51 -03:00
43ececd22d FIX: Adds further support for 'prioritize_full_name_in_ux' setting (#31346)
This sets the stage for being able to consolidate Like notifications
using full names. It also is crucial to this [Reactions plugin
PR](https://github.com/discourse/discourse/pull/31292).

The Like consolidation PR will come after these.
2025-02-17 12:09:18 -06:00
4ec3cb754d DEV: Add mobile_view toggle to dev-tools toolbar (#31369)
Meta: https://meta.discourse.org/t/introducing-discourse-developer-toolbar/346215/15
2025-02-17 16:59:04 +00:00
402ec6bf5c PERF: Defer consolePrefix() calculation for transformers (#31367)
`consolePrefix()` is an expensive operation (it throws a synthetic
error, then parses the backtrace), so we should only do it when
absolutely necessary

On the topic-list page, this provides a 3-4% improvement in "init to
render" times.
2025-02-17 14:58:17 +00:00
566c772980 DEV: replace UsernameValidation mixin with helper in InvitesShowController and CreateAccount (#31330)
Follows up: https://github.com/discourse/discourse/pull/31107

This PR replaces the use of the UsernameValidation mixin with the helper
class for the InvitesShowController and CreateAccount modal component,
and deletes the mixin.
2025-02-17 07:52:30 +08:00
5252fe81f2 Build(deps): Bump the babel group with 2 updates (#31358)
Bumps the babel group with 2 updates:
[@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core)
and
[@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone).


Updates `@babel/core` from 7.26.8 to 7.26.9
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/babel/babel/commits/v7.26.9/packages/babel-core)

Updates `@babel/standalone` from 7.26.8 to 7.26.9
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/babel/babel/commits/v7.26.9/packages/babel-standalone)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Discourse CI <ci@ci.invalid>
2025-02-16 22:49:33 +01:00
05685d430f FIX: Make permalink search work even when there're 100+ permalinks (#31354)
Permalink search regressed in
https://github.com/discourse/discourse/pull/30633 where the search
implementation was changed from server side to client side. Prior to
that change, we included a `filter` param in the request to make the
server find permalinks that matched the given filter and return the
results limited to 100 records. However, with that change, we stopped
sending the `filter` param with the request, which made the server
always return the same 100 records which would then be filtered on the
client side. That means if a site has more than 100 records, any records
that don't make it in the first 100 will never be found using search.

Meta topic:
https://meta.discourse.org/t/permalinks-no-longer-has-a-way-to-search-or-show-all-permalinks/351922?u=osama
2025-02-16 00:19:16 +03:00
878514af6e DEV: Add ability to set disabled option on report filters (#31351)
This update adds the ability to conditionally control the `disabled`
property of the input on report filters.
2025-02-14 12:13:33 -08:00
f76d88063d FIX: Missing link to deleted post in /my/deleted-posts (#31342)
## 🔍 Overview
A regression in https://github.com/discourse/discourse/pull/30604,
resulted in the title/link for deleted posts not being shown. This fix
ensures that the title is once again shown.

## 📸 Screenshots

### ← Before
![Screenshot 2025-02-13 at 14 14
08](https://github.com/user-attachments/assets/17da8119-e476-4458-bc19-3f55efac91b2)

### → After
![Screenshot 2025-02-13 at 14 13
42](https://github.com/user-attachments/assets/ba2389ba-6cad-4641-a2cb-d2a13c10c233)
2025-02-14 09:50:42 -08:00
e5eeb642b9 DEV: include expandPinned in topic-list-main-link-bottom outlet (#31334)
Requested on Meta, seems reasonable:
https://meta.discourse.org/t/modify-topicexcerpt-template/352136
2025-02-14 09:37:07 -05:00
b2b9657a0b FIX: Image uploads in site-settings and profile (#31350)
Followup to 310cd513d88e3670c7008682ae4b35414084a17d. The `uploadDone`
callback returns the whole upload object, so we need to extract the URL
from it in these cases.
2025-02-14 11:02:10 +00:00
7779cf1e90 FIX: prevents double set in the same computation (#31348)
The current code was doing:
- initial value for `showPreview`
- setting another default value in `_setupPreview`

The fix is to move all the computation in one initial step when
initializing the property.
2025-02-14 11:52:55 +01:00
04531f1443 FIX: relative date format consistency (#31349)
This changes makes relative date formats consistent for both tiny and
medium formats.

Previously we were removing 12 hours from the date for medium format
when it was more than 2520 minutes (42 hours) but not for tiny date
formats.
2025-02-14 14:17:48 +04:00
54b1e3195c DEV: Refactor composer preview rendering (#31308)
- Switch to use new `<DecoratedHtml` component (including
`renderGlimmer` support)

- Updates click handling to use `{{on` modifier instead of manual event
listener setup/teardown
2025-02-14 09:50:02 +00:00
35084d3089 DEV: Refactor PostList cooked HTML rendering (#31307)
- Remove JQuery

- Move decoration into `components/post-item`, instead of managing it
from the top-level user-stream component

- Use new `DecoratedHtml` component
2025-02-14 09:46:32 +00:00
b471e3d5ba FEATURE: Allow showing only experiments on "What's new?" (#31347)
This commit allows admins to filter the list of feature
feed items on the "What's new?" page to _only_ show experiments.

This is useful to both find existing experiments they may have
enabled, and to get a better overview of new ones they would
like to try.

This will eventually not be required when we build a dedicated
config page for experiments.
2025-02-14 13:30:37 +10:00
2763e1726e FEATURE: display process information on flag modal (#31300)
Information about the process is displayed on top of the flag modal.

In addition `allow_tl0_and_anonymous_users_to_flag_illegal_content` site
setting was renamed to `allow_all_users_to_flag_illegal_content` as it
is more descriptive.

<img width="629" alt="Screenshot 2025-02-12 at 3 58 12 pm"
src="https://github.com/user-attachments/assets/67c74ebc-6771-490d-b2c4-cbec25db8128"
/>
<img width="642" alt="Screenshot 2025-02-12 at 3 58 04 pm"
src="https://github.com/user-attachments/assets/5e4b8c84-601a-40c2-812f-b73d2b88a549"
/>
2025-02-14 11:26:20 +11:00
fa8945fee2 UX: remove old menu border hack (#31344)
We used to hide the bottom border of the header buttons when menu panels
were open (so they'd appear connected), but this is no longer
necessary... so all this vestigial CSS does is sometimes create a stray
line like this:


![image](https://github.com/user-attachments/assets/12357bf3-2bc7-4604-8b76-7e54460a4175)
2025-02-13 18:04:47 -05:00
be513ed9a3 DEV: Fix all mixed-decls sass deprecations (#31343)
```
WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls
```
2025-02-13 23:58:19 +01:00
8c9514b4ba Build(deps-dev): Bump webpack from 5.97.1 to 5.98.0 (#31336)
Bumps [webpack](https://github.com/webpack/webpack) from 5.97.1 to
5.98.0.
- [Release notes](https://github.com/webpack/webpack/releases)
-
[Commits](https://github.com/webpack/webpack/compare/v5.97.1...v5.98.0)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Discourse CI <ci@ci.invalid>
2025-02-13 23:53:58 +01:00
d064d5bd4a Build(deps): Bump terser from 5.38.2 to 5.39.0 (#31338)
Bumps [terser](https://github.com/terser/terser) from 5.38.2 to 5.39.0.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/compare/v5.38.2...v5.39.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-13 23:28:35 +01:00
f3d98f9e89 Build(deps-dev): Bump @swc/core from 1.10.15 to 1.10.16 (#31337)
Bumps [@swc/core](https://github.com/swc-project/swc) from 1.10.15 to
1.10.16.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/swc-project/swc/compare/v1.10.15...v1.10.16)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-13 22:51:31 +01:00
d8b45be25a UX: prevent long category names from overflowing on mobile topic list (#31335)
Before:

<img
src="https://github.com/user-attachments/assets/a66dcbcd-3363-404b-bd12-422b536bad2c"
width="300" />

After: 

<img
src="https://github.com/user-attachments/assets/511a6545-c1f4-47bb-90f7-02e723ac08f7"
width="300" />
2025-02-13 16:26:22 -05:00
321a220b49 FIX: Post revision respects 'prioritize_full_name_in_ux' setting (#31293)
WIP

Before:
![Screenshot 2025-02-11 at 6 21
19 PM](https://github.com/user-attachments/assets/408b99a0-860a-47a0-a5e6-178583bcf17e)


After:
![Screenshot 2025-02-11 at 6 20
58 PM](https://github.com/user-attachments/assets/e70edb94-b927-43e7-99c4-23041759f47f)
2025-02-13 13:25:27 -06:00
5f00ae2ca9 DEV: Introduce plugin modifiers for post.cooked and topic.fancy_titles (#31261)
Related:
40fd82e2d1

This PR introduces three new plugin modifiers attached to 
- `basic_post_serializer.cooked`
- `basic_topic_serializer.fancy_title`
- `topic_view_serializer.fancy_title`

Implementation note: I had wanted to add them in the `Post` and `Topic`
models themselves, but they do not directly provide access to the
request's scope which is needed for the use case.
2025-02-14 00:19:50 +08:00
65d7ea2dbc FIX: Keep user in same context after login (#31314)
This fixes the destination of the auth process in the following
scenarios:

- when landing on a PM or a topic as an anonymous user and then loggin
in
- when landing on a public topic, hitting Reply or Like and then logging
in
2025-02-13 10:35:00 -05:00
8d709aeb9c DEV: Introduce DecoratedHtml component and use for discourse-banner (#31305)
Eventually, this new component will be used everywhere that we render
'decorated' HTML (e.g. all posts and chat messages). It takes the best
bits from our main widget-based post rendering and re-creates it in a
more ember-native way. For example:

- The HTML is first rendered in a detached DOM, so that requests for
images/iframes/etc. are not triggered until after the decoration

- HTML generation and decoration is done in a helper (i.e. during the
'render' phase of the runloop). I think that's the 'most Ember
compatible' way for us to do this. It means that components added via
`renderGlimmer` will be rendered in the same runloop, and it means that
things like `schedule("afterRender")` will work exactly as expected.

- HTML will be re-rendered and re-decorated whenever the `@html` or
`@decorate` arguments change

- BUT, `untrack` is used to ensure that reactive state accessed inside
the decorate function will not trigger a re-render. This is mostly for
compatibility with existing decorators, and we may want to make
reactivity opt-in in future

- A self-contained `renderGlimmer` system is included. This will allow
`helper.renderGlimmer` to be used for any content in these components.
Implementing it in a self-contained way rather than using the service
means that the component will work ok in unit tests, and that rendered
components will show up in the right place in the Ember inspector.

This commit only introduces the new component in DiscourseBanner.
Followups will introduce it elsewhere.
2025-02-13 12:20:52 +00:00
3f0e84054b FIX: ensures fields are correctly unregistered (#31329)
Ember workaround to ensure that a field with the same name is correctly
destroyed/created when changing the params and then correctly calling
registerField/unregisterFIeld.
2025-02-13 11:35:49 +01:00
2b996a9d39 DEV: Rescue from each step of EnsureDbConsistency (#31313)
A failure early in the job would prevent the rest of the ensure
consistency methods to run.
2025-02-13 12:07:04 +02:00
cbe9a9f33b DEV: Don't run conditionally skipped tests (#31326)
Those still run `QUnit.testStart`/`QUnit.testDone` callbacks, and doing
so with no actual test body leads to flaky behavior.
2025-02-13 04:27:21 +01:00
c3109f2ddd DEV: Fix dark-mode qunit "skipped" test color (#31327) 2025-02-13 04:27:12 +01:00
97d030e864 DEV: Implement disabled state in Image control (#31324) 2025-02-13 03:56:47 +01:00
82c7c1dbda DEV: add missing button classes to topic-footer-mobile-dropdown (#31323)
Adds a couple missing classes to this mobile-specific button: 


![footer-btn](https://github.com/user-attachments/assets/9f6e9fdd-a34b-4c2b-98bd-7e55b698fb50)
2025-02-12 17:51:22 -05:00
310cd513d8 DEV: Convert UppyImageUploader to gjs (#31310) 2025-02-12 23:31:42 +01:00
faf0b6902c Build(deps): Bump @faker-js/faker from 9.4.0 to 9.5.0 (#31320)
Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 9.4.0 to
9.5.0.
- [Release notes](https://github.com/faker-js/faker/releases)
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md)
- [Commits](https://github.com/faker-js/faker/compare/v9.4.0...v9.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-12 23:04:40 +01:00
dbb52e5f57 Build(deps): Bump ace-builds from 1.37.5 to 1.38.0 (#31319)
Bumps [ace-builds](https://github.com/ajaxorg/ace-builds) from 1.37.5 to
1.38.0.
- [Release notes](https://github.com/ajaxorg/ace-builds/releases)
-
[Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md)
-
[Commits](https://github.com/ajaxorg/ace-builds/compare/v1.37.5...v1.38.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-12 23:01:52 +01:00
c3588ce725 Build(deps): Bump prosemirror-view from 1.37.2 to 1.38.0 (#31318)
Bumps
[prosemirror-view](https://github.com/prosemirror/prosemirror-view) from
1.37.2 to 1.38.0.
-
[Changelog](https://github.com/ProseMirror/prosemirror-view/blob/master/CHANGELOG.md)
-
[Commits](https://github.com/prosemirror/prosemirror-view/compare/1.37.2...1.38.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-12 22:58:43 +01:00
797bb8b8af DEV: add btn-transparent class to advanced search button (#31316)
Noticed that this advanced search button unintentionally picks up some
unwanted styles in themes:


![image](https://github.com/user-attachments/assets/0bccddcd-3982-4b4d-9a98-efc2f91a9077)

adding the btn-transparent class should help
2025-02-12 16:21:55 -05:00
d2a34bed84 DEV: Add post-menu-toggle-like-action transformer (#31295)
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2025-02-12 16:29:59 -03:00
2e10fe98a3 FIX: automatically redirect logged in users to topic when... (#31301)
...loading an invite link that points to a topic they already have
access to.

This "feature" was removed in 07ef1a80a1461123d602c57e366974aed265a91e
as part of the security fix.

Internal ref - t/145628
2025-02-12 17:48:59 +01:00
6f5cdfccf5 DEV: Add search result view appEvent trigger (#31287)
This PR adds a trigger for the `search-result-view` appEvents.
2025-02-12 10:39:37 -06:00
963675c32e FIX: do not show confirmation modal (#31304)
Currently when using the shortcuts to delete a post the UI would show
you the confirmation modal even if you don't have the right to do it.
This commit fixes the issue at the root in the
`deletePostWithConfirmation` function.
2025-02-12 17:04:08 +01:00
f5c2a4dbbd DEV: Drop experimental enable_diffhtml_preview setting (#31306)
This was intended to provide a better UX for interactive elements in the
composer preview. However, the morphing strategy has irreconcilable
conflicts with our `decorateCooked` API, and so we have been unable to
enable this by default.

Going forward, we're focussing efforts on the WYSIWYG composer to
provide this kind of smooth UX, so we're dropping the
`enable_diffhtml_preview` approach.
2025-02-12 15:58:30 +00:00
d6d3c2316b UX: Hide powered-by on admin invite page (#31303)
similar to: 63d376c7a9542709ec748aad32e76f304da29f4f


![image](https://github.com/user-attachments/assets/75e5b6cd-d967-4483-a16e-8fa852746c1e)
2025-02-12 07:55:17 -07:00
23e07fb076 DEV: supports pointerover and pointerout (#31302)
This commit adds support these events in widgets.

Usage in a widget:

```javascript
pointerOver(event) {}
pointerOut(event) {}
```
2025-02-12 14:54:17 +01:00
820c8cb119 Build(deps): Bump the babel group with 2 updates (#31245)
Bumps the babel group with 2 updates:
[@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core)
and
[@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone).


Updates `@babel/core` from 7.26.7 to 7.26.8
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/babel/babel/commits/v7.26.8/packages/babel-core)

Updates `@babel/standalone` from 7.26.7 to 7.26.8
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/babel/babel/commits/v7.26.8/packages/babel-standalone)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Discourse CI <ci@ci.invalid>
2025-02-12 12:52:10 +01:00
5b8a35c87d Build(deps): Bump terser from 5.37.0 to 5.38.2 (#31289)
Bumps [terser](https://github.com/terser/terser) from 5.37.0 to 5.38.2.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/compare/v5.37.0...v5.38.2)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-12 12:44:15 +01:00
238160b812 Build(deps): Bump prosemirror-view from 1.37.1 to 1.37.2 (#31186)
Bumps
[prosemirror-view](https://github.com/prosemirror/prosemirror-view) from
1.37.1 to 1.37.2.
-
[Changelog](https://github.com/ProseMirror/prosemirror-view/blob/master/CHANGELOG.md)
-
[Commits](https://github.com/prosemirror/prosemirror-view/compare/1.37.1...1.37.2)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-12 12:11:46 +01:00
a43d905ec6 Build(deps-dev): Bump ember-cli from 6.1.0 to 6.2.0 (#31229)
Bumps [ember-cli](https://github.com/ember-cli/ember-cli) from 6.1.0 to
6.2.0.
- [Release notes](https://github.com/ember-cli/ember-cli/releases)
-
[Changelog](https://github.com/ember-cli/ember-cli/blob/master/CHANGELOG.md)
-
[Commits](https://github.com/ember-cli/ember-cli/compare/v6.1.0...v6.2.0)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Discourse CI <ci@ci.invalid>
2025-02-12 12:11:36 +01:00
e7f56e121f Build(deps-dev): Bump @swc/core from 1.10.12 to 1.10.15 (#31247)
Bumps [@swc/core](https://github.com/swc-project/swc) from 1.10.12 to
1.10.15.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/swc-project/swc/compare/v1.10.12...v1.10.15)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-12 12:09:44 +01:00