f60dc7f5b4
FIX: Broken specs
...
`/u/` is no longer in robots.txt, so don't test for it
2020-06-25 14:30:57 -04:00
689568c216
FIX: invalid urls should not break store.has_been_uploaded?
...
Breaking this method has wide ramification including breaking
search indexing.
2020-06-25 15:00:15 +10:00
9c7d3b2dc0
FIX: Avoid marking notifications as seen in readonly mode.
2020-06-25 10:14:07 +08:00
7109d94ee7
FIX: properly invalidate inline oneboxes when rebaking
...
When rebaking a post we were invalidating _regular_ oneboxes but not inline oneboxes.
DEV: also renamed 'InlineOneboxer.purge' to 'InlineOneboxer.invalidate' to keep
the API consistent with 'Oneboxer.invalidate'
2020-06-24 11:54:54 +02:00
75151f0457
FIX: Use correct URL for unsubscribe ( #10077 )
2020-06-24 09:31:20 +02:00
2987901043
FIX: skip category notification_level unless scoped
...
#b19dcac2 improved the serializer so it sends default notification
levels to users to work around cases where a category edit would
would result in clients being left with invalid notification state
Unfortunately this did not address the root issue.
When we edit categories we publish state to multiple users this
means that the serializer is executed unscoped with no user.
The client already handles this case per:
dcad720a4c/app/assets/javascripts/discourse/app/models/site.js (L119-L119)
2020-06-24 17:08:12 +10:00
91c89df68a
FIX: onebox local topic when using slug-less URL
...
When linking to a topic in the same Discourse, we try to onebox the link to show the title
and other various information depending on whether it's a "standard" or "inline" onebox.
However, we were not properly detecting links to topics that had no slugs (eg. https://meta.discourse.org/t/1234 ).
2020-06-23 17:18:38 +02:00
c5078e5dc1
DEV: Remove accidentally committed puts statements
2020-06-23 12:41:47 +01:00
e92909aa77
FIX: Use ActionDispatch::Http::ContentDisposition for uploads content-disposition ( #10108 )
...
See https://meta.discourse.org/t/broken-pipe-error-when-uploading-to-a-s3-clone-a-pdf-with-a-name-containing-e-i-etc/155414
When setting content-disposition for attachment, use the ContentDisposition class to format it. This handles filenames with weird characters and localization (accented characters) correctly.
2020-06-23 17:10:56 +10:00
add2a9411e
DEV: Remove specs that are no longer relevant.
2020-06-23 12:09:04 +08:00
25db91e351
Revert "FIX: These tests are broken"
...
This reverts commit b1114b9a20343525c805d7339bd64954965a12f9.
2020-06-23 08:41:10 +08:00
b1114b9a20
FIX: These tests are broken
2020-06-22 16:30:46 -04:00
ac9577bcc7
FIX: Don't raise an exception if we can't update the user on demotion
...
This is causing issues when purging old users, if they are set up in the
exact condition where they will be demoted into another group, but also
do not have a primary email.
2020-06-22 15:43:59 -04:00
68f767a557
FEATURE: Check if selectable avatars exist before enabling them ( #10032 )
2020-06-22 16:58:26 +03:00
685646540a
FIX: Hide PM tags if the site setting is disabled ( #10089 )
...
* FIX: Hide PM tags if the site setting is disabled
* Apply code suggestions
2020-06-22 16:48:24 +03:00
8cc8e80d7a
Fix the build.
2020-06-22 14:50:17 +08:00
3370ef188e
FEATURE: Remove deprecated uploads url site settings.
...
The site settings have been replaced with direct image upload since
Discourse 2.3.
2020-06-22 14:32:29 +08:00
17c4f76eac
FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled ( #10091 )
2020-06-19 20:21:05 +01:00
58a5293d9b
FIX: Delete PostUploads on Post deletion ( #10090 )
...
Related uploads will then be removed by Jobs::CleanUpUploads
2020-06-19 17:45:08 +02:00
4a2871f7f6
FEATURE: Don't display muted/ignored users under "who liked" ( #10084 )
...
* FEATURE: Don't display muted/ignored users under "who liked"
Previously, if you clicked on the heart icon below a post
it would show you the avatar for a user even if you ignored or muted
them.
This commit will instead display a (?) icon. The count of likes will
remain correct, but you needn't be reminded of the person you
preferred not to see.
* Use a circle instead of (?) for unknown user
2020-06-19 10:44:21 -04:00
a99bb0ded4
Revert "FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled"
...
This changed cause plugin spec failures and needs further investigation
This reverts commit 78626d2832d54c867e9d8c20e3e0c68fa5f2137e.
2020-06-19 14:39:16 +01:00
9f2e7e4651
FIX: Handle invalid URLs gracefully when pulling hotlinked images
2020-06-19 12:52:51 +01:00
78626d2832
FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled
2020-06-19 12:45:06 +01:00
9cf77372a2
FIX: Guardian#can_remove_allowed_users? shouldn't break for ownerless topics
...
A topic can outlive its original author. TopicGuardian should still work
in this situation.
2020-06-19 10:35:52 +01:00
ae47bcb269
DEV: move user references deletion code to before_destroy. ( #10085 )
...
Moving the `delete_source_user_references` method code from user merger service to user model.
2020-06-18 17:42:39 -04:00
a1df68d4c4
FIX: Do not change tracked categories for staged users ( #10076 )
2020-06-18 21:09:54 +03:00
d13d5e2b99
FIX: Allow multiple hyphens in host ( #10078 )
...
* FIX: Allow multiple hyphens in host
* FIX: added spec for multiple hyphens
2020-06-18 13:58:47 -04:00
494a27dc27
FIX: A much nicer error message if you can't ignore/mute a user
2020-06-18 13:41:27 -04:00
e31471585a
DEV: allow to have duplicate topic titles if categegory is different ( #10034 )
...
Co-authored-by: Robin Ward <robin.ward@gmail.com >
Co-authored-by: Robin Ward <robin.ward@gmail.com >
2020-06-18 11:19:47 -04:00
db1bebddce
FIX: Hide the post history for TL4 ( #10065 )
2020-06-18 13:27:51 +03:00
d21a08c284
DEV: Deprecate Category#url_with_id in favor of Category#url ( #9972 )
2020-06-18 11:32:14 +03:00
75991a249e
fix spec ( #10069 )
2020-06-18 09:02:08 +02:00
79ab1493c8
DEV: Add test ( #10066 )
...
Follow-up-to f1b97202d445279e8a64a81fddb5678e636f5114
2020-06-17 21:41:29 +03:00
7ed7b1ef64
DEV: Add test ( #10064 )
...
Follow-up-to 84dfaad137a215bf722388cccbe22f593279f5a2
2020-06-17 21:41:16 +03:00
a60a67c431
FIX: Show unconfirmed emails too when checking emails ( #10062 )
...
When checking emails through user preferences, it did not display the
unconfirmed emails.
2020-06-17 21:41:01 +03:00
e8756e1a95
FIX: Muted/Ignore should prevent PMs regardless of case sensitivity
2020-06-17 14:26:14 -04:00
9518d6b587
fix spec ( #10061 )
2020-06-17 15:10:07 +02:00
6caad5c083
FIX: Do not send staff welcome message if user already has role
2020-06-17 12:12:55 +01:00
9da3a7f436
FEATURE: allows published pages to be public ( #10053 )
2020-06-17 12:42:20 +02:00
e5da2d24e5
FIX: Add attachment content-disposition for all non-image files ( #10058 )
...
This will make it so the original filename is used when downloading all non-image files, bringing S3Store into line with the to_s3 migration and local storage. Video and audio files will still stream correctly in HTML players as well.
See https://meta.discourse.org/t/cannot-download-non-image-media-files-original-filenames-lost-when-uploaded-to-s3/152797 for a lot of extra context.
2020-06-17 11:16:37 +10:00
b62ad003ce
Always require pry gems in rails_helper
...
* remove IMPROVED_SPEC_DEBUGGING env var guard
2020-06-17 10:08:53 +10:00
669c940ec3
Revert "DEV: Remove the remaining ENV["TRAVIS"] usage ( #10041 )"
...
This reverts commit 78aff841e3215c875e79692fbeaf8d18c4514006.
See https://review.discourse.org/t/dev-remove-the-remaining-env-travis-usage-10041/12737/4?u=cvx
2020-06-16 19:42:00 +02:00
78aff841e3
DEV: Remove the remaining ENV["TRAVIS"] usage ( #10041 )
2020-06-16 17:41:15 +02:00
859d9b75a7
FIX: Restoring backup from PG12 could fail on PG10
...
The `EXECUTE FUNCTION` syntax for `CREATE TRIGGER` statements was introduced in PostgreSQL 11. We need to replace `EXECUTE FUNCTION` with `EXECUTE PROCEDURE` in order to be able to restore backups created with PG12 on PG10.
2020-06-16 16:04:14 +02:00
6258406419
FIX: secondary_emails, unconfirmed_emails, group_users are private fields
...
Those fields should be only visible to the user.
2020-06-16 12:46:27 +03:00
a94387c088
FIX: check for inviter group permissions at the time of redeeming invite
2020-06-15 14:44:35 +05:30
58e52c0e4f
DEV: Use rails_failover gem for ActiveRecord and Redis failover handling
2020-06-15 15:47:07 +08:00
0ff86b00cb
DEV: Upgrade Redis to 4.2.1.
2020-06-15 10:05:22 +08:00
4b793a1072
FIX: allows PM owner to remove any user if >= TL2 ( #10036 )
2020-06-12 12:54:28 +02:00
3aab98781a
Fix tests.
2020-06-12 10:22:22 +08:00
