40b03e717b
FIX: Upload#migrate_to_new_scheme should not migrate system uploads.
2019-03-14 12:45:03 +08:00
d2a7f29595
Revert "REFACTOR: remove unnecessary parentheses attempt 2 (follow-up on 154f503d)"
...
This reverts commit 7db2dc717e672e831657183b3b069307aaa2a842.
Commit breaks post edits for regular users.
2019-03-14 08:15:40 +08:00
7db2dc717e
REFACTOR: remove unnecessary parentheses attempt 2 (follow-up on 154f503d)
2019-03-13 15:33:46 -04:00
65f3ed0689
UX: make name optional for confirmation user field ( #7149 )
2019-03-13 18:40:43 +01:00
420c6f8102
FEATURE: Skip sending emails to domains on the .invalid TLD ( #7162 )
...
This is a reserved TLD which we use when importing users without an email address. https://tools.ietf.org/html/rfc2606
2019-03-13 16:17:59 +00:00
d32557ea32
Revert "FIX: Better emoji escaping for topic title"
...
This reverts commit 35426b5ad6b00c9047b9b7ba17d42d4f30bdb488.
2019-03-13 13:02:56 +01:00
35426b5ad6
FIX: Better emoji escaping for topic title
...
This commit also puts emojiVersion in its own erb file.
2019-03-13 11:17:59 +01:00
b0c8fdd7da
FIX: Properly support defaults for upload site settings.
2019-03-13 16:36:57 +08:00
e9ba4c74f7
Revert "REFACTOR: remove unnecessary parentheses"
...
Specs fail
2019-03-12 15:00:58 -04:00
a901527057
DEV: remove user_profile events added for akismet ( #7044 )
2019-03-12 17:51:09 +01:00
154f503d2e
REFACTOR: remove unnecessary parentheses
2019-03-12 17:13:21 +01:00
28384ba62c
FEATURE: Add Top Ignored Users report ( #7153 )
...
* FEATURE: Add `Top Ignored Users` report
## Why?
This is part of the [Ability to ignore a user feature](https://meta.discourse.org/t/ability-to-ignore-a-user/110254/8 ), and also part of [this PR](https://github.com/discourse/discourse/pull/7144 ).
We want to send a System Message daily when a specific count threshold for an ignored is reached. To make this system message informative, we want to link to a report for the Top Ignored Users too.
2019-03-12 16:01:58 +00:00
4a00772c19
FIX: invite approval StaffActionLogger bug ( #7151 )
...
* FIX: invite approval `StaffActionLogger` bug
2019-03-12 13:32:25 +00:00
e6c2faf186
FIX: Disable 'Create Topic' button if tag is staff-only. ( #6984 )
...
* FIX: Disable 'Create Topic' button if tag is staff-only.
* FIX: Staff-only tags should always return 404.
2019-03-12 19:23:36 +11:00
191e31dccf
FEATURE: Log user approvals. ( #7121 )
2019-03-12 19:16:56 +11:00
32bae48fd3
DEV: Use User#human? User#bot? ( #7140 )
2019-03-12 07:58:14 +08:00
b28b418363
FIX: Various improvements to post notices.
...
- Notices are visible only by poster and trust level 2+ users.
- Notices are not generated for non-human or staged users.
- Notices are deleted when post is deleted.
2019-03-11 11:19:58 +02:00
57ee779b1e
FIX: Job exception: undefined method `email' for nil:NilClass
...
It seems that due to jobs being asynchronous and wrapping code in a
DistributedMutex that by the time we run the
`UserAvatar#update_gravatar!` job that the user/user email might be
destroyed.
This patch checks before a call to `user.email_hash` to make sure
the user and primary email exist to prevent the exception. If not
present, the job exits as there's nothing to do because we are
probably running after the user was destroyed for some reason.
2019-03-08 13:39:56 -05:00
5e58cedfbd
FIX: retranspile theme JS when settings YAML changes ( #7131 )
2019-03-08 17:49:06 +03:00
ad12b2a23d
FIX: only call 'unlink' for tempfiles
2019-03-08 11:22:20 +01:00
2312caccdc
FEATURE: Skip small actions when counting replies in PMs. ( #7108 )
2019-03-08 10:49:34 +02:00
35942f7c7c
FEATURE: Special call-out for new / returning posters. ( #7115 )
2019-03-08 10:48:35 +02:00
f6ef4f8c3f
FEATURE: Add missing S3 regions
2019-03-07 22:42:20 +01:00
fc7938f7e0
REFACTOR: Migrate GoogleOAuth2Authenticator to use ManagedAuthenticator ( #7120 )
...
https://meta.discourse.org/t/future-social-authentication-improvements/94691/3
2019-03-07 11:31:04 +00:00
2c8e1d3578
FEATURE: remove all expired invitations by default
2019-03-07 15:28:39 +05:30
167d85c21f
FIX: post & topic destroyed hooks not triggering with tag filter
2019-03-06 22:52:54 +05:30
8d7c10f7f2
FIX: allow moderators to create categories setting broken
...
Mods require visibility to everyone group cause category dialogs need to
know about this.
If the site setting `allow moderators to create categories` will not function
without this
Note there is no security expansion of rights here, the group is technically
empty anyway and it always looks exactly the same on all discourse instances
2019-03-06 17:44:18 +11:00
fea5d4f3ec
FIX: any subcategory permissions are valid if everyone has access to parent category ( #7097 )
2019-03-04 14:49:26 +11:00
1cd64f68f1
FIX: staff/admin shouldn’t be able to create uncategorized topics ( #7077 )
2019-02-28 15:51:13 +01:00
c02956e29c
FIX: when posts are moved to a message then small action post should not be publicly visible ( #7085 )
...
This fix is inspired from what we do in discourse-assigned plugin.
https://github.com/discourse/discourse-assign/blob/master/lib/topic_assigner.rb#L184
https://github.com/discourse/discourse-assign/blob/master/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6#L125-L133
2019-02-28 19:49:26 +05:30
986cc8a0fb
FEATURE: Introduce Ignore user ( #7072 )
2019-02-27 14:49:07 +01:00
f68a7a16a4
FIX: Use field name to name files in theme export. ( #7009 )
2019-02-27 10:45:22 +01:00
a8ffc02d06
PERF: Reduce N+1s on theme admin page
2019-02-26 14:22:02 +00:00
90c09d17b6
FIX: Heisentest - don't memoize on a class variable
...
Repeated usage of the same class will have the same memoized results
even if the data has changed.
2019-02-25 14:49:01 -05:00
260398d706
FIX: Live refresh parent themes when editing child themes
2019-02-22 21:13:07 +00:00
d1bad881ea
FEATURE: Allow moderators to change topic timestamps ( #7053 )
2019-02-22 14:33:52 +05:30
f8e498f6ad
DEV: Fix random build error
2019-02-21 14:53:29 +01:00
58b0e945bd
UX: Lightbox support for image uploader. ( #7034 )
2019-02-21 10:13:37 +08:00
66901f67f6
UX: Moderator post wasn't completely translatable
2019-02-20 16:37:47 +01:00
1f4ace4f56
FEATURE: autocomplete usernames early in topic based on participation
...
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic
This is somewhat experimental, we may tweak this, or make it optional.
Also, a regression in a423a938 where hitting TAB would eat a post you were writing:
Eg this would eat a post:
``` text
@hello , testing 123 <tab>
```
2019-02-20 13:34:43 +11:00
5d75bd4831
FIX: Don't try to rename group when username is taken
...
FIX: Always rename groups with the default locale instead of using the user's locale
2019-02-19 22:31:03 +01:00
7878e5007a
FIX: Refactor to prevent themes affecting core stylesheets ( #7029 )
...
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
2019-02-19 15:55:59 +00:00
84c56e16f9
REFACTOR: Use keyword argument for fallback_to_english flag
2019-02-19 15:28:47 +01:00
27e7f2bee0
DEV: call 'enqueue_hooks' method only if active webhooks exist
2019-02-19 12:43:08 +05:30
f2c3415548
FIX: Should not generate payload until active webhooks are exist
2019-02-19 12:23:42 +05:30
7da7a30e02
PERF: Restore exists? in favor of blank?.
...
Regression from dcd7b925327ac3523ccbf94216e43f3f6b56df52.
2019-02-18 10:04:21 +08:00
f8b70f4ca3
FIX: unable to create new categories
...
Previous attempt at 70adb940 missed the critical "everyone" group from
staff, leading to a case where staff was no longer able to create categories
2019-02-15 10:24:29 +11:00
70adb94008
SECURITY: Do not leak private group names. ( #7008 )
2019-02-14 15:35:58 +01:00
39522659a6
FIX: validate parent category/subcategories permissions
...
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details
This ensures users with access to child category can always at least see parent
2019-02-14 16:38:52 +11:00
ed6f4dfc40
FEATURE: trigger user profile create and update event ( #6958 )
...
Adds `user_profile_created` DiscourseEvent on profile creation and `user_profile_updated` on profile update
2019-02-14 15:45:12 +11:00
