Commit Graph

41352 Commits

Author SHA1 Message Date
cdd5b60447 UX: icon instead of text for hiding mobile preview (#12625) 2021-04-06 22:22:40 -04:00
21664d8a1c DEV: add JS test for topic bulk action modal (#12621) 2021-04-07 06:34:36 +05:30
2e17e6269c FIX: Small tweaks to "no messages" education (#12588)
* Remove "Message" button in quick access menu no messages education
* Reword education prompt
* Remove background colour
2021-04-07 09:28:10 +10:00
432b839997 FEATURE: Move site updated modal into a less obtrusive prompt (#12577)
This moves the "This site was just updated" modal asking the user if they want to refresh into a subtle prompt that slides down from the header.

Also in this PR I've added a helper to publish message bus messages in JS tests. So instead of this:

```javascript
// Mimic a messagebus message
MessageBus.callbacks
  .filterBy("channel", "/global/asset-version")
  .map((c) => c.func("somenewversion"));
```

We can have:

```javascript
publishToMessageBus("/global/asset-version", "somenewversion");
```
2021-04-07 08:56:48 +10:00
b0ff853f9f Build(deps): Bump parser from 3.0.0.0 to 3.0.1.0 (#12624)
Bumps [parser](https://github.com/whitequark/parser) from 3.0.0.0 to 3.0.1.0.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v3.0.0.0...v3.0.1.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-07 00:26:11 +02:00
e302e32a3f DEV: Add Higher Logic import script (#12623)
Wrote up a new script to import from Higher Logic. Nothing too crazy going on here. Two major things about this script:

    It requires you to convert a Microsoft SQL file to a format MySQL can read.
    Higher Logic stores posts (at least in the case of the import I ran) with the email thread shown in the post body. The script does its best to truncate this out, but the logic may need to be improved on future imports. For the import I ran, it worked just fine as is. 🤷‍♂️
2021-04-06 16:53:55 -05:00
1682827f67 FIX: Include watched topics from muted categories in digests (#12602)
Topic that are muted or from muted categories are not included in
digests, but non-muted topics from muted categories should be included.
2021-04-07 00:01:15 +03:00
34596beb52 FIX: Keep current filter while navigating posts in a topic (#12620) 2021-04-06 15:00:25 -04:00
75a0d9aa01 DEV: Add a new plugin outlet to composer bottom for mobile buttons (#12622) 2021-04-06 14:27:34 -04:00
cdb99f012b FIX: Retain tags when loading a topic draft in composer (#12616) 2021-04-06 11:49:06 -04:00
769b3ba8ae DEV: Add colors/styling to Ember CLI and qunit tests (#12617) 2021-04-06 11:48:44 -04:00
e8a9917db1 FEATURE: Allow setting avatar flair for automatic groups (#12586) 2021-04-06 11:13:06 -04:00
0052fcf7c4 FEATURE: Retrieve an existing link only invite (#12575)
In Improve invite system, a newly created link only invite cannot
be retrieved via API with the invitee's email once created. A new
route, /invites/retrieve, is introduced to fetch an already
created invite by email address.
2021-04-06 11:01:07 -04:00
1ebb40a713 FIX: show sign up modal when local logins are disabled (#12611) 2021-04-06 10:31:51 -04:00
98ae4e2829 FIX: Clear state after creating new topic (#12615) 2021-04-06 10:17:14 -04:00
f56a22bd2e FIX: New Topic button regression in tag page (#12613) 2021-04-06 09:31:49 -04:00
e026af11ac FIX: Simplify send PM to email settings (#12583)
This feature used to be controlled by two site settings 
enable_personal_email_messages and min_trust_to_send_email_messages.
I removed enable_personal_email_messages and unhide 
min_trust_to_send_email_messages to simplify the process of 
enabling / disabling this feature.
2021-04-06 15:39:27 +03:00
3c880910d3 Build(deps): Bump rexml from 3.2.4 to 3.2.5 (#12606)
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.4 to 3.2.5.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](https://github.com/ruby/rexml/compare/v3.2.4...v3.2.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-06 13:25:03 +02:00
002b937e1e Build(deps): Bump mini_mime from 1.0.3 to 1.1.0 (#12607)
Bumps [mini_mime](https://github.com/discourse/mini_mime) from 1.0.3 to 1.1.0.
- [Release notes](https://github.com/discourse/mini_mime/releases)
- [Changelog](https://github.com/discourse/mini_mime/blob/master/CHANGELOG)
- [Commits](https://github.com/discourse/mini_mime/compare/v1.0.3...v1.1.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-06 13:04:26 +02:00
f14e898f6f A11Y: makes replies count a button and not a link (#12570) 2021-04-06 08:27:43 +02:00
80be6e6949 Overflow on user controls breaks select-kit (#12592) 2021-04-05 23:42:44 -04:00
6f79c452c2 FIX: bulk select on full-page search (#12593) 2021-04-05 23:11:57 -04:00
f8e5df393d UX: better position for search bulk select button (#12594) 2021-04-05 23:11:43 -04:00
ce251986bf DEV: Set min_search_term_length to 1 (#12610)
Japanese languages and the like should have a min_search_term_length of
1.

See: https://meta.discourse.org/t/97359/27

and

https://meta.discourse.org/t/185218/7
2021-04-05 17:37:58 -06:00
3a22c654e2 FIX: rake themes:update should fail if a theme update fails (#12608) 2021-04-05 15:53:34 -07:00
89f1bb7d2a FIX: with vanilla js .href and getAttribute("href") are not equal (#12609)
With a link having an empty href: `<a href>foo</a>` doing
`element.href` will give you the URL of the document, to get the same behavior than `$(element).attr("href")` and get "" you need to do `element.getAttribute("href")`
2021-04-06 00:36:28 +02:00
1ceefc22d5 FIX: rake themes:install error if theme cannot be updated (#12605)
Count errors on updating themes in the error bucket. Otherwise,
there was a chance that this could hide errors eg, if a deploy key to a
private repo were to be deleted. Admins probably would like to know about this.
2021-04-05 14:52:50 -07:00
3a18dd5681 Revert "A11Y: Do not use positive tabindex in composer (#12563)" (#12603)
This reverts commit af879b7851e3c26b9a612dc7d76ca02c80a619c6.
2021-04-05 14:36:43 -04:00
6234d7455b FEATURE: add maximum limit for secondary emails (#12599) 2021-04-05 20:31:42 +05:30
8a36b91c2c DEV: removes jquery usage from intercept-click (#12600) 2021-04-05 11:59:58 +02:00
96737b3d97 Build(deps): Bump oauth from 0.5.5 to 0.5.6 (#12595) 2021-04-05 11:04:05 +02:00
4105a30635 Build(deps): Bump progress from 3.5.2 to 3.6.0 (#12596) 2021-04-05 00:45:09 +02:00
41c0aca216 Build(deps): Bump rubocop from 1.12.0 to 1.12.1 (#12597) 2021-04-05 00:38:17 +02:00
9be99c055f DEV: bundle update onebox (#12591) 2021-04-02 15:11:15 -04:00
b230c30249 FIX: downloading watched words was broken (#12578) 2021-04-02 23:04:35 +05:30
bfd0c00944 FEATURE: Copying invite link triggers a save (#12581)
Changing the invite type from link to email and then copying it was
confusing because it gave user the impression that the invite was
updated and the invite link will reflect the latest changes, but it
did not.
2021-04-02 11:19:30 +03:00
81e5352e01 FIX: Better error message for redeemed invite (#12580)
This commit improves the error message when a user tries to redeem a
completely redeemed invite link.
2021-04-02 11:11:07 +03:00
cc2eb6e7b3 Change to no_messages_body copy (#12587)
The original copy I proposed was too scary, so here's a simplified educational message.
2021-04-01 15:00:20 -07:00
42fb806f43 A11Y: make th keyboard accessible + aria attribs (#11895) 2021-04-01 14:19:59 -04:00
1d2ddbfebf DEV: Pass editFirstPost action to plugin outlet in topic.hbs (#12582) 2021-04-01 12:20:10 -05:00
5d2cd15548 FEATURE: Use appEvents instead of jQuery for composer resizing progress (#12574)
Additionally, add a composer:resize-started event to complement composer:resize-ended.
2021-04-01 13:00:57 -04:00
3db08c073b FIX: "confirm new email" emails were failing for EmailChangeRequest records with blank requested_by_user_id field (#12579) 2021-04-01 16:39:28 +05:30
61860098d9 UX: move logs/watched_words to customize/watched_words in admin section (#12571)
https://meta.discourse.org/t/where-is-auto-tag-and-auto-replace/184261
2021-04-01 11:44:17 +05:30
c478ffc662 FIX: post merging was failing silently (#12566)
https://meta.discourse.org/t/merging-very-long-posts-removes-them/183597
2021-04-01 06:46:18 +05:30
28d67b4583 FEATURE: Show an educational message in the quick access menu for personal messages when there are none (#12564)
If the user has not been sent any messages, show a message in the quick access menu with an educational message. If the user can send private messages, also show a link to open the "new message" composer:

This also adds a general improvement to the quick-access-panel, to be able to show an `emptyStateWidget` instead of just a message if there is nothing to show in the panel, as well as initial general styles for empty state.
2021-04-01 10:22:40 +10:00
7cf42cd830 Build(deps): Bump i18n from 1.8.9 to 1.8.10 (#12576)
Bumps [i18n](https://github.com/ruby-i18n/i18n) from 1.8.9 to 1.8.10.
- [Release notes](https://github.com/ruby-i18n/i18n/releases)
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.8.9...v1.8.10)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-01 01:39:01 +02:00
b317962fe2 FIX: title when YouTube is pasted as the title to composer (#12565)
When the YouTube link is passed to the composer, it should extract the title.

https://meta.discourse.org/t/youtube-link-not-generate-title/183776
2021-04-01 10:16:14 +11:00
af879b7851 A11Y: Do not use positive tabindex in composer (#12563) 2021-03-31 17:33:14 -04:00
5a430e79b0 DEV: bundle update onebox (#12573) 2021-03-31 14:57:46 -04:00
68d0916eb5 FEATURE: Oneboxer cache response body (#12562)
* FEATURE: Cache successful HTTP GET requests during Oneboxing

Some oneboxes may fail if when making excessive and/or odd requests against the target domains. This change provides a simple mechanism to cache the results of succesful GET requests as part of the oneboxing process, with the goal of reducing repeated requests and ultimately improving the rate of successful oneboxing.

To enable:

Set `SiteSetting.cache_onebox_response_body` to `true`

Add the domains you’re interesting in caching to `SiteSetting. cache_onebox_response_body_domains` e.g. `example.com|example.org|example.net`

Optionally set `SiteSetting.cache_onebox_user_agent` to a user agent string of your choice to use when making requests against domains in the above list.

* FIX: Swap order of duration and value in redis call

The correct order for `setex` arguments is `key`, `duration`, and `value`.

Duration and value had been flipped, however the code would not have thrown an error because we were caching the value of `1.day.to_i` for a period of 1 seconds… The intention appears to be to set a value of 1 (purely as a flag) for a period of 1 day.
2021-03-31 13:19:34 -04:00