Commit Graph

35890 Commits

Author SHA1 Message Date
9e8ee90774 Build(deps): Bump aws-partitions from 1.266.0 to 1.267.0 (#8762)
Bumps [aws-partitions](https://github.com/aws/aws-sdk-ruby) from 1.266.0 to 1.267.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-partitions/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-22 11:52:47 -05:00
4553a0f6e0 FIX: Ensure sourcemap's source is correct 2020-01-22 12:57:28 -03:00
b25d9e96c1 FIX: Show all parent categories on topic page (#8767) 2020-01-22 17:39:50 +02:00
7b7e1717f2 FIX: Quoting a quote preserves the original post information (#8746)
Let's say post #2 quotes post number #1. If a user decides to quote the
quote in post #2, it should keep the information of post #1
("user_1, post: 1, topic: X"), instead of replacing with current post
info ("user_2, post: 2, topic: X").
2020-01-22 16:10:23 +02:00
8a89b7e108 FIX: Ensure only edited badge titles update a users title
When editing site texts from

/admin/customize/site_texts/

you can edit badge titles (aka name) and this will update any users that
have that badge currently set as their title. This fix prevents a badge
description text from being set as their title if an admin updates the
badge description text or any other badge fields that aren't the title.
2020-01-21 19:09:42 -07:00
cca654fc1a Version bump to v2.4.0.beta10 v2.4.0.beta10 2020-01-21 17:05:30 -05:00
96b64df4d4 FIX: use schema.org's BreadcrumList
The data-vocabulary.org schema is being deprecated.
We're now using the BreadcrumList data from the latest and greatest schema.org.

FIX: categories_breadcrumb helper to support more than 2 levels of categories.
2020-01-21 22:27:21 +01:00
89bd7ba45f FIX: Use new tag routes (#8683)
Commit 1fb7a62 added unambiguous routes for tags. This commit ensures
that the new routes are used.
2020-01-21 19:23:08 +02:00
fe6ff1b5ab DEV: Fix failing test
jquery.autoellipsis tries to automatically find the available space
which depends on multiple factors which may differ between the machines
where the tests are running.

Follow-up to commit 9c628f089792dbbc417a185c5933d6cbcd54dd31.
2020-01-21 19:15:29 +02:00
9c628f0897 FIX: Workaround limitation in jquery.autoellipsis (#8747)
Calling $.ellipsis() on an element containing <br> elements would throw
an exception.
2020-01-21 18:44:50 +02:00
0a27086764 FEATURE: Export all types of reports (#8748)
There is a single stacked_chart which was not exportable
2020-01-21 18:43:19 +02:00
8883cca373 enqueue spam/dmarc failing emails instead of hiding (#8674)
* enqueue spam/dmarc failing emails instead of hiding

* add translations for dmarc/spam enqueued reasons

* unescape quote

* if email_in_authserv_id is blank return gray for all emails
2020-01-21 11:12:00 -05:00
411512c0e3 FIX: higher z-index for usercards in the header 2020-01-21 10:57:32 -05:00
03143d9449 FIX: Do not extract dates from quotes and Oneboxes (#8754)
Post.local_dates used to contain dates from quotes and Oneboxes.
2020-01-21 17:42:41 +02:00
4e6ca5610c Build(deps): Bump aws-sdk-core from 3.87.0 to 3.89.1 (#8719)
Bumps [aws-sdk-core](https://github.com/aws/aws-sdk-ruby) from 3.87.0 to 3.89.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-21 10:09:56 -05:00
b49f7a420b Build(deps): Bump aws-sdk-kms from 1.27.0 to 1.28.0 (#8755)
Bumps [aws-sdk-kms](https://github.com/aws/aws-sdk-ruby) from 1.27.0 to 1.28.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-kms/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/1.27.0...1.28.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-21 10:09:41 -05:00
6cf088b7c9 Build(deps-dev): Bump byebug from 11.0.1 to 11.1.0 (#8758)
Bumps [byebug](https://github.com/deivid-rodriguez/byebug) from 11.0.1 to 11.1.0.
- [Release notes](https://github.com/deivid-rodriguez/byebug/releases)
- [Changelog](https://github.com/deivid-rodriguez/byebug/blob/master/CHANGELOG.md)
- [Commits](https://github.com/deivid-rodriguez/byebug/compare/v11.0.1...v11.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-21 10:09:20 -05:00
3c28f55ab7 Build(deps): Bump mini_sql from 0.2.3 to 0.2.4 (#8757)
Bumps [mini_sql](https://github.com/discourse/mini_sql) from 0.2.3 to 0.2.4.
- [Release notes](https://github.com/discourse/mini_sql/releases)
- [Changelog](https://github.com/discourse/mini_sql/blob/master/CHANGELOG)
- [Commits](https://github.com/discourse/mini_sql/compare/v0.2.3...v0.2.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-21 10:08:53 -05:00
32ec61d63c Build(deps): Bump unicode-display_width from 1.6.0 to 1.6.1 (#8756)
Bumps [unicode-display_width](https://github.com/janlelis/unicode-display_width) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/janlelis/unicode-display_width/releases)
- [Changelog](https://github.com/janlelis/unicode-display_width/blob/master/CHANGELOG.md)
- [Commits](https://github.com/janlelis/unicode-display_width/compare/v1.6.0...v1.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-21 10:08:24 -05:00
84a2aae77f FIX: Allow the app to generate and accept longer backup codes (#8761)
- Increase size of textarea when displaying generated codes
- Adjust maxlength of input field in JS UI
- Adjust maxlength of input field in no_ember UI

Follow-up to bff9880d6319745524a892e148a91170092b927a
2020-01-21 14:28:31 +00:00
9db59deb11 Only warn about missing recipients for PM archetype 2020-01-21 16:38:16 +10:00
88e23d4cfa Change logger.debug to logger.warn for PM debug messages 2020-01-21 16:11:52 +10:00
bff9880d63 DEV: increase the length of backup codes
16 ^ 8 though not tiny but is a workable search space in the event of
breach, 16 ^ 16 is not.
2020-01-21 15:32:06 +11:00
c677f8ee6a DEV: Add debug lines for mystery no_user_selected error (#8759)
On some customer forums we are randomly getting a "You must select a valid user" error when sending a PM even when all parameters seem to be OK. This is an attempt to track it down with more data.
2020-01-21 10:50:44 +10:00
aa04349cfd FIX: Incorrect locale in badge granter (#8749)
We want to use default locale when:
a) Site settings are not allowing for user locale
OR
b) User locale are blank
2020-01-21 09:08:48 +11:00
0420be88a6 FIX: when tag or category is added notify users that topic was modified (#8750)
There is a feature, that when tag or category is added to the topic,
customers who are watching that category or tag are notified.

The problem is that it is using default notification type "new post"

It would be better to use "new post" only when there really is a new
post and "edited" when categories or tags were modified.
2020-01-21 08:41:13 +11:00
79f5d24571 FIX: Do not error in excerpts when aside tag has no class attribute 2020-01-20 16:09:23 -05:00
304dcb3eb8 Build(deps): Bump ffi from 1.11.3 to 1.12.1 (#8721)
Bumps [ffi](https://github.com/ffi/ffi) from 1.11.3 to 1.12.1.
- [Release notes](https://github.com/ffi/ffi/releases)
- [Changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ffi/ffi/compare/1.11.3...1.12.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-20 15:45:55 -05:00
932ccc89d7 Build(deps): Bump i18n from 1.8.0 to 1.8.2 (#8705)
Bumps [i18n](https://github.com/svenfuchs/i18n) from 1.8.0 to 1.8.2.
- [Release notes](https://github.com/svenfuchs/i18n/releases)
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/svenfuchs/i18n/compare/v1.8.0...v1.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-20 15:45:02 -05:00
cff97b9ab3 Build(deps): Bump oj from 3.10.0 to 3.10.1 (#8722)
Bumps [oj](https://github.com/ohler55/oj) from 3.10.0 to 3.10.1.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/oj/compare/v3.10.0...v3.10.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-20 15:44:35 -05:00
e5e210f616 Build(deps): Bump aws-partitions from 1.262.0 to 1.266.0 (#8745)
Bumps [aws-partitions](https://github.com/aws/aws-sdk-ruby) from 1.262.0 to 1.266.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-partitions/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-20 15:40:30 -05:00
23b9da6b1c DEV: Fix the CI workflow
See: https://github.com/actions/setup-ruby/pull/52
2020-01-20 18:51:55 +01:00
2dd1ff79b4 Update translations 2020-01-20 11:00:44 -05:00
788ddcc407 FIX: Make topic query include topics from sub-sub-categories (#8709) 2020-01-20 17:06:58 +02:00
1014e56e80 DEV: Respond with 403 instead of 500 for disabled local login via email
Previously if local login via email was disabled because of the site setting or because SSO was enabled, we were raising a 500 error. We now raise a 403 error instead; we shouldn't raise 500 errors on purpose, instead keeping that code for unhandled errors. It doesn't make sense in the context of what we are validating either to raise a 500.
2020-01-20 16:11:58 +10:00
eeefa1177f FIX: Make category-chooser show all parent categories (#8706) 2020-01-19 13:07:54 +02:00
79ec686ec9 DEV: Use blank instead of NOT present
Follow up to: 75069ff17917f9b8969ae0e8e0e271cdf1e38c78
2020-01-18 07:34:15 -07:00
1fb81e9f56 omit needless words 2020-01-17 16:16:21 -08:00
75069ff179 FIX: Users should be able to remove their primary group
This fix allows a user to remove their currently assigned primary group
if the Site Setting `user selected primary groups` is enabled.

Before this fix, if a user selected "none" for their primary group it
would silently fail and never be updated.
2020-01-17 15:43:54 -07:00
3fc589f875 FIX: Don't override timezone on every visit of profile preferences
The timezone should only be initialized when there is no timezone stored in the DB yet. This also fixes an error that happened in dev mode whenever you switch between user preference tabs.
2020-01-17 22:34:18 +01:00
0d08eac1c7 UX: Users must confirm when leaving a private group 2020-01-17 17:58:47 -03:00
4089607b40 UX: Minor adjustments to choose topic modal 2020-01-17 15:02:04 -05:00
a7ae28ed88 REFACTOR: removes places where we never show glyph and DRY code (#8744) 2020-01-17 20:58:15 +01:00
cb54bf4f45 FIX: Don't cause exceptions due to rename of reply_id column
This syncs the value of the `reply_id` column into the `reply_post_id` column until all servers have been deployed and the post migrations ran.

Follow-up to ab07b945c28682ce58c5149003d65e6f3fd26dff
2020-01-17 19:43:00 +01:00
b56ade5043 FIX: show PM icon in docked header 2020-01-17 13:30:54 -05:00
6abc2f5072 FIX: applies correct styles to icon and attempts to dry code (#8739) 2020-01-17 18:20:23 +01:00
56fa77c032 FIX: do not increase size of emojis in markdown tables (#8742) 2020-01-17 18:15:05 +01:00
ab07b945c2 Merge pull request #8736 from gschlager/rename_reply_id_column
REFACTOR: Rename `post_replies.reply_id` column to `post_replies.reply_post_id`
2020-01-17 17:24:49 +01:00
3b5a6c9895 REFACTOR: unify naming of only emoji (#8741) 2020-01-17 17:21:08 +01:00
28d09227f5 FIX: Reload the ReviewableScore types when extending flags (#8740)
ReviewableScore#types extend the PostActionTypes with their own, storing the result inside a class variable. To avoid overwriting an existing flag, we need to calculate the next flag ID using these types instead of the PostAction ones. Since we first call the score types to calculate the id, this list gets memoized, leaving us with an outdated list.

To fix this, we now reload ReviewableScore#types after replacing flags.
2020-01-17 11:59:38 -03:00