a02a7d66a9
DEV: properly clean up temp files in FileHelper spec
...
Followup to 74297003 , also noticed other specs were not properly cleaning
up so fixed that as well.
2019-05-28 11:33:08 +10:00
7429700389
FIX: ensure we can download maxmind without redis or db config
...
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
2019-05-28 10:28:57 +10:00
4ea21fa2d0
DEV: use #frozen_string_literal: true on all spec
...
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.
Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00
6c65718301
Include response body when raising an error in FileHelper#download.
2018-09-13 15:43:58 +08:00
010fe479cb
Fix linting.
2018-08-17 17:34:25 +08:00
16c0ebe8a8
Fix the build.
2018-08-17 16:53:07 +08:00
a26ef7738f
FIX: FileHelper#download should return nil if max size is exceeded.
2018-08-17 16:19:59 +08:00
d1860a4f7d
DEV: Fix test to use an actual PNG instead of a GIF.
2018-08-07 12:02:35 +08:00
b94633e844
FIX: FileHelper should prioritize response content-type.
...
Request to a URL with `.png` extension may return a jpg
instead causing us to attach the wrong extension to an
upload.
2018-07-30 10:54:36 +08:00
0559a4736a
FIX: don't double request when downloading a file
2018-02-24 12:35:57 +01:00
8ecf313a81
FIX: correctly raise errors when downloads fail
...
This corrects an issue where we are hitting Gravatar for 404 over and over
Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
56f98de7b2
Use webmock to stub external web requests.
2017-05-26 15:19:09 +08:00
cdbe027c1c
Refactor FileHelper to use keyword arguments.
2017-05-24 13:54:26 -04:00
36e477750c
FIX: Use same code path for downloading images
2017-05-23 14:51:30 -04:00
dd0cb6a117
FIX: Add missing test
2017-05-15 16:57:09 -04:00
