ce39733b1a
FIX: Incorrect search blurb when advanced search filters are used take2
...
Also remove include_blurbs attribute which isn't used.
2020-07-14 11:50:40 +08:00
cf02c518b9
DEV: Merge category and tag hashtags code paths ( #10216 )
...
Category and tag hashtags used to be handled differently even though
most of the code was very similar. This design was the root cause of
multiple issues related to hashtags.
This commit reduces the number of requests (just one and debounced
better), removes the use of CSS classes which marked resolved hashtags,
simplifies a lot of the code as there is a single source of truth and
previous race condition fixes are now useless.
It also includes a very minor security fix which let unauthorized users
to guess hidden tags.
2020-07-13 19:13:17 +03:00
8e2f57a498
Fix the build.
2020-07-13 18:52:04 +05:30
ba57dc57cc
DEV: use group_ids instead of group_names in invite params
2020-07-13 17:37:04 +05:30
544a9865c6
DEV: Add more API Doc specs for topic endpoints
...
Added some more specs that will be used to auto generate the api docs.
Added timed topic and update timestamp endpoints.
2020-07-10 12:08:09 -06:00
fbf29443bd
FIX: Allow signup when auth provider supplies no email
2020-07-10 17:56:33 +01:00
e88b17c044
FIX: Sync client and server side behavior for category hashtag lookup
...
Category.query_from_hashtag_slug is the only source of truth.
2020-07-10 10:45:39 +03:00
831f3cab56
DEV: Fix search rate limit tests
2020-07-09 20:44:17 -03:00
e74817cbb9
DEV: Document set notification level endpoint
...
Another commit using rswag to document the api so that the api docs can
be automatically generated.
2020-07-09 17:41:11 -06:00
e866e3d609
FEATURE: Add global rate limit for anon searches ( #10208 )
2020-07-10 09:08:34 +10:00
c2ce7f2673
FIX: Flaky test
...
The previous solution was not always working, I believe this one
will be consistent.
2020-07-09 14:48:49 -04:00
cb1f891392
Revert "FIX: Incorrect search blurb when advanced search filters are used."
...
This change was causing advanced search filters to disappear from the search input
This reverts commit 2e1eafae0647f6db439d6337b26d83edbca42865.
2020-07-09 16:19:18 +01:00
abb01148fa
DEV: Rubocop fixes
...
Follow up to: 3314654ab3ac292fc192b366d5e08641964a4ccb
2020-07-08 18:27:19 -06:00
3314654ab3
DEV: Add API Doc specs for topic endpoints
...
Added some more specs that will be used to auto generate the api docs.
2020-07-08 18:08:14 -06:00
2e1eafae06
FIX: Incorrect search blurb when advanced search filters are used.
2020-07-08 11:59:49 +08:00
c86b1ee9d1
FIX: Disable security keys at same time as TOTP 2FA ( #10144 )
...
Previously, the "Remove 2FA" button could result in an error. This syncs button visibility with behavior.
* FIX: Only offer disabling 2FA to admins
2020-07-07 12:19:30 -07:00
57d46694c5
DEV: Fix flaky test
2020-07-07 17:10:24 +03:00
333d4f9a98
FIX: Redirect user to the URL with the correct category slug ( #10167 )
...
This commit implements a category redirect similar to the one for topic
URLs with wrong slug.
2020-07-07 15:25:36 +03:00
e08b860e88
FIX: Improve category hashtag lookup ( #10133 )
...
* FIX: Improve category hashtag lookup
This commit improves support for sub-sub-categories and does not include
the ID of the category in the slug, which fixes the composer preview.
* FIX: Sub-sub-categories can be mentioned using only two levels
* FIX: Remove support for three-level hashtags
* DEV: Simplify code
2020-07-07 10:19:01 +10:00
977766e7a8
FEATURE: sso_overrides_(email|username|name) for all auth methods
...
These settings previously applied only to discourse-sso. Now they work for all external authentication methods.
2020-07-06 10:18:45 +01:00
38a30a6e96
DEV: correct regression and correct tests
...
etag change in 31976ecf was incorrect, revert it
Also correct regression in test suite.
2020-07-06 10:56:19 +10:00
48b4ed41f5
FIX: uploading an existing image as a site setting
...
The previous fix (f43c0a5d857d34) wasn't working for images that were already uploaded.
The "metadata" (eg. 'for_*' and 'secure' attributes) were not added to existing uploads.
Also used 'Upload.get_from_url' is the admin/site_setting controller to properly retrieve
an upload from its URL.
Fixed the Upload::URL_REGEX to use the \h (hexadecimal) for the SHA
Follow-up-to: f43c0a5d857d34
2020-07-03 19:16:54 +02:00
f43c0a5d85
FIX: uploading an image as a site setting
...
When uploading an image as a site setting, we need to return the "raw" URL, otherwise
when saving the site setting, the upload won't be looked up properly.
Follow-up-to: f11363d446
2020-07-03 13:23:10 +02:00
de243426c4
FIX: Negative limit values shouldn't cause error 500 ( #10162 )
2020-07-02 19:52:37 +03:00
04d7693355
FIX: Filter read/unread notifications on the server side ( #10152 )
...
https://meta.discourse.org/t/notifications-unread-only-filter/37621/32
2020-07-02 11:06:00 +01:00
f11363d446
FIX: return cdn url for uploads if available.
...
Currently it is displaying non-cdn urls in the composer preview.
2020-07-02 06:36:14 +05:30
ac968f5363
PERF: cache all metadata for 60 seconds
...
Clients tend to request webmanifests and such very often.
Keep the data cached for 60 seconds so it is not requested aggresively.
2020-07-01 12:58:02 +10:00
f60dc7f5b4
FIX: Broken specs
...
`/u/` is no longer in robots.txt, so don't test for it
2020-06-25 14:30:57 -04:00
9c7d3b2dc0
FIX: Avoid marking notifications as seen in readonly mode.
2020-06-25 10:14:07 +08:00
68f767a557
FEATURE: Check if selectable avatars exist before enabling them ( #10032 )
2020-06-22 16:58:26 +03:00
685646540a
FIX: Hide PM tags if the site setting is disabled ( #10089 )
...
* FIX: Hide PM tags if the site setting is disabled
* Apply code suggestions
2020-06-22 16:48:24 +03:00
4a2871f7f6
FEATURE: Don't display muted/ignored users under "who liked" ( #10084 )
...
* FEATURE: Don't display muted/ignored users under "who liked"
Previously, if you clicked on the heart icon below a post
it would show you the avatar for a user even if you ignored or muted
them.
This commit will instead display a (?) icon. The count of likes will
remain correct, but you needn't be reminded of the person you
preferred not to see.
* Use a circle instead of (?) for unknown user
2020-06-19 10:44:21 -04:00
a1df68d4c4
FIX: Do not change tracked categories for staged users ( #10076 )
2020-06-18 21:09:54 +03:00
494a27dc27
FIX: A much nicer error message if you can't ignore/mute a user
2020-06-18 13:41:27 -04:00
db1bebddce
FIX: Hide the post history for TL4 ( #10065 )
2020-06-18 13:27:51 +03:00
d21a08c284
DEV: Deprecate Category#url_with_id in favor of Category#url ( #9972 )
2020-06-18 11:32:14 +03:00
75991a249e
fix spec ( #10069 )
2020-06-18 09:02:08 +02:00
79ab1493c8
DEV: Add test ( #10066 )
...
Follow-up-to f1b97202d445279e8a64a81fddb5678e636f5114
2020-06-17 21:41:29 +03:00
7ed7b1ef64
DEV: Add test ( #10064 )
...
Follow-up-to 84dfaad137a215bf722388cccbe22f593279f5a2
2020-06-17 21:41:16 +03:00
a60a67c431
FIX: Show unconfirmed emails too when checking emails ( #10062 )
...
When checking emails through user preferences, it did not display the
unconfirmed emails.
2020-06-17 21:41:01 +03:00
9da3a7f436
FEATURE: allows published pages to be public ( #10053 )
2020-06-17 12:42:20 +02:00
669c940ec3
Revert "DEV: Remove the remaining ENV["TRAVIS"] usage ( #10041 )"
...
This reverts commit 78aff841e3215c875e79692fbeaf8d18c4514006.
See https://review.discourse.org/t/dev-remove-the-remaining-env-travis-usage-10041/12737/4?u=cvx
2020-06-16 19:42:00 +02:00
78aff841e3
DEV: Remove the remaining ENV["TRAVIS"] usage ( #10041 )
2020-06-16 17:41:15 +02:00
5bfe1ee4f1
FEATURE: Improve UX support for multiple email addresses ( #9691 )
2020-06-10 19:11:49 +03:00
31a527a293
FIX: Return 400 when invalid topic_id is provided when creating invite.
2020-06-10 09:29:28 +08:00
45fd668dc5
DEV: Render a proper response that can be handled on the client side.
2020-06-10 09:25:58 +08:00
3094459cd9
FEATURE: multiple use invite links ( #9813 )
2020-06-09 20:49:32 +05:30
0bf753a739
DEV: Remove unused routes
2020-06-08 10:26:29 +02:00
8c6a42c589
FIX: Redirects containing Unicode usernames didn't work
2020-06-08 10:26:29 +02:00
de29b4a511
PERF: rate limit search, and add anon cache for search results ( #9969 )
...
Adds new hidden site settings for rate limits:
30 for logged in users, 15 for anon
Adds an anon cache for searching, caches results of searches for 1 minute
2020-06-04 09:26:08 -07:00
