Commit Graph

32944 Commits

Author SHA1 Message Date
4bbb34f7cb REFACTOR: admin-user (#7475) 2019-05-07 10:53:21 +02:00
f73ed45429 REFACTOR: color-scheme model (#7477) 2019-05-07 10:51:52 +02:00
9507eff927 REFACTOR: resumable-upload (#7474) 2019-05-07 10:51:11 +02:00
c487dff776 early preview of new emojis (#7486) 2019-05-07 10:49:15 +02:00
4696be4c19 DEV: Fix failling test. 2019-05-07 11:19:13 +03:00
2adbec1b3c PERF: Speed up migrate_to_s3 rake task by deleting optimized image record.
No point moving all optimized image files to tombstone when the store is
changing. Also, `destroy_all` can easily blow memory since we are no
loading in batches.
2019-05-07 16:10:32 +08:00
e4abc51866 DEV: avoid using send when we can simply call the method 2019-05-07 16:50:45 +10:00
4ff1195537 FEATURE: Use Beacon API for tracking clicks. (#7483) 2019-05-07 16:37:43 +10:00
9adfd66a8b Revert "FIX: When mutating a string to build a diff. Duplicate it first (#7482)" (#7484)
This reverts commit 20d4093a673f45d7efa7f00dbbe6f563c1ca4598.
2019-05-07 16:36:23 +10:00
Joe
cf99431c18 Fix like and flag button count alignment (#7487) 2019-05-07 16:34:29 +10:00
abbc639e0d FIX: Only unregister service workers that belongs to Discourse. 2019-05-07 13:08:06 +08:00
03169401ff UX: correct order of site statistics on /about page 2019-05-07 09:50:41 +05:30
e219588142 DEV: Prefabrication (test optimization) (#7414)
* Introduced fab!, a helper that creates database state for a group

It's almost identical to let_it_be, except:

 1. It creates a new object for each test by default,
 2. You can disable it using PREFABRICATION=0
2019-05-07 13:12:20 +10:00
329969ea20 FIX: Discobot mention tutorial should be case insensitive. 2019-05-07 10:54:22 +08:00
e2bcf55077 DEV: move send => public_send in lib folder
This handles most of the cases in `lib` where we were using send instead
of public_send
2019-05-07 12:25:44 +10:00
451f7842ff DEV: More send -> public_send. 2019-05-07 10:05:58 +08:00
cac80cdc3b DEV: more send -> public_send changes
This is a work in progress commit for more send to public_send conversions

Also adds some comments for cases where we need to keep send
2019-05-07 11:58:06 +10:00
61cc0f8c5f Follow up to 152238b4cff7ab4c4ce63ba26abd23b0abf05129. 2019-05-07 09:57:27 +08:00
1e7c4592dc Fix rebase fail in 152238b4cff7ab4c4ce63ba26abd23b0abf05129. 2019-05-07 09:46:07 +08:00
152238b4cf DEV: Prefer public_send over send. 2019-05-07 09:33:21 +08:00
9be70a22cd DEV: introduce new API to look up dynamic site setting
This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup

This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class

It also removes a couple of risky stubs from the auth provider test
2019-05-07 11:00:30 +10:00
47995d2d89 FIX: Your own likes were missing on posts 2019-05-06 20:03:50 -04:00
20f84a364b Correct regression, correctly raise exception when setting incorrect param 2019-05-07 09:48:14 +10:00
c8418595bf SECURITY: avoid use of send in favor of public_send 2019-05-07 09:41:05 +10:00
e9564c999f FIX: We just show likes to see like count 2019-05-06 18:19:45 -04:00
310e196aca FIX: like-count has been removed from the post menu 2019-05-06 17:48:57 -04:00
18d742d334 FIX: Broken spec 2019-05-06 17:09:08 -04:00
31e100530f FEATURE: Flag count in post menu
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
e6843afa9e FIX: don't send post edit notification when hidden tags are changed 2019-05-06 15:45:06 -04:00
5de750d373 FIX: don't bump topics when hidden tags are added or removed 2019-05-06 14:52:18 -04:00
39260c841e DEV: Add test for click-track and mention links.
Follow-up to b81d169e.
2019-05-06 19:29:51 +03:00
233d3f611b DEV: Fix test. 2019-05-06 19:29:51 +03:00
20d4093a67 FIX: When mutating a string to build a diff. Duplicate it first (#7482) 2019-05-06 13:20:10 -03:00
e67ba8517d DEV: Add test for click-track and <a> without href.
Follow-up to b9339e15.
2019-05-06 18:38:57 +03:00
5e546ba7d1 Standardize viewport rules for mobile and desktop
Also removes`maximum-scale` on non-mobile devices, better for accessibility.
2019-05-06 10:28:29 -04:00
e2e72f4e8e DEV: rename ReadOnly module to ReadOnlyHeader 2019-05-06 16:07:49 +02:00
33e06dd796 FIX: Make select all and below skip small actions. (#7425) 2019-05-06 16:22:11 +03:00
a40dcbde9b FIX: Do not move hidden post actions. (#7424)
Hidden (staff-only) post actions are whisper posts with no content, that
are later transformed by the client into post actions (discourse-assign
uses this).
2019-05-06 16:21:42 +03:00
d679c4e0eb Bump onebox version.
- FIX: encode the URL per RFC 3986 spec
2019-05-06 18:17:42 +05:30
74ca49d7cd FIX: Importing of polls from phpBB3 was broken
Follow-up to 24369a81
2019-05-06 12:37:19 +02:00
c96b617bf6 FIX: Don't trigger PG failover when running db:migrate. 2019-05-06 17:03:28 +08:00
8217d5be78 UX: Switch mobile header back for 5s when notification comes in. 2019-05-06 16:58:25 +08:00
bcdf5823a0 DEV: correct frozen string and broken spec
This needs to be properly handled so the correct message is raised

1 item was removed from the serializer (avg_time)
2019-05-06 17:31:35 +10:00
6ba914033c FEATURE: rake task to bulk grant badge to members of a group 2019-05-06 12:41:50 +05:30
f8eddd40ad PERF: remove avg_time calculations and regular jobs from posts and topics
After careful analysis of large data-sets it became apparent that avg_time
had no impact whatsoever on "best of" topic scoring. Calculating avg_time
was a very costly operation especially on large databases.

We have some longer term plans of introducing other weighting that is read
time based into our scoring for "best of" and "top" topics, but in the
interim to stop a large amount of work that is not achieving any value we
are removing the jobs.

Column removal will follow once we decide on a new replacement metric.
2019-05-06 15:59:01 +10:00
ba3cf7109c DEV: Remove unused lines of code. 2019-05-06 13:48:51 +08:00
b7b9960558 DEV: Fix missing port in URLs in development mode. 2019-05-06 13:26:57 +08:00
267d129f38 FEATURE: only scroll to bottom for discobot
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
d4bf7d6831 FIX: correctly display browser is old message to IE10
We dropped support for IE10 a while back but never amended the banner to
show it is not supported.

This properly drops support.
2019-05-06 10:45:45 +10:00
12e78d8915 DEV: add wrapper for rspec running in docker 2019-05-05 13:43:45 +10:00