142571bba0
Remove use of rescue nil.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
226ace1643
Update annotations.
2018-02-20 14:28:58 +08:00
a7c1b0c81f
FIX: path whitelist for embedded comments didn't work with non-ASCII chars
2017-12-12 20:17:46 +01:00
daeb7694bc
update annotations
2017-12-05 21:03:20 +05:30
c68999e128
annotate models
...
WARNING annotators out there, be to run bin/annotate on RAILS_ENV=test on a clean db
2017-08-16 10:38:11 -04:00
57a214e920
FIX: First load of embed comments would always fail on WebKit
2017-08-02 17:43:31 -03:00
baf011cbf6
annotate models
2017-05-12 14:47:08 -04:00
4bf8548dc5
Add embed class name setup for embeddable hosts
2017-05-11 15:16:16 -04:00
5f47603b07
FIX: increase host_must_be_valid regex for .technology TLD
...
.technology is 11 chars long and wasn't being matched previously
2017-04-15 21:06:51 +10:00
ae957bca25
Allow ports for embed host IPs
2017-03-15 18:16:34 -03:00
bf9626d031
FIX: Embedding was broken with non-english URLs and ports
2017-02-27 12:17:52 -05:00
e62c0a42fa
FIX: Support multiple embeddable host records with the same host
2017-02-17 12:41:34 -05:00
e03c1e4cdf
annotate models
2016-10-31 15:02:11 +05:30
20241a01e9
FIX: Run the regular expression against query parameters
2016-08-26 12:47:47 -04:00
c3a3aff120
FEATURE: Support for a whitelist for embeddable host paths
2016-08-23 14:56:12 -04:00
e9db03e465
allow localhost as an embeddedable host
2016-07-22 15:54:26 -04:00
32c681c96b
annotate models
2016-02-23 10:33:53 +11:00
2a84db73b5
Support IP addresses for embeddable hosts
2016-01-11 11:06:32 -05:00
436da215ae
FIX: allow .network as a domain name
2015-12-15 18:01:31 +11:00
c1ecd6f4ce
update annotations
2015-09-18 10:41:10 +10:00
d1c69189f3
FEATURE: Can edit category/host relationships for embedding
2015-08-20 15:56:04 -04:00
