Commit Graph

27156 Commits

Author SHA1 Message Date
5840fb5c62 UX: Update topics stats automatically (#17135)
Updates automatically data on the stats section of the topic.

It will update automatically the following information: likes, replies and last reply (timestamp and user)
2022-06-27 18:21:05 -03:00
f56c44d1c7 FEATURE: Validate tags in WatchedWords (#17254)
* FEATURE: Validate tags in WatchedWords

We didn't validate watched words automatic tagging, so it was possible
for an admin to created watched words with an empty tag list which would
result in an exception when users tried to create a new topic that
matched the misconfigured watched word.

Bug report: https://meta.discourse.org/t/lib-topic-creator-fails-when-the-word-math-appears-in-the-topic-title-or-text/231018?u=falco
2022-06-27 16:16:33 -03:00
94e59ad9b6 DEV: Update html-entities (#17250) 2022-06-27 18:40:58 +02:00
f8691d12e1 DEV: Update ember-cli-app-version (#17253) 2022-06-27 18:13:56 +02:00
f505221a9c DEV: Update ember-cli-terser (#17252) 2022-06-27 18:13:46 +02:00
1344e7d62c DEV: Update js-yaml (#17249) 2022-06-27 18:13:29 +02:00
6a2ea012c7 DEV: Update @glimmer/tracking (#17248) 2022-06-27 18:13:04 +02:00
9874fe3fb3 FIX: Improve mixcloud oneboxing (#17237)
- Sets `https://www.mixcloud.com` as a `requires_iframe_origins` to allow the iframe content to be displayed
- Attempts to render something approximating the Mixcloud content in the preview pane of the Composer, rather than just displaying a large version of the artwork associated with the link
2022-06-27 08:32:24 +10:00
Joe
526115f11a FIX: Defer removing the splash screen until the window load event fires take 3 (#17238)
We currently remove the splash screen once Discourse starts booting.

This can be an issue on very slow devices, which can take up to 6 seconds. This PR ensures that we don't remove the splash until the browser has finished parsing all of the site's assets. It won't impact fast devices.

Internal topic /t/65378/60
2022-06-25 12:59:16 +08:00
305c4750df UX: allow more mobile topic elements to be tapped (#17234) 2022-06-24 15:55:52 -04:00
c672144c14 DEV: Fix flaky tests caused by timezone updates (#17232)
Hopefully fixes flakes like:

```
not ok 1123 Chrome 102.0 - [undefined ms] - Global error: Uncaught Error: Unhandled request in test environment: /forum/u/eviltrout.json (PUT) at http://localhost:7357/assets/vendor.js, line 38378
 While executing test: Unit | Utility | click-track: routes to absolute internal urls
    ---
        browser log: |
            {"type":"error","text":"Unhandled request in test environment: /forum/u/eviltrout.json (PUT)"}
            {"type":"error","text":"Uncaught Error: Unhandled request in test environment: /forum/u/eviltrout.json (PUT) at http://localhost:7357/assets/vendor.js, line 38378\n","testContext":{"id":1123,"name":"Unit | Utility | click-track: routes to absolute internal urls","items":[],"state":"executing"}}
    ...
```
2022-06-24 19:19:11 +02:00
9669794f85 DEV: Remove more legacy ember code (#17218)
Also fixes flaky d-editor tests
2022-06-24 18:56:08 +02:00
Joe
f73796b258 FIX: Skip the window load event for now (#17231) 2022-06-24 19:23:33 +08:00
Joe
529c5e343d FIX: Defer removing the splash screen until the window load event fires take 2 (#17230)
There's an obscure bug where really slow devices end up removing the splash screen before they're finished parsing all of the Discourse assets.

This PR won't impact fast devices but should hopefully prevent the premature removal of the splash on super slow devices.
2022-06-24 17:39:26 +08:00
Joe
e993a23a54 FIX: Remove splash screen in no-js view take 2 (#17229)
We use javascript to remove the splash screen when the site boots up. If the user has js disabled, they get stuck on the splash screen.

If the user has js disabled. We don't show the splash screen at all.
2022-06-24 17:38:42 +08:00
bd85c15acb DEV: Update broccoli-babel-transpiler (#17221)
Fixes concurrent addon build lockups.
2022-06-24 10:48:05 +02:00
Joe
07cb8e5300 FIX: Reverts #17225 & #17223 (#17228)
* Revert "FIX: Defer removing the splash screen until the window load event fires (#17225)"

This reverts commit 6a61e855b3362f88bb0faa416c98f9a8328454f6.

* Revert "FIX: Remove splash screen in no-js view (#17223)"

This reverts commit 5257cae1b804c61064de417c7046478cebd99752.
2022-06-24 15:59:27 +10:00
7d41e980c9 FIX: Uninitialized class variable error in sidekiq (#17227)
Follow-up to 4199ada1ce341212e3d2d4890074db9de018d7a4
2022-06-24 14:17:39 +10:00
3f5e19c62a FIX: Typo in log_thread (#17226)
Follow up to 4199ada1ce341212e3d2d4890074db9de018d7a4
2022-06-24 12:12:30 +08:00
Joe
6a61e855b3 FIX: Defer removing the splash screen until the window load event fires (#17225)
There's an obscure bug where really slow devices end up removing the splash screen before they're finished parsing all of the Discourse assets.

This PR won't impact fast devices but should hopefully prevent the premature removal of the splash on super slow devices.
2022-06-24 11:27:41 +08:00
7b2ad1b931 UX: Truncate long category names in sidebar (#17203) 2022-06-24 10:28:35 +08:00
4199ada1ce DEV: Ensure Sidekiq logging thread is always running (#17211) 2022-06-24 10:28:18 +08:00
d1d6868325 DEV: Update xss.js (#17216)
* DEV: Update xss.js

* Fix our hack
2022-06-24 10:28:05 +08:00
Joe
5257cae1b8 FIX: Remove splash screen in no-js view (#17223)
We use javascript to remove the splash screen when the site boots up. If the user has js disabled, they get stuck on the splash screen.

If the user has js disabled. We don't show the splash screen at all.
2022-06-24 09:25:10 +08:00
f27dddd405 DEV: Make addons buildable on their own (#17205) 2022-06-23 22:19:54 +02:00
20e34b5da6 DEV: Stabilize watched words order (#17215)
Fixes a flaky spec:

```
  1) WordWatcher.word_matcher_regexp format of the result regexp is correct when watched_words_regular_expressions = true
     Failure/Error: expect(regexp.inspect).to eq("/(#{word1})|(#{word2})/i")

       expected: "/(word35)|(word36)/i"
            got: "/(word36)|(word35)/i"

       (compared using ==)
     # ./spec/services/word_watcher_spec.rb:19:in `block (4 levels) in <main>'
```
2022-06-23 15:38:12 +02:00
16550537d0 DEV: Drop ember-maybe-import-regenerator (#17195)
I believe it's no longer needed on the browsers we support
2022-06-23 15:20:10 +02:00
3cb67fcb6c DEV: Update ember-cli-htmlbars (#17194) 2022-06-23 14:36:50 +02:00
56d3bd5bdd DEV: Update @glimmer/component (#17197) 2022-06-23 13:35:42 +02:00
Joe
293323af38 UX: Splash screen v1 improvements (#17214)
This commit does six things

* changes the animation for the splash screen. To a more subtle animation.
* defers displaying the splash by 1.5 seconds
* defers displaying the splash "loading" text by 2.5 seconds
* defers removing the splash until all Discourse initializers have run
* fixes a display issue in Firefox
* Inlines the SVG as a base64 and inlines the required CSS.

The encoded SVG is hard coded for now, but we will use a helper to generate that based on the file after some testing.
2022-06-23 14:07:04 +08:00
a176b57be0 FIX: Use bookmarkable pattern for bookmark cleanup (#17202)
We have a `cleanup!` class method on bookmarks that deletes
bookmarks X days after their related record (post/topic) are
deleted. This commit changes this method to use the
registered_bookmarkables for this instead, and each bookmarkable
type can delete related bookmarks in their own way.
2022-06-23 14:09:39 +10:00
b546e09dd9 FIX: In [DELETE] /admin/user/:id.json, parse boolean block_* parameter correctly (#17201)
When calling the API to delete a user:

```
curl -X DELETE "https://discourse.example.com/admin/users/159.json" \
-H "Content-Type: multipart/form-data;" \
-H "Api-Key: ***" \
-H "Api-Username: ***" \
-F "delete_posts=true" \
-F "block_email=false" \
-F "block_urls=false" \
-F "block_ip=false"
```

Setting the parameters `block_email`, `block_urls` and `block_ip`explicitly to `false` did not work because the values weren't being parsed to boolean.
2022-06-22 18:20:41 -03:00
6f32d605ba UX: improve group page grid sizes (#17208) 2022-06-22 17:14:22 -04:00
a0f3ec7b13 FIX: darkMode availiability detection was broken (#17207)
This regressed on 2f66eb5 where CSS was moved from the HTML document
head to the body.

Bug report at https://meta.discourse.org/t/-/230656?u=falco
2022-06-22 14:32:13 -03:00
684bc821be DEV: allows category-badge helper to display a link (#17206) 2022-06-22 18:36:49 +02:00
278752fa87 Change the background color of the user status bubble (#17204) 2022-06-22 19:40:21 +04:00
033f72c65f FEATURE: user status emoji (#17025) 2022-06-22 18:15:33 +04:00
0b8e6adabe FEATURE: New/unread messages count in experimental sidebar (#17117)
* FEATURE: Expand messages filter links when viewing private messages.

* FEATURE: New/unread messages count in experimental sidebar
2022-06-22 11:01:37 +08:00
b09cce6897 DEV: Update ember-source-channel-url (#17196) 2022-06-22 00:12:43 +02:00
06feeed187 DEV: Update @ember/optional-features (#17193) 2022-06-22 00:12:33 +02:00
216663effa DEV: Update ember-cli-dependency-checker (#17192) 2022-06-22 00:12:24 +02:00
b50056a9f3 DEV: Update ember-cli-inject-live-reload (#17191) 2022-06-22 00:12:15 +02:00
1e522b0ee7 DEV: Update ember-buffered-proxy (#17190) 2022-06-22 00:12:04 +02:00
0421a14319 DEV: Actually debounce functions in tests (#16213) 2022-06-21 23:34:04 +02:00
Joe
e82a2ce9ae UX: Introduces a splash screen behind a hidden site setting (#17094)
This PR introduces a new hidden site setting that allows admins to display a splash screen while site assets load.

The splash screen can be enabled via the `splash_screen` hidden site setting.

This is what the splash screen currently looks like

5ceb72f085.mp4

Once site assets load, the splash screen is automatically removed.

To control the loading text that shows in the splash screen, you can change the preloader_text translation string in admin > customize > text
2022-06-22 04:35:46 +08:00
624c684d51 DEV: Transpile all plugin js by default (#17175)
Goodbye `# transpile_js: true`? 🙂
2022-06-21 22:07:10 +02:00
9cb9d1105e DEV: Update ember-auto-import (#17176) 2022-06-21 22:06:41 +02:00
7fd38f4933 DEV: Remove isLegacyEmber (#17181) 2022-06-21 15:01:03 -05:00
41028a84ef DEV: add deprecation notice to isLegacyEmber (#17186) 2022-06-21 14:08:12 -05:00
e0ba35350e FEATURE: Custom unsubscribe options (#17090)
With this change, plugins can create custom unsubscribe keys, extend the unsubscribe view with custom preferences, and decide how they are updated.
2022-06-21 15:49:47 -03:00