mirror of
https://github.com/discourse/discourse.git
synced 2025-06-14 19:29:21 +08:00
0de08e780b
This improves the error message(s) displayed when an error happens while using a social login to log in / sign up into a Discourse community. Unfortunately, we can't be super precise in the reason behind the error (it can be the user clicked "cancel" during the authorization phase, or any of the plethora of other possible errors) because the reason isn't provided (either for security reasons, or because it's just hard to do so in a reliable & consistent way accross all social logins). The best I could do was to - add the name of the "social login" provider in the error message - tweak the copy a bit for the different cases handle - fix the CSS/HTML to match the one used by the main application In order to show the name of the provider, we use either the "provider" or the "strategy" query parameter, or use the name of the authenticator (if it's the only one enabled). Internal ref - t/153662 --- **BEFORE**  **AFTER** 
48 lines
1.4 KiB
Ruby
48 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Auth::TwitterAuthenticator < Auth::ManagedAuthenticator
|
|
def name
|
|
"twitter"
|
|
end
|
|
|
|
def display_name
|
|
"X / Twitter"
|
|
end
|
|
|
|
def enabled?
|
|
SiteSetting.enable_twitter_logins
|
|
end
|
|
|
|
def healthy?
|
|
connection =
|
|
Faraday.new(url: "https://api.twitter.com") do |config|
|
|
config.basic_auth(SiteSetting.twitter_consumer_key, SiteSetting.twitter_consumer_secret)
|
|
end
|
|
connection.post("/oauth2/token").status == 200
|
|
rescue Faraday::Error
|
|
false
|
|
end
|
|
|
|
def after_authenticate(auth_token, existing_account: nil)
|
|
# Twitter sends a huge amount of data which we don't need, so ignore it
|
|
auth_token[:extra] = {}
|
|
super
|
|
end
|
|
|
|
def register_middleware(omniauth)
|
|
omniauth.provider :twitter,
|
|
setup:
|
|
lambda { |env|
|
|
strategy = env["omniauth.strategy"]
|
|
strategy.options[:consumer_key] = SiteSetting.twitter_consumer_key
|
|
strategy.options[:consumer_secret] = SiteSetting.twitter_consumer_secret
|
|
}
|
|
end
|
|
|
|
# twitter doesn't return unverfied email addresses in the API
|
|
# https://developer.twitter.com/en/docs/twitter-api/v1/accounts-and-users/manage-account-settings/api-reference/get-account-verify_credentials
|
|
def primary_email_verified?(auth_token)
|
|
true
|
|
end
|
|
end
|